Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105030/#review14683 --- This review has been submitted with commit c6b51b8f6a2f10269d2

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105030/#review14511 --- This review has been submitted with commit 65e991a5e680acd9f58

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

> On June 8, 2012, 7:13 a.m., Thorsten Zachmann wrote: > > stage/part/animations/strategy/KPrSmilValues.cpp, line 131 > > > > > > The brackets are not needed please remove. Thanks, I fixed the brackets issue. - P

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105030/ --- (Updated June 8, 2012, 8:04 a.m.) Review request for Calligra. Descripti

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105030/#review14508 --- Ship it! That was a fast update. Nice work. Please fix the one

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105030/ --- (Updated June 8, 2012, 5:57 a.m.) Review request for Calligra. Changes -

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105030/#review14505 --- Looks already quite good. Most of the things I commented is eit

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

> On May 26, 2012, 5:44 a.m., Thorsten Zachmann wrote: > > stage/part/animations/strategy/KPrSmilValues.cpp, lines 80-86 > > > > > > When loading a formula the smil:values is not used so I guess it should > > not be

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

> On May 27, 2012, 4:21 a.m., Thorsten Zachmann wrote: > > There are still 2 classes in the code for parsing the data. I think it > > would be best if you add the new functionality of KPrFormulaParser to > > KPrValueParser and remove the KPrFormulaParser. If you think > > KPrFormulaParser is t

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

> On May 26, 2012, 5:44 a.m., Thorsten Zachmann wrote: > > stage/part/animations/strategy/KPrSmilValues.cpp, lines 80-86 > > > > > > When loading a formula the smil:values is not used so I guess it should > > not be

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105030/ --- (Updated May 27, 2012, 3:04 p.m.) Review request for Calligra. Changes -

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

> On May 26, 2012, 5:44 a.m., Thorsten Zachmann wrote: > > stage/part/animations/strategy/KPrSmilValues.cpp, lines 80-86 > > > > > > When loading a formula the smil:values is not used so I guess it should > > not be

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105030/#review14200 --- There are still 2 classes in the code for parsing the data. I t

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

> On May 26, 2012, 5:44 a.m., Thorsten Zachmann wrote: > > stage/part/animations/strategy/KPrSmilValues.cpp, lines 80-86 > > > > > > When loading a formula the smil:values is not used so I guess it should > > not be

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105030/ --- (Updated May 26, 2012, 7:03 p.m.) Review request for Calligra. Changes -

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105030/#review14168 --- stage/part/animations/strategy/KPrSmilValues.cpp

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105030/#review14167 --- The new class KPrFormulaParser and the class KPrFormulaParser a

Review Request: GSoC: Add support of Anim:Formula tag in Stage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105030/ --- Review request for Calligra. Description --- Add support for Anim:For