----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105030/#review14200 -----------------------------------------------------------
There are still 2 classes in the code for parsing the data. I think it would be best if you add the new functionality of KPrFormulaParser to KPrValueParser and remove the KPrFormulaParser. If you think KPrFormulaParser is the better name please rename the class in a separate commit. stage/part/animations/strategy/KPrFormulaParser.cpp <http://git.reviewboard.kde.org/r/105030/#comment11224> stage/part/animations/strategy/KPrSmilValues.cpp <http://git.reviewboard.kde.org/r/105030/#comment11220> This should only be written out if values is not empty as it is not needed when there is a anim:formula. - Thorsten Zachmann On May 26, 2012, 7:03 p.m., Paul Mendez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105030/ > ----------------------------------------------------------- > > (Updated May 26, 2012, 7:03 p.m.) > > > Review request for Calligra. > > > Description > ------- > > Add support for Anim:Formula tag in Stage. (That key is part of ODF > animations specification). > > Note: animations tested don't run as smooth as in LibreOffice because > KeySplines tag is not implemented. > > > Diffs > ----- > > stage/part/CMakeLists.txt 3c7916ef7496af21e65d9a5441d5cb924829c347 > stage/part/animations/KPrAnimate.cpp > dddd1fa401d596e7e23688f950428cd0ea76b639 > stage/part/animations/strategy/KPrFormulaParser.h PRE-CREATION > stage/part/animations/strategy/KPrFormulaParser.cpp PRE-CREATION > stage/part/animations/strategy/KPrSmilValues.h > 163d78b830a151ce150192000890a395f9e273dd > stage/part/animations/strategy/KPrSmilValues.cpp > 3faafc4eb1c8783224f9f32c38106407cc219096 > stage/part/animations/strategy/KPrValueParser.h > 8f3c6ebcdf7ae9f5d938d97d518f21977b572940 > > Diff: http://git.reviewboard.kde.org/r/105030/diff/ > > > Testing > ------- > > Test some animations of documents created in Libre Office (One test document > is also uploaded) > > > Thanks, > > Paul Mendez > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
