Re: Review Request: Fix drawing of shadows for shapes

2012-04-21 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104615/ --- (Updated April 21, 2012, 7:30 p.m.) Review request for Calligra, Yue Liu,

Re: Review Request: Fix drawing of shadows for shapes

2012-04-17 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104615/#review12625 --- I found a problem with the drawing of the shadow of a rotated r

Re: Review Request: Fix drawing of shadows for shapes

2012-04-17 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104615/ --- (Updated April 17, 2012, 10:32 a.m.) Review request for Calligra, Yue Liu,

Re: Review Request: Fix drawing of shadows for shapes

2012-04-17 Thread C. Boemann
> On April 16, 2012, 11:45 p.m., Inge Wallin wrote: > > I may not understand the problem fully, but it seems that not only does it > > paint the shadow too big but it also doesn't take the shadow into account > > when laying out out the text. There is a method KoShape::boundingRect() > > whos

Re: Review Request: Fix drawing of shadows for shapes

2012-04-17 Thread Inge Wallin
> On April 16, 2012, 11:45 p.m., Inge Wallin wrote: > > I may not understand the problem fully, but it seems that not only does it > > paint the shadow too big but it also doesn't take the shadow into account > > when laying out out the text. There is a method KoShape::boundingRect() > > whos

Re: Review Request: Fix drawing of shadows for shapes

2012-04-16 Thread C. Boemann
> On April 16, 2012, 11:45 p.m., Inge Wallin wrote: > > I may not understand the problem fully, but it seems that not only does it > > paint the shadow too big but it also doesn't take the shadow into account > > when laying out out the text. There is a method KoShape::boundingRect() > > whos

Re: Review Request: Fix drawing of shadows for shapes

2012-04-16 Thread C. Boemann
> On April 16, 2012, 11:45 p.m., Inge Wallin wrote: > > I may not understand the problem fully, but it seems that not only does it > > paint the shadow too big but it also doesn't take the shadow into account > > when laying out out the text. There is a method KoShape::boundingRect() > > whos

Re: Review Request: Fix drawing of shadows for shapes

2012-04-16 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104615/#review12546 --- I may not understand the problem fully, but it seems that not o

Re: Review Request: Fix drawing of shadows for shapes

2012-04-16 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104615/ --- (Updated April 16, 2012, 2:03 p.m.) Review request for Calligra, Yue Liu,

Review Request: Fix drawing of shadows for shapes

2012-04-16 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104615/ --- Review request for Calligra, Yue Liu, Jan Hambrecht, and Thorsten Zachmann.