Re: Review Request: Fix crashing when using tools on empty image

2011-11-02 Thread Mark Gaiser
> On Oct. 31, 2011, 7:43 p.m., Dmitry Kazakov wrote: > > Thanks for the fix! =) > > Just two small things: > > 1) I think it would be logical to reset the stroke id right after > > endStroke(m_strokeId) in mouseReleaseEvent() function. Like: > >image->endStroke(m_strokeId); > >m_strokeI

Re: Review Request: Fix crashing when using tools on empty image

2011-10-31 Thread Boudewijn Rempt
On Monday 31 October 2011 Oct, Torio Mlshi wrote: > > > On Oct. 31, 2011, 7:43 p.m., Dmitry Kazakov wrote: > > > Thanks for the fix! =) > > > Just two small things: > > > 1) I think it would be logical to reset the stroke id right after > > > endStroke(m_strokeId) in mouseReleaseEvent() function

Re: Review Request: Fix crashing when using tools on empty image

2011-10-31 Thread Torio Mlshi
> On Oct. 31, 2011, 7:43 p.m., Dmitry Kazakov wrote: > > Thanks for the fix! =) > > Just two small things: > > 1) I think it would be logical to reset the stroke id right after > > endStroke(m_strokeId) in mouseReleaseEvent() function. Like: > >image->endStroke(m_strokeId); > >m_strokeI

Re: Review Request: Fix crashing when using tools on empty image

2011-10-31 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103003/#review7782 --- Ship it! Thanks for the fix! =) Just two small things: 1) I th

Review Request: Fix crashing when using tools on empty image

2011-10-31 Thread Torio Mlshi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103003/ --- Review request for Calligra. Summary (updated) - Fix cras