> On Oct. 31, 2011, 7:43 p.m., Dmitry Kazakov wrote: > > Thanks for the fix! =) > > Just two small things: > > 1) I think it would be logical to reset the stroke id right after > > endStroke(m_strokeId) in mouseReleaseEvent() function. Like: > > image->endStroke(m_strokeId); > > m_strokeId.clear(); > > 2) And we are using kde coding style for positioning braces around 'if's ;) > > [1] > > > > > > [1] - http://techbase.kde.org/Policies/Kdelibs_Coding_Style > > Torio Mlshi wrote: > Fixed & pushed. And thanks for the link: I was really confused about > format rules as there are different pieces with different style (probably old > code) =)
Please mark it as commited. Guess you forgot to add REVIEW: 103003 to the commit message ;-) - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103003/#review7782 ----------------------------------------------------------- On Oct. 31, 2011, 7:26 p.m., Torio Mlshi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103003/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2011, 7:26 p.m.) > > > Review request for Calligra. > > > Description > ------- > > When image is empty (has no layers), color picker & move tools caused crashes > when using. This patch adds checking if currentNode() returns 0. If so, no > action is done. > > > Diffs > ----- > > krita/plugins/tools/defaulttools/kis_tool_colorpicker.cc 006aa78 > krita/plugins/tools/defaulttools/kis_tool_move.cc 1ee0baa > > Diff: http://git.reviewboard.kde.org/r/103003/diff/diff > > > Testing > ------- > > > Thanks, > > Torio Mlshi > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
