Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/#review23484 --- This review has been submitted with commit 3de63476d3ce2b088cd

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/#review23355 --- Ship it! Thanks. I'll commit with other patches. - Jarosław S

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/ --- (Updated Dec. 12, 2012, 1:44 p.m.) Review request for Calligra and Jarosła

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/#review23351 --- kexi/core/kexidataiteminterface.h

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

> On Dec. 9, 2012, 8:56 p.m., Jarosław Staniek wrote: > > kexi/core/kexidataiteminterface.h, line 181 > > > > > > Never use meaningless names such as 'x'; > > > > x -> set not fixed > On Dec. 9, 2012, 8:

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/ --- (Updated Dec. 12, 2012, 9:56 a.m.) Review request for Calligra and Jarosła

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

> On Dec. 9, 2012, 8:56 p.m., Jarosław Staniek wrote: > > kexi/core/KexiView.h, line 165 > > > > > > Please use 'const QString &iconName' not fixed > On Dec. 9, 2012, 8:56 p.m., Jarosław Staniek wrote: > > kexi/c

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/ --- (Updated Dec. 10, 2012, 9:46 a.m.) Review request for Calligra and Jarosła

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

> On Dec. 9, 2012, 8:56 p.m., Jarosław Staniek wrote: > > kexi/core/kexiprojectconnectiondata.cpp, line 153 > > > > > > this won't compile But it does! gcc-4.5.4 - Andrey --

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/ --- (Updated Dec. 7, 2012, 12:10 p.m.) Review request for Calligra and Jarosła

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/ --- (Updated Dec. 5, 2012, 1:26 p.m.) Review request for Calligra and Jarosław

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/ --- (Updated Dec. 2, 2012, 4:49 p.m.) Review request for Calligra and Jarosław

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/#review22839 --- I have indicated general problems, please study the d-pointers

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/ --- (Updated Nov. 30, 2012, 2:38 p.m.) Review request for Calligra and Jarosła

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/ --- (Updated Nov. 30, 2012, 2:38 p.m.) Review request for Calligra and Jarosła

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/ --- (Updated Nov. 30, 2012, 2:26 p.m.) Review request for Calligra and Jarosła

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/ --- (Updated Nov. 29, 2012, 3:57 p.m.) Review request for Calligra and Jarosła

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/ --- (Updated Nov. 29, 2012, 3:56 p.m.) Review request for Calligra. Descript

Review Request: Adds d-pointers to Kexi classes in kexi/core

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/ --- Review request for Calligra. Description --- Patch for kexi/core, ht