Re: Review Request 108569: Flake ConfigWidgets and user friendly interface

2013-02-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108569/#review26586 --- This review has been submitted with commit af0a52787676c8ff705

Re: Review Request 108569: Flake ConfigWidgets and user friendly interface

2013-02-03 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108569/#review26580 --- Ship it! Okay so with my last issues fixed in git, I think it'

Re: Review Request 108569: Flake ConfigWidgets and user friendly interface

2013-02-03 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108569/#review26570 --- lots of if () without {} libs/basicflakes/tools/KoPencilTool

Re: Review Request 108569: Flake ConfigWidgets and user friendly interface

2013-02-03 Thread Jean-Nicolas Artaud
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108569/ --- (Updated Feb. 3, 2013, 11:18 a.m.) Review request for Calligra. Changes

Re: Review Request 108569: Flake ConfigWidgets and user friendly interface

2013-01-25 Thread Jean-Nicolas Artaud
> On Jan. 24, 2013, 2:48 p.m., Arjen Hiemstra wrote: > > Quite nice, a good improvement on the existing UI. I have a bunch of > > comments on some of the details though. Thank you very much for this precise review. It will take me some time to correct all these points, but I'm on it, and I'll

Re: Review Request 108569: Flake ConfigWidgets and user friendly interface

2013-01-24 Thread Arjen Hiemstra
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108569/#review26131 --- Quite nice, a good improvement on the existing UI. I have a bun

Re: Review Request 108569: Flake ConfigWidgets and user friendly interface

2013-01-24 Thread Jean-Nicolas Artaud
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108569/ --- (Updated Jan. 24, 2013, 2:12 p.m.) Review request for Calligra. Changes

Re: Review Request 108569: Flake ConfigWidgets and user friendly interface

2013-01-24 Thread Jean-Nicolas Artaud
> On Jan. 24, 2013, 9:13 a.m., C. Boemann wrote: > > In general good quality, but some issues were identified > > > > I also think we can retire the stroke/fill docker. The fillconfig and > > strokeconfig widgets handle those things now. For that, we need a sort of the backround tool combined

Re: Review Request 108569: Flake ConfigWidgets and user friendly interface

2013-01-24 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108569/#review26113 --- In general good quality, but some issues were identified I als