Re: Review Request: Style inheritance

2011-11-07 Thread Pierre Ducroquet
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103017/#review8012 --- I won't comment on pure-coding issues as everybody else found, I

Re: Review Request: Style inheritance

2011-11-07 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103017/ --- (Updated Nov. 7, 2011, 5:33 p.m.) Review request for Calligra. Changes -

Re: Review Request: Style inheritance

2011-11-06 Thread Jarosław Staniek
> On Nov. 6, 2011, 2:01 p.m., Jarosław Staniek wrote: > > libs/kotext/styles/KoTableCellStyle.h, line 159 > > > > > > cannot be const? > > C. Boemann wrote: > well it's returning an internal member and yes that

Re: Review Request: Style inheritance

2011-11-06 Thread C. Boemann
> On Nov. 6, 2011, 2:01 p.m., Jarosław Staniek wrote: > > libs/kotext/styles/KoParagraphStyle.h, line 677 > > > > > > Extra bool arg is not good API, one day we'll remove all. Would be nice > > to avoid adding new

Re: Review Request: Style inheritance

2011-11-06 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103017/#review7974 --- libs/kotext/styles/KoCharacterStyle.cpp

Re: Review Request: Style inheritance

2011-11-06 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103017/ --- (Updated Nov. 6, 2011, 8:50 a.m.) Review request for Calligra. Changes -

Re: Review Request: Style inheritance

2011-11-06 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103017/ --- (Updated Nov. 6, 2011, 9:47 a.m.) Review request for Calligra. Changes -

Re: Review Request: Style inheritance

2011-11-05 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103017/ --- (Updated Nov. 5, 2011, 9:54 p.m.) Review request for Calligra. Changes -

Re: Review Request: Style inheritance

2011-11-01 Thread C. Boemann
> On Nov. 1, 2011, 8 p.m., Sebastian Sauer wrote: > > libs/kotext/styles/KoCharacterStyle.cpp, line 406 > > > > > > hmmm... does this mean we are applying the format way more often now? > > > > Consider; >

Re: Review Request: Style inheritance

2011-11-01 Thread Sebastian Sauer
> On Nov. 1, 2011, 8 p.m., Sebastian Sauer wrote: > > libs/kotext/KoTextEditor.cpp, line 796 > > > > > > KoParagraphStyle inherits from KoCharacterStyle so c-style cast not > > needed or? > > Ah, I see. They are n

Re: Review Request: Style inheritance

2011-11-01 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103017/#review7833 --- libs/kotext/KoTextEditor.cpp