Re: Review Request: New shape for 1-D and 2-D barcodes

> On April 17, 2012, 7:10 a.m., Inge Wallin wrote: > > Was this committed? I don't remember. In any case, please close this > > request. No, was not yet commited. I found out that the shape is not yet really ready for prime-time for some reasons, at least to my standards. Initially wanted to

Re: Review Request: New shape for 1-D and 2-D barcodes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104235/#review12556 --- Was this committed? I don't remember. In any case, please close

Re: Review Request: New shape for 1-D and 2-D barcodes

> On March 12, 2012, 4:27 a.m., Thorsten Zachmann wrote: > > Looks very good. I have added some style issues that should be fixed. After > > that I think it is good for inclusion. > > > > The filename of the classes should use camelcase. So the classes should be > > renamed to match the case o

Re: Review Request: New shape for 1-D and 2-D barcodes

> On March 12, 2012, 4:27 a.m., Thorsten Zachmann wrote: > > Looks very good. I have added some style issues that should be fixed. After > > that I think it is good for inclusion. > > > > The filename of the classes should use camelcase. So the classes should be > > renamed to match the case o

Re: Kexi reports based on shapes, form letters, diagrams using data sources (was: Re: Review Request: New shape for 1-D and 2-D barcodes)

On 15 March 2012 16:52, Friedrich W. H. Kossebau wrote: > Am Montag, 12. März 2012, 08:40:13 schrieb Adam Pigg: >> Kexi could do with an implementation of barcodes based on this, becuase the >> current version is hand-built, not using any library, and while it is >> assumed to work, its certainly

Kexi reports based on shapes, form letters, diagrams using data sources (was: Re: Review Request: New shape for 1-D and 2-D barcodes)

Am Montag, 12. März 2012, 08:40:13 schrieb Adam Pigg: > Kexi could do with an implementation of barcodes based on this, becuase the > current version is hand-built, not using any library, and while it is > assumed to work, its certainly not backed up with anything fully tested. Hm, I still am surp

Re: Review Request: New shape for 1-D and 2-D barcodes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104235/ --- (Updated March 12, 2012, 5:42 p.m.) Review request for Calligra. Changes

Re: Review Request: New shape for 1-D and 2-D barcodes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104235/ --- (Updated March 12, 2012, 4:34 p.m.) Review request for Calligra. Descrip

Re: Review Request: New shape for 1-D and 2-D barcodes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104235/ --- (Updated March 12, 2012, 4:34 p.m.) Review request for Calligra. Changes

Re: Review Request: New shape for 1-D and 2-D barcodes

> On March 12, 2012, 4:27 a.m., Thorsten Zachmann wrote: > > plugins/barcodeshape/barcodeshape.cpp, lines 206-210 > > > > > > I think this should be written better inside a switch statement. Is the > > static_cast

Re: Review Request: New shape for 1-D and 2-D barcodes

Hi Adam, Am Montag, 12. März 2012, 08:40:13 schrieb Adam Pigg: > Kexi could do with an implementation of barcodes based on this, becuase the > current version is hand-built, not using any library, and while it is > assumed to work, its certainly not backed up with anything fully tested. Ah, had n

Re: Review Request: New shape for 1-D and 2-D barcodes

Kexi could do with an implementation of barcodes based on this, becuase the current version is hand-built, not using any library, and while it is assumed to work, its certainly not backed up with anything fully tested. On Mon, Mar 12, 2012 at 5:03 AM, Thorsten Zachmann wrote: >This is an aut

Re: Review Request: New shape for 1-D and 2-D barcodes

> On March 12, 2012, 4:35 a.m., Sven Langkamp wrote: > > Haven't tested it, but I think that saving this way leads to invalid ODF > > files as custom elements are not allowed. It is allowed to have a custom element at this place. We do the same for the music shape. - Thorsten -

Re: Review Request: New shape for 1-D and 2-D barcodes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104235/#review11306 --- Haven't tested it, but I think that saving this way leads to in

Re: Review Request: New shape for 1-D and 2-D barcodes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104235/#review11304 --- Looks very good. I have added some style issues that should be