> On April 17, 2012, 7:10 a.m., Inge Wallin wrote: > > Was this committed? I don't remember. In any case, please close this > > request.
No, was not yet commited. I found out that the shape is not yet really ready for prime-time for some reasons, at least to my standards. Initially wanted to update this request once I fixed these issues. But right, better to close this request and open a new one only once things are done. Will refer to this here in the new request. - Friedrich W. H. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104235/#review12556 ----------------------------------------------------------- On March 12, 2012, 5:42 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104235/ > ----------------------------------------------------------- > > (Updated March 12, 2012, 5:42 p.m.) > > > Review request for Calligra. > > > Description > ------- > > Adds a shape for barcodes, based on the lib prison. > Adding, editing, saving and loading seems to work. > For non-Calligra consumers of the OpenDocument format a fallback image is > stored. > > > Diffs > ----- > > plugins/CMakeLists.txt 69e5d96 > plugins/barcodeshape/BarcodeShape.h PRE-CREATION > plugins/barcodeshape/BarcodeShape.cpp PRE-CREATION > plugins/barcodeshape/BarcodeShapeConfigCommand.h PRE-CREATION > plugins/barcodeshape/BarcodeShapeConfigCommand.cpp PRE-CREATION > plugins/barcodeshape/BarcodeShapeConfigWidget.h PRE-CREATION > plugins/barcodeshape/BarcodeShapeConfigWidget.cpp PRE-CREATION > plugins/barcodeshape/BarcodeShapeFactory.h PRE-CREATION > plugins/barcodeshape/BarcodeShapeFactory.cpp PRE-CREATION > plugins/barcodeshape/BarcodeShapePlugin.h PRE-CREATION > plugins/barcodeshape/BarcodeShapePlugin.cpp PRE-CREATION > plugins/barcodeshape/CMakeLists.txt PRE-CREATION > plugins/barcodeshape/Messages.sh PRE-CREATION > plugins/barcodeshape/barcodeshape.desktop PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/104235/diff/ > > > Testing > ------- > > Created, edited and deleted barcode shapes. Saved files with barcode shapes > and loaded them again. > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
