Re: Review Request: Fix regression in size of shape groups with a lot of shapes

2011-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102645/#review6771 --- This review has been submitted with commit d157fb7554710d7c4789

Re: Review Request: Fix regression in size of shape groups with a lot of shapes

2011-09-22 Thread Thorsten Zachmann
> On Sept. 22, 2011, 8:55 p.m., Jan Hambrecht wrote: > > All in all I think you can commit. However while looking at the code I had > > another idea. If the calculation of the size and the sizeCached member is > > moved to group shape model, we do not have to expose the > > invalidateCacheSize

Re: Review Request: Fix regression in size of shape groups with a lot of shapes

2011-09-22 Thread C. Boemann
> On Sept. 22, 2011, 8:55 p.m., Jan Hambrecht wrote: > > libs/flake/KoShapeContainerModel.cpp, line 41 > > > > > > I am not sure about that. Probably best to check with Caspar if it is > > ok with him. if the propo

Re: Review Request: Fix regression in size of shape groups with a lot of shapes

2011-09-22 Thread Jan Hambrecht
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102645/#review6744 --- Ship it! All in all I think you can commit. However while looki

Re: Review Request: Fix regression in size of shape groups with a lot of shapes

2011-09-21 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102645/ --- (Updated Sept. 22, 2011, 2:52 a.m.) Review request for Calligra. Changes

Re: Review Request: Fix regression in size of shape groups with a lot of shapes

2011-09-18 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102645/ --- (Updated Sept. 19, 2011, 5:16 a.m.) Review request for Calligra. Changes

Re: Review Request: Fix regression in size of shape groups with a lot of shapes

2011-09-18 Thread Jan Hambrecht
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102645/#review6618 --- First I think in general it would be nice to have. I have two th