----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102645/ -----------------------------------------------------------
(Updated Sept. 22, 2011, 2:52 a.m.) Review request for Calligra. Changes ------- Updated the summery to reflect that the patch is now ready for inclusion. Please provide feedback. Summary (updated) ------- With the fix for the group size now every time the function is called it calculates the size from its children. When testing this with cstester I found problmes in the documents I uploaded to. http://www.zagge.de/anchor/groupsize/ The problem there is that due the very huge amount of shapes in the group it takes now quite a very very long time to render the pages. The patch fixes that problem by adding a cache to the group size and only recalculates the size when there was a change. It additionally don't forward the ChildChanged when a CollisionDetection is encountered. The CollisonChanged is not needed to forward to any parent as if the results in a change this change will be probagated. The patch as it is now is ready for inclusion. The comments provided have been implemented. Looking forward to your feedback. Diffs ----- libs/flake/KoShapeContainerModel.cpp 7995236 libs/flake/KoShapeGroup.h a53d2ad libs/flake/KoShapeGroup.cpp 409b18c libs/flake/KoShape_p.h d055056 Diff: http://git.reviewboard.kde.org/r/102645/diff Testing ------- Before the patch switching between slides in the www.renaissance.co.il%2Fivbug%2Fmeeting87%2FArchitecture%20and%20design%20patterns.ppt file takes more then 10 seconds, with the patch it is instantly. Tested resizing of groups of groups, resizing/modifying of shapes in groups. Thanks, Thorsten
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
