Re: Review Request: Fix exporting to non-native formats on Windows, e.g. HTML

2012-11-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107388/#review22244 --- This review has been submitted with commit 6343696b68102245717

Re: Review Request: Fix exporting to non-native formats on Windows, e.g. HTML

2012-11-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107388/#review22243 --- This review has been submitted with commit 03e69de714fba8fd4b7

Re: Review Request: Fix exporting to non-native formats on Windows, e.g. HTML

2012-11-20 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107388/#review22241 --- Ship it! I'm fine with it now. Nice comment. :) - Inge Wall

Re: Review Request: Fix exporting to non-native formats on Windows, e.g. HTML

2012-11-20 Thread Friedrich W. H. Kossebau
> On Nov. 19, 2012, 9:59 p.m., Inge Wallin wrote: > > libs/main/KoFilterChain.cpp, lines 366-369 > > > > > > These things are so totally unobvious that I would expect an extensive > > comment on why things are done

Re: Review Request: Fix exporting to non-native formats on Windows, e.g. HTML

2012-11-20 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107388/ --- (Updated Nov. 20, 2012, 9:22 a.m.) Review request for Calligra, Boudewijn

Re: Review Request: Fix exporting to non-native formats on Windows, e.g. HTML

2012-11-19 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107388/#review4 --- I think these things need much more commenting. Other than tha

Re: Review Request: Fix exporting to non-native formats on Windows, e.g. HTML

2012-11-19 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107388/#review1 --- Looks good to me, but I cannot test it on windows - C. Boemann

Re: Review Request: Fix exporting to non-native formats on Windows, e.g. HTML

2012-11-19 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107388/ --- (Updated Nov. 19, 2012, 7:20 p.m.) Review request for Calligra, Boudewijn