----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107388/#review22224 -----------------------------------------------------------
I think these things need much more commenting. Other than that it looks good, I guess, but as boemann I can't test it on Windows. libs/main/KoFilterChain.cpp <http://git.reviewboard.kde.org/r/107388/#comment17104> These things are so totally unobvious that I would expect an extensive comment on why things are done the way they are and what the problem it solves is. - Inge Wallin On Nov. 19, 2012, 7:20 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107388/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2012, 7:20 p.m.) > > > Review request for Calligra, Boudewijn Rempt and C. Boemann. > > > Description > ------- > > Currently exporting to non-native formats (File/Export...) fails on Windows, > because the temporary files are empty on disk. > > The fix follows approach of bf47fed5ead06f2128abf042897f86bab39cf333 , > by destructing the KTemporaryFile object used to get a unique temporary > file name right after its creation again, to avoid having two file > handlers > on the same file, which seems somehow to prevent synching the bytes > written > by the filter, which ATM opens its own new file handler, by the name of > the temporary file (as KoFilterChain can be only queried for filenames, > KoDocuments or KoStores). > > Real fix might be to use the KTemporaryFile objects also by the filters, > instead of having them open the same file on their own again. > Another fix might be to find out which flags have to be used in Windows on > opening the files, to prevent this behaviour (unless these details are > hidden > away by the Qt abstraction). > > Also fixes a possible crash on Windows in > KoFilterChain::outputFileHelper(...): > m_outputTempFile was accessed even when it might be set to 0 a few lines > before > > > Diffs > ----- > > libs/main/KoFilterChain.cpp b952588 > > Diff: http://git.reviewboard.kde.org/r/107388/diff/ > > > Testing > ------- > > Run a build with this patch and exported a few files from Calligra Words to > HTML, no longer empty output. > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
