Re: Review Request: Animation Tool Docker

2012-09-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106093/#review18421 --- This review has been submitted with commit 67079c295666c4908fe

Re: Review Request: Animation Tool Docker

2012-09-01 Thread Paul Mendez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106093/ --- (Updated Sept. 2, 2012, 2:39 a.m.) Review request for Calligra. Changes

Re: Review Request: Animation Tool Docker

2012-09-01 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106093/#review18359 --- Ship it! Good work. Please fix the things I noted and then ple

Re: Review Request: Animation Tool Docker

2012-08-27 Thread Paul Mendez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106093/ --- (Updated Aug. 28, 2012, 1:59 a.m.) Review request for Calligra. Changes

Re: Review Request: Animation Tool Docker

2012-08-27 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106093/#review18111 --- stage/part/KPrShapeApplicationData.h

Re: Review Request: Animation Tool Docker

2012-08-26 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106093/#review18012 --- stage/part/animations/KPrShapeAnimation.cpp

Re: Review Request: Animation Tool Docker

2012-08-23 Thread Paul Mendez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106093/ --- (Updated Aug. 24, 2012, 12:14 a.m.) Review request for Calligra. Changes

Re: Review Request: Animation Tool Docker

2012-08-23 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106093/#review17904 --- Two more memory leaks. stage/part/tools/animationtool/KPrPred

Re: Review Request: Animation Tool Docker

2012-08-22 Thread Paul Mendez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106093/ --- (Updated Aug. 23, 2012, 2:33 a.m.) Review request for Calligra. Descript

Re: Review Request: Animation Tool Docker

2012-08-22 Thread Paul Mendez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106093/ --- (Updated Aug. 23, 2012, 2:32 a.m.) Review request for Calligra. Changes

Re: Review Request: Animation Tool Docker

2012-08-22 Thread Paul Mendez
> On Aug. 20, 2012, 5:55 p.m., Thorsten Zachmann wrote: > > stage/part/KPrShapeApplicationData.cpp, line 31 > > > > > > This seems to be a memory leak. > > Paul Mendez wrote: > Animations are deleted in KPrAnima

Re: Review Request: Animation Tool Docker

2012-08-22 Thread Thorsten Zachmann
> On Aug. 20, 2012, 5:55 p.m., Thorsten Zachmann wrote: > > stage/part/KPrShapeApplicationData.cpp, line 31 > > > > > > This seems to be a memory leak. > > Paul Mendez wrote: > Animations are deleted in KPrAnima

Re: Review Request: Animation Tool Docker

2012-08-21 Thread Paul Mendez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106093/ --- (Updated Aug. 21, 2012, 3:17 p.m.) Review request for Calligra. Changes

Re: Review Request: Animation Tool Docker

2012-08-21 Thread Paul Mendez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106093/ --- (Updated Aug. 21, 2012, 2:38 p.m.) Review request for Calligra. Changes

Re: Review Request: Animation Tool Docker

2012-08-21 Thread Paul Mendez
> On Aug. 20, 2012, 5:55 p.m., Thorsten Zachmann wrote: > > stage/part/KPrShapeApplicationData.cpp, line 31 > > > > > > This seems to be a memory leak. > > Paul Mendez wrote: > Animations are deleted in KPrAnima

Re: Review Request: Animation Tool Docker

2012-08-20 Thread Thorsten Zachmann
> On Aug. 20, 2012, 5:55 p.m., Thorsten Zachmann wrote: > > stage/part/KPrShapeApplicationData.cpp, line 31 > > > > > > This seems to be a memory leak. > > Paul Mendez wrote: > Animations are deleted in KPrAnima

Re: Review Request: Animation Tool Docker

2012-08-20 Thread Paul Mendez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106093/ --- (Updated Aug. 21, 2012, 2:26 a.m.) Review request for Calligra. Changes

Re: Review Request: Animation Tool Docker

2012-08-20 Thread Paul Mendez
> On Aug. 20, 2012, 5:55 p.m., Thorsten Zachmann wrote: > > stage/part/KPrShapeAnimations.cpp, lines 220-227 > > > > > > Can it happen that KPrShapeAnimation::none is true and there is no > > shape? Otherwise this

Re: Review Request: Animation Tool Docker

2012-08-20 Thread Paul Mendez
> On Aug. 20, 2012, 5:55 p.m., Thorsten Zachmann wrote: > > stage/part/KPrShapeApplicationData.cpp, line 31 > > > > > > This seems to be a memory leak. Animations are deleted in KPrAnimationCreateCommand and KPrAni

Re: Review Request: Animation Tool Docker

2012-08-19 Thread Paul Mendez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106093/ --- (Updated Aug. 19, 2012, 10:23 p.m.) Review request for Calligra. Changes