----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106093/#review18359 -----------------------------------------------------------
Ship it! Good work. Please fix the things I noted and then please commit to master. Looking forward to see it go in. stage/part/KPrShapeAnimations.h <http://git.reviewboard.kde.org/r/106093/#comment14500> These methods should be const stage/part/animations/KPrAnimateMotion.cpp <http://git.reviewboard.kde.org/r/106093/#comment14506> please remove stage/part/animations/KPrAnimateMotion.cpp <http://git.reviewboard.kde.org/r/106093/#comment14507> please remove stage/part/animations/KPrAnimateMotion.cpp <http://git.reviewboard.kde.org/r/106093/#comment14508> please remove stage/part/animations/KPrShapeAnimation.h <http://git.reviewboard.kde.org/r/106093/#comment14510> Should be const stage/part/animations/KPrShapeAnimation.h <http://git.reviewboard.kde.org/r/106093/#comment14509> These methods should be const - Thorsten Zachmann On Aug. 28, 2012, 1:59 a.m., Paul Mendez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106093/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2012, 1:59 a.m.) > > > Review request for Calligra. > > > Description > ------- > > GSoC work on Animation Tool Docker: > - List to display current animations, change order, duration and type of > animation > - Time line view for advanced edition of start time and duration > - Live preview of animations > - Widget to add new animations > - Automatic preview of animations (Can be disabled and Stage remembers your > preference) > - Alternative animation preview using hover buttons. > - Automatic drawing of motion path icons using shape stored on xml > description > - Automatic loading of predefined animations from a xml file (I have added > some predefined animations). > - Basic edition of motion path animations (Some predefined motion path > animations have been added on the xml file). > - Refactor of KPrAnimateMotion class (class that loads and saves motion paths) > - Data model to store and edit animations of a document. > - Unit test for the animations data model. > > > Diffs > ----- > > libs/flake/tools/KoPathTool.h a4bcb5047cce5f817fb68d3ab35da38cca93cc54 > libs/flake/tools/KoPathTool.cpp 29c1e273322eeb7989fadce90776cdd6de331740 > libs/widgets/KoViewItemContextBar.h > c8a7017ccabdcb09fd3a7edfdb6697a932e0974e > libs/widgets/KoViewItemContextBar.cpp > 163155eeee605f690ed5c754bb04f78d53edb696 > stage/part/CMakeLists.txt 77497a71bf60a703f996442e5a8795a62986f582 > stage/part/KPrDocument.h a9c7c3b2414172218b268fb95c96d39dd1f1ec9e > stage/part/KPrDocument.cpp eeb27b9ba7de9cc2367a161cabc8b2e550d132c2 > stage/part/KPrEndOfSlideShowPage.cpp > 78907aa1a379f336f3c68ea0690d0c8741219bfd > stage/part/KPrMasterPage.h 29190e33d910f1c2dd339d39c585cbfba6fb9b5c > stage/part/KPrMasterPage.cpp d75b6af8a17dcf2e594c6f3597ab805a63fe77cf > stage/part/KPrPage.cpp ad4af851ae2a1eb8d7681a80f4336c9e43856a0b > stage/part/KPrPageData.h 88ee96680c165da54f8d7c270a1dc4961ffdd5a7 > stage/part/KPrPageData.cpp 970fb6e7e791bbffc4e49561e276ce5e86185b32 > stage/part/KPrShapeAnimations.h 7558efa420be30ebf975945fcbdec3a1c72d1311 > stage/part/KPrShapeAnimations.cpp b479ed79560e51e69d06adfe3b02ed50f600928e > stage/part/KPrShapeApplicationData.h > ae8d685a61625625d8d2ff61b2986c05b918e855 > stage/part/KPrShapeApplicationData.cpp > 691446d01381d4eff701d84ce4bf9dc12149cdce > stage/part/KPrViewModePreviewShapeAnimations.h PRE-CREATION > stage/part/KPrViewModePreviewShapeAnimations.cpp PRE-CREATION > stage/part/animations/KPrAnimateMotion.h > 29cdd3f0453e0e0d7e50025699f354357967d2c5 > stage/part/animations/KPrAnimateMotion.cpp > 575cef1daa769e770b9f678f4cf9c7b424153f8a > stage/part/animations/KPrAnimationBase.h > 066974efdf11d0f13f37d0b4854d49bfb2079e5d > stage/part/animations/KPrAnimationBase.cpp > 57861e1c4af4fb9218b45f88a6c9dda0f5f0af80 > stage/part/animations/KPrAnimationFactory.h > b0e7a8db480e713a75427460c3bc1521d06f37a3 > stage/part/animations/KPrAnimationLoader.cpp > 24cc17b01ac2c7a45edbb78c6adfaa31fac47abd > stage/part/animations/KPrAnimationStep.h > 26a9fcec4b1d894ffe4d7d1dd2458a34c35e3d64 > stage/part/animations/KPrAnimationSubStep.h > 83cab65ab078675c380ccbf4b60dab99e83619f1 > stage/part/animations/KPrShapeAnimation.h > f5d9ac3b796e75f16970f80245e1fbb6673fe1b9 > stage/part/animations/KPrShapeAnimation.cpp > 988cd14098d8ac1f9290b858540215d75d97f9f3 > stage/part/animations/animations.xml PRE-CREATION > stage/part/commands/KPrAnimationCreateCommand.h > 831317e9a386e7da4100d27dfbf5aab5b382b28d > stage/part/commands/KPrAnimationCreateCommand.cpp > 3c06155bbb6afd6668bef6998bd1fd4c20534b8b > stage/part/commands/KPrAnimationEditNodeTypeCommand.h PRE-CREATION > stage/part/commands/KPrAnimationEditNodeTypeCommand.cpp PRE-CREATION > stage/part/commands/KPrAnimationRemoveCommand.h PRE-CREATION > stage/part/commands/KPrAnimationRemoveCommand.cpp PRE-CREATION > stage/part/commands/KPrEditAnimationTimeLineCommand.h PRE-CREATION > stage/part/commands/KPrEditAnimationTimeLineCommand.cpp PRE-CREATION > stage/part/commands/KPrReorderAnimationCommand.h PRE-CREATION > stage/part/commands/KPrReorderAnimationCommand.cpp PRE-CREATION > stage/part/commands/KPrReplaceAnimationCommand.h PRE-CREATION > stage/part/commands/KPrReplaceAnimationCommand.cpp PRE-CREATION > stage/part/tests/CMakeLists.txt bac9354b91bafcd38303267ad5759749b38b9c2c > stage/part/tests/MockShapeAnimation.h PRE-CREATION > stage/part/tests/ModelTest.h PRE-CREATION > stage/part/tests/ModelTest.cpp PRE-CREATION > stage/part/tests/PAMock.h d05c38920e074092d4ab47f8f5dc66b7dda51a5b > stage/part/tests/TestShapeAnimations.h > 045bc2e9f20d9fce69cc1deb2f8fd462e47f64ea > stage/part/tests/TestShapeAnimations.cpp > b077a550417f3b4f3dd17105b29d455992d67c56 > stage/part/tools/animationtool/CMakeLists.txt > 5f5cb93f681ab95b0294de540e681d44ea9d27cb > stage/part/tools/animationtool/KPrAnimationGroupProxyModel.h PRE-CREATION > stage/part/tools/animationtool/KPrAnimationGroupProxyModel.cpp PRE-CREATION > stage/part/tools/animationtool/KPrAnimationSelectorWidget.h PRE-CREATION > stage/part/tools/animationtool/KPrAnimationSelectorWidget.cpp PRE-CREATION > stage/part/tools/animationtool/KPrAnimationTool.h > dbf12b9226f4da7b975d49ee19e5c7568cef7367 > stage/part/tools/animationtool/KPrAnimationTool.cpp > 99f3d5428f9a761d5376af6a5c1cf9a512266347 > stage/part/tools/animationtool/KPrAnimationsTimeLineView.h PRE-CREATION > stage/part/tools/animationtool/KPrAnimationsTimeLineView.cpp PRE-CREATION > stage/part/tools/animationtool/KPrCollectionItemModel.h PRE-CREATION > stage/part/tools/animationtool/KPrCollectionItemModel.cpp PRE-CREATION > stage/part/tools/animationtool/KPrEditAnimationsWidget.h PRE-CREATION > stage/part/tools/animationtool/KPrEditAnimationsWidget.cpp PRE-CREATION > stage/part/tools/animationtool/KPrPredefinedAnimationsLoader.h PRE-CREATION > stage/part/tools/animationtool/KPrPredefinedAnimationsLoader.cpp > PRE-CREATION > stage/part/tools/animationtool/KPrShapeAnimationDocker.h PRE-CREATION > stage/part/tools/animationtool/KPrShapeAnimationDocker.cpp PRE-CREATION > stage/part/tools/animationtool/KPrTimeLineHeader.h PRE-CREATION > stage/part/tools/animationtool/KPrTimeLineHeader.cpp PRE-CREATION > stage/part/tools/animationtool/KPrTimeLineView.h PRE-CREATION > stage/part/tools/animationtool/KPrTimeLineView.cpp PRE-CREATION > stage/pics/CMakeLists.txt dda7ac06d627e7e84f754d000fd54fc9952a3780 > stage/pics/animations/CMakeLists.txt PRE-CREATION > stage/pics/animations/hi32-action-after_previous.png PRE-CREATION > stage/pics/animations/hi32-action-edit_animation.png PRE-CREATION > stage/pics/animations/hi32-action-onclick.png PRE-CREATION > stage/pics/animations/hi32-action-unrecognized_animation.png PRE-CREATION > stage/pics/animations/hi32-action-with_previous.png PRE-CREATION > stage/pics/animations/hi64-action-appear_animation.png PRE-CREATION > stage/pics/animations/hi64-action-bounce_animation.png PRE-CREATION > stage/pics/animations/hi64-action-collapse_animation.png PRE-CREATION > stage/pics/animations/hi64-action-crawl_out_animation.png PRE-CREATION > stage/pics/animations/hi64-action-custom_animations.png PRE-CREATION > stage/pics/animations/hi64-action-disappear_animation.png PRE-CREATION > stage/pics/animations/hi64-action-emphasis_animations.png PRE-CREATION > stage/pics/animations/hi64-action-entrance_animations.png PRE-CREATION > stage/pics/animations/hi64-action-exit_animations.png PRE-CREATION > stage/pics/animations/hi64-action-falling_in_animation.png PRE-CREATION > stage/pics/animations/hi64-action-flash_once_animation.png PRE-CREATION > stage/pics/animations/hi64-action-fly_in_animation.png PRE-CREATION > stage/pics/animations/hi64-action-fly_in_slow_animation.png PRE-CREATION > stage/pics/animations/hi64-action-fly_out_animation.png PRE-CREATION > stage/pics/animations/hi64-action-horizontal_animations.png PRE-CREATION > stage/pics/animations/hi64-action-in_animations.png PRE-CREATION > stage/pics/animations/hi64-action-motion_path_animations.png PRE-CREATION > stage/pics/animations/hi64-action-movie_credits_animation.png PRE-CREATION > stage/pics/animations/hi64-action-out_animations.png PRE-CREATION > stage/pics/animations/hi64-action-spiral_in_animation.png PRE-CREATION > stage/pics/animations/hi64-action-spiral_out_animation.png PRE-CREATION > stage/pics/animations/hi64-action-stretchy_animation.png PRE-CREATION > stage/pics/animations/hi64-action-swish_animation.png PRE-CREATION > stage/pics/animations/hi64-action-swivel_animation.png PRE-CREATION > stage/pics/animations/hi64-action-thread_animation.png PRE-CREATION > stage/pics/animations/hi64-action-vertical_animations.png PRE-CREATION > stage/pics/animations/hi64-action-zoom_animation.png PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/106093/diff/ > > > Testing > ------- > > > Thanks, > > Paul Mendez > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
