Re: Review Request: Add support for 3D scenes to libs/odf

2012-05-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104688/#review14151 --- This review has been submitted with commit 9f91392108c3125f610

Re: Review Request: Add support for 3D scenes to libs/odf

2012-04-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104688/#review12886 --- This review has been submitted with commit f31eed5aa9fdfd6794d

Re: Review Request: Add support for 3D scenes to libs/odf

2012-04-24 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104688/#review12868 --- Ship it! I see no further issues Don't forget to squash the c

Re: Review Request: Add support for 3D scenes to libs/odf

2012-04-24 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104688/ --- (Updated April 24, 2012, 2:57 p.m.) Review request for Calligra. Changes

Re: Review Request: Add support for 3D scenes to libs/odf

2012-04-24 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104688/ --- (Updated April 24, 2012, 1:40 p.m.) Review request for Calligra. Changes

Re: Review Request: Add support for 3D scenes to libs/odf

2012-04-24 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104688/#review12862 --- libs/odf/Ko3dScene.h

Re: Review Request: Add support for 3D scenes to libs/odf

2012-04-24 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104688/#review12860 --- I know we are being a bit pedantic about the coding style, but

Re: Review Request: Add support for 3D scenes to libs/odf

2012-04-23 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104688/ --- (Updated April 23, 2012, 6:40 p.m.) Review request for Calligra. Changes

Re: Review Request: Add support for 3D scenes to libs/odf

2012-04-22 Thread Inge Wallin
> On April 22, 2012, 5:08 a.m., Thorsten Zachmann wrote: > > libs/odf/Ko3dScene.cpp, line 150 > > > > > > The save method of the Ko3dScene should also save the tag drd3:screen > > tag. > > Inge Wallin wrote: >

Re: Review Request: Add support for 3D scenes to libs/odf

2012-04-22 Thread Thorsten Zachmann
> On April 22, 2012, 5:08 a.m., Thorsten Zachmann wrote: > > libs/odf/Ko3dScene.cpp, line 150 > > > > > > The save method of the Ko3dScene should also save the tag drd3:screen > > tag. > > Inge Wallin wrote: >

Re: Review Request: Add support for 3D scenes to libs/odf

2012-04-22 Thread Inge Wallin
> On April 22, 2012, 5:08 a.m., Thorsten Zachmann wrote: > > libs/odf/Ko3dScene.h, lines 79-80 > > > > > > You should pass the KoShapeLoadingContext and the KoShapeSavingContext > > to this methods so in case it is

Re: Review Request: Add support for 3D scenes to libs/odf

2012-04-21 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104688/#review12773 --- I think the patch should also include the parts to use the clas

Re: Review Request: Add support for 3D scenes to libs/odf

2012-04-21 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104688/#review12772 --- libs/odf/Ko3dScene.h

Re: Review Request: Add support for 3D scenes to libs/odf

2012-04-21 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104688/#review12771 --- Yes we would require d pointer for libs stuff also please conf

Re: Review Request: Add support for 3D scenes to libs/odf

2012-04-21 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104688/#review12758 --- libs/odf/Ko3dScene.h