-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104688/#review12771
-----------------------------------------------------------
Yes we would require d pointer for libs stuff
also please conform to hacking style. I see many spaces in var declarations. I
see several place wher you forgot { } for single line if
and also one case of trailing space
on the more general sense it looks ok - though i've not looked at the details -
but then again if you are able to use it it can't be all bad.
libs/odf/Ko3dScene.h
<http://git.reviewboard.kde.org/r/104688/#comment9981>
qt 4.6 - do we require that yet?
- C. Boemann
On April 21, 2012, 12:39 p.m., Inge Wallin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104688/
> -----------------------------------------------------------
>
> (Updated April 21, 2012, 12:39 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> This new code adds support for 3D scenes in libs/odf. It was ported from my
> threedscene branch when I found out that exactly the same attributes are used
> in 3D charts.
>
> The only tricky thing with this code is that the attributes are not stored in
> a style but in the actual elements (dr3d:scene and chart:plot-area
> respectively). This means that we have to save the attributes and the
> children separately since the saving code of these objects may want to add
> other attributes *and* children.
>
> You may note that I didn't d-pointer-ify the class. Right now the odf
> library is not binary compatibility frozen so I don't strictly need to but if
> there is a strong wish for it I can do it.
>
>
> Diffs
> -----
>
> libs/odf/CMakeLists.txt c411a8c
> libs/odf/Ko3dScene.h PRE-CREATION
> libs/odf/Ko3dScene.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/104688/diff/
>
>
> Testing
> -------
>
> I have tested this code while working on the 3D Scene shape.
>
>
> Thanks,
>
> Inge Wallin
>
>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
