D26221: Use QQC2 Dialog

ognarb edited the test plan for this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26221 To: ognarb, #calligra:_3.0, leinir Cc: danders, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D26221: Use QQC2 Dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R8:d6cdb21118b2: Use QQC2 Dialog (authored by ognarb). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26221?vs=72240&id=77299 REVISION DETAIL https://phabricator.kde.or

D26221: Use QQC2 Dialog

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. In D26221#583471 , @ognarb wrote: > - Center the loading animation Probably want to update the screenshot (for posterity), but... other

D26221: Use QQC2 Dialog

danders added a comment. ping? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26221 To: ognarb, #calligra:_3.0, leinir Cc: danders, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D26221: Use QQC2 Dialog

ognarb marked an inline comment as done. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26221 To: ognarb, #calligra:_3.0, leinir Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D26221: Use QQC2 Dialog

ognarb updated this revision to Diff 72240. ognarb added a comment. - Center the loading animation REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26221?vs=72174&id=72240 BRANCH gemini-dialog REVISION DETAIL https://phabricator.kde.org/D26221 AFFECTED

D26221: Use QQC2 Dialog

leinir added a comment. That's looking pretty good, really :) Also code reduction is certainly good ;) INLINE COMMENTS > Dialog.qml:136 > > -anchors { > -left: parent.left; > -leftMargin: 8; > -right: parent.right; > -

D26221: Use QQC2 Dialog

ognarb edited the test plan for this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26221 To: ognarb, #calligra:_3.0, leinir Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D26221: Use QQC2 Dialog

ognarb updated this revision to Diff 72174. ognarb added a comment. Update look REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26221?vs=72173&id=72174 BRANCH gemini-dialog REVISION DETAIL https://phabricator.kde.org/D26221 AFFECTED FILES gemini/qml/

D26221: Use QQC2 Dialog

ognarb added reviewers: Calligra: 3.0, leinir. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26221 To: ognarb, #calligra:_3.0, leinir Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D26221: Use QQC2 Dialog

ognarb created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. ognarb requested review of this revision. REVISION SUMMARY Replace custom dialog with QQC2 Dialog TEST PLAN Screenshot comming REPOSITORY R8 Calligra BRANCH gemini-dialog