leinir added a comment.
That's looking pretty good, really :) Also code reduction is certainly good ;)
INLINE COMMENTS
> Dialog.qml:136
>
> - anchors {
> - left: parent.left;
> - leftMargin: 8;
> - right: parent.right;
> - bottom: parent.bottom;
> - bottomMargin: 8;
> + QQC2.BusyIndicator {
> + running: base.enabled
Thinking this wants to be centered... or if that means things end up looking
lop-sided, perhaps have it right-aligned? As it stands, it looks kind of...
very heavy on the left hand side.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D26221
To: ognarb, #calligra:_3.0, leinir
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise,
vandenoever
