danders added a comment.
ping?
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D25008
To: davidllewellynjones, #calligra:_3.0, pvuorela, dcaliste
Cc: danders, anthonyfieroni, Calligra-Devel-list, davidllewellynjones,
dcaliste, ognarb, cochise, vandenoever
pvuorela added a comment.
A bit mixed feelings for this. In a way nice to avoid unnecessary work, but
then again it seems effectively a compilation option if xlsx support is for
read-write or view-only. On main level CMake it's also a bit random detail
compared to others.
Could be nice
davidllewellynjones marked 2 inline comments as done.
davidllewellynjones added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in CMakeLists.txt:124-129
> Why 2 times?
Thanks again, I've removed the duplication now.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.or
davidllewellynjones updated this revision to Diff 69054.
davidllewellynjones added a comment.
Remove duplicated cmake definition.
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25008?vs=68954&id=69054
REVISION DETAIL
https://phabricator.kde.org/D25008
AF
davidllewellynjones added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in CMakeLists.txt:124-129
> Why 2 times?
That's a very good question; nicely noticed. I'll update the patch to remove
one.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D25008
To: david
anthonyfieroni added inline comments.
INLINE COMMENTS
> CMakeLists.txt:124-129
> +if (MSOOXML_MAX_SPREADSHEET_COLS)
> +add_definitions(
> -DMSOOXML_MAX_SPREADSHEET_COLS=${MSOOXML_MAX_SPREADSHEET_COLS} )
> +endif()
> +if (MSOOXML_MAX_SPREADSHEET_COLS)
> +add_definitions(
> -DMSOOXML_MAX_
davidllewellynjones updated this revision to Diff 68954.
davidllewellynjones added a comment.
Thanks @dcaliste, this is an excellent suggestion and much better naming.
I've updated the diff to make the changes you suggested.
- MSOOXML_IMPORT_READ_ONLY -> MSOOXML_IMPORT_BY_VALUES
- MSOOX
dcaliste added a comment.
@davidllewellynjones, I hadn't time yet to test the patch, but the idea and
implementation is already looking great in my opinion. Maybe, just one remark
after looking at the proposed additions: not saving the formale, but the values
should not be named read-only. I
davidllewellynjones created this revision.
davidllewellynjones added reviewers: Calligra: 3.0, pvuorela, dcaliste.
davidllewellynjones added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
davidllewellynjones requested review of this revision.
REVISION SUMMARY
Loading l
