This revision was automatically updated to reflect the committed changes.
Closed by commit R8:b29f7aa31c5e: Avoid deprecated QAbstractItemModel::reset()
(authored by pvuorela, committed by dcaliste).
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19884?vs=54322
danders accepted this revision.
danders added a comment.
This revision is now accepted and ready to land.
I think this should be ok
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D19884
To: pvuorela, danders
Cc: danders, dcaliste, Calligra-Devel-list, cochise, vandeno
danders added inline comments.
INLINE COMMENTS
> dcaliste wrote in TextDocumentStructureModel.cpp:308
> I did the same changes in https://phabricator.kde.org/D15102 at another place
> and I put the begin and end at the start and end of the routine, like you
> did. But I remember that I got revi
pvuorela added inline comments.
INLINE COMMENTS
> dcaliste wrote in TextDocumentStructureModel.cpp:308
> I did the same changes in https://phabricator.kde.org/D15102 at another place
> and I put the begin and end at the start and end of the routine, like you
> did. But I remember that I got rev
dcaliste added inline comments.
INLINE COMMENTS
> TextDocumentStructureModel.cpp:308
>
> -reset();
> }
I did the same changes in https://phabricator.kde.org/D15102 at another place
and I put the begin and end at the start and end of the routine, like you did.
But I remember that I got r
pvuorela created this revision.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
pvuorela requested review of this revision.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D19884
AFFECTED FILES
plugins/textshape/TextDocumentStructur
