D18466: Fixed calligra crashing when opening remote document

danders added a comment. Thanks, I'm checking it out now... Just a couple of things: Keywords needs to be on a separate line to have effect, see https://community.kde.org/Infrastructure/Git/Hooks Also FIXED-IN is nice to add. I've updated and closed the bug, so no problem. REPOSITO

D18466: Fixed calligra crashing when opening remote document

niccolove added a comment. It seems like it landed. Please tell me if I screwed up anything. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove, danders Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

This revision was automatically updated to reflect the committed changes. Closed by commit R8:18bfd13a8020: Fixed calligra crashing when opening remote document (authored by niccolove). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18466?vs=51617&id=51618 REV

D18466: Fixed calligra crashing when opening remote document

niccolove updated this revision to Diff 51617. niccolove added a comment. BUG:358581 REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18466?vs=50837&id=51617 BRANCH print-remote-files (branched from master) REVISION DETAIL https://phabricator.kde.org/D18

D18466: Fixed calligra crashing when opening remote document

danders added a comment. In D18466#411248 , @boemann wrote: > Dan can you please reply - I'm fine with the account but I can't reply to Ben as I am not able to send email Yes, I have, and just answered again in case something went wrong f

D18466: Fixed calligra crashing when opening remote document

boemann added a comment. Dan can you please reply - I'm fine with the account but I can't reply to Ben as I am not able to send email REPOSITORY R8 Calligra BRANCH print-remote-files (branched from master) REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove, danders Cc:

D18466: Fixed calligra crashing when opening remote document

niccolove added a comment. I do not have a developer account. I requested one some days ago with no answer yet. REPOSITORY R8 Calligra BRANCH print-remote-files (branched from master) REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove, danders Cc: anthonyfieroni, boeman

D18466: Fixed calligra crashing when opening remote document

danders added a comment. Ok, it's accepted so please commit/push/land REPOSITORY R8 Calligra BRANCH print-remote-files (branched from master) REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove, danders Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise,

D18466: Fixed calligra crashing when opening remote document

niccolove updated this revision to Diff 50837. niccolove added a comment. - fixed whitespace, sorry REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18466?vs=50836&id=50837 BRANCH print-remote-files (branched from master) REVISION DETAIL https://phabrica

D18466: Fixed calligra crashing when opening remote document

niccolove updated this revision to Diff 50836. niccolove added a comment. - Made windows show even without export-pdf flag REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18466?vs=50590&id=50836 BRANCH print-remote-files (branched from master) REVISION DE

D18466: Fixed calligra crashing when opening remote document

niccolove updated this revision to Diff 50590. niccolove added a comment. - Made window show on pdf print and removed trailing spaces REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18466?vs=50557&id=50590 BRANCH print-remote-files (branched from master)

D18466: Fixed calligra crashing when opening remote document

danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. Yes, close. When export to pdf, the mainwindow is not shown and since we don't exit, the app will hang. You need to invert the check in KoApplication line 460 so the window is shown.

D18466: Fixed calligra crashing when opening remote document

niccolove updated this revision to Diff 50557. niccolove added a comment. - Removed connection between job and exiting; added todo REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18466?vs=50552&id=50557 BRANCH print-remote-files (branched from master) REV

D18466: Fixed calligra crashing when opening remote document

danders added a comment. Yeah, well there are some half done designs in here :( The benchmark just does not work with remote files. Don't know if it should or if it should be blocked. Let's leave it for now. If you do not specify a pdf filename, it will use the same name as in the l

D18466: Fixed calligra crashing when opening remote document

niccolove marked an inline comment as done. niccolove added a comment. I have some doubts: - Anything related to "and exiting" does not seem to work. mainWindow->slotFileQuit() does not seem working. - --benchmark-loading-show-window should also exit using mainWindow->slotFileQuit(),

D18466: Fixed calligra crashing when opening remote document

niccolove updated this revision to Diff 50552. niccolove added a comment. - Moved QString pdfFileName to KoApplicationPrivate REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18466?vs=50551&id=50552 BRANCH print-remote-files (branched from master) REVISION

D18466: Fixed calligra crashing when opening remote document

danders added a comment. Regarding the completed slot, the doc says: --print Only print and exit --export-pdf Only export to PDF and exit To exit, you need to know when all jobs have finished, so if some failed you need to track that. Also, the

D18466: Fixed calligra crashing when opening remote document

niccolove added a comment. My previous commit used a "still alive argument" as boemann called it that was only introduced in Qt 5.12. Now it should work even with older versions. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove, danders Cc: anthony

D18466: Fixed calligra crashing when opening remote document

anthonyfieroni added a comment. In D18466#402362 , @niccolove wrote: > This solution is Qt <5.12 friendly What you mean? INLINE COMMENTS > KoApplication.h:154 > friend class ResetStarting; > +QString pdfFileName; > }; It shou

D18466: Fixed calligra crashing when opening remote document

niccolove added a comment. This solution is Qt <5.12 friendly REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove, danders Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

niccolove updated this revision to Diff 50551. niccolove added a comment. - Adding pdf filename as propriety of KoApplication REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18466?vs=50542&id=50551 BRANCH print-remote-files (branched from master) REVISION

D18466: Fixed calligra crashing when opening remote document

boemann added a comment. regarding the lambda connection - nice to see that you use the version with a "still alive" argument - but I fear this requires a qt version higher than what we currently support - could you please check REPOSITORY R8 Calligra REVISION DETAIL https://phabricat

D18466: Fixed calligra crashing when opening remote document

niccolove added a comment. What have I Done: - Added slots in KoApplication to manage pdf and print. Cancel is already KoMainWindow::slotLoadCanceled with an error popup, what should a KoApplication::slotLoadCanceled do? - Added connection for pdf print and moved it before document ope

D18466: Fixed calligra crashing when opening remote document

niccolove updated this revision to Diff 50542. niccolove added a comment. - Added slots in KoApplication to handle pdf and print. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18466?vs=50520&id=50542 BRANCH print-remote-files (branched from master) REVI

D18466: Fixed calligra crashing when opening remote document

niccolove updated this revision to Diff 50520. niccolove added a comment. - Removed unnecessary newlines REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18466?vs=50519&id=50520 BRANCH print-remote-files (branched from master) REVISION DETAIL https://pha

D18466: Fixed calligra crashing when opening remote document

niccolove updated this revision to Diff 50519. niccolove added a comment. - Made slotFilePrint depend on signal loadCompleted to avoid it running before remote file being complete REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18466?vs=50100&id=50519 BRANC

D18466: Fixed calligra crashing when opening remote document

danders added a comment. In D18466#400507 , @niccolove wrote: > I'm not sure on how to do that, do you have any tip? > openDocumentInternal is called by openDocument, which is called in KoApplication just before checking the arguments. When i

D18466: Fixed calligra crashing when opening remote document

anthonyfieroni added a comment. So just don't call slotFilePrint connect loadCompleted to slotFilePrint. When openDocumentInternal downloads the document it fires signal of finish, just connect to slot of opened it. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18

D18466: Fixed calligra crashing when opening remote document

niccolove added a comment. I'm not sure on how to do that, do you have any tip? openDocumentInternal is called by openDocument, which is called in KoApplication just before checking the arguments. When it sees the print argument, it calls slotFilePrint. openDocumentInternal downloads the do

D18466: Fixed calligra crashing when opening remote document

anthonyfieroni added a comment. In D18466#399471 , @danders wrote: > Probably we need to start printing in a slot connected to KoMainWindow::loadCompleted() instead. > And to be safe, we also need to handle loadCanceled(). I agree with

D18466: Fixed calligra crashing when opening remote document

danders added a comment. I think the problem is that slotFilePrint() is called (in KoApplication::start()) before the document is actually loaded. Probably we need to start printing in a slot connected to KoMainWindow::loadCompleted() instead. And to be safe, we also need to handle loadCa

D18466: Fixed calligra crashing when opening remote document

niccolove added a comment. I tried differents files (locale and remote, opening and printing), and everything works okay. Other applications work normally, but calligrasheets still crashes when trying to print a remote (odt) file - but I can see the file is downloaded correctly, so it looks

D18466: Fixed calligra crashing when opening remote document

boemann added a comment. Please check with loading a normal document,. The same concerns now applies to slotLoadCompleted - especially since you have now removed functionality from it. Also please check in all of our applications as some might reimplement virtual methods REPOSITORY R

D18466: Fixed calligra crashing when opening remote document

niccolove added a comment. I've seen that openDoumentInternal is called every time a remote document is used as input. I'm not sure if it's also used in different scenarios. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove, danders Cc: boemann, Cal

D18466: Fixed calligra crashing when opening remote document

boemann added a reviewer: danders. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove, danders Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

niccolove updated this revision to Diff 50100. niccolove added a comment. - Moving the if from slotLoadCompleted to openDocumentInternal. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18466?vs=50098&id=50100 BRANCH print-remote-files (branched from maste

D18466: Fixed calligra crashing when opening remote document

boemann added a comment. Yes that description helped a lot, and you are doing great. Keep up the good work :) One concern though - how often and when is openDoumentInternal called. I'm a bit afraid that we just add some functionality to a place that might be used for something else REP

D18466: Fixed calligra crashing when opening remote document

niccolove added a comment. At this point my only worry is that the setRootDocument in openDocumentInternal makes the check for opening a new window in slotLoadCompleted useless. Moving the whole if statement from slotLoadCompleted to openDocumentInternal also works, and could avoid to replac

D18466: Fixed calligra crashing when opening remote document

niccolove added a comment. Sure. Calligra was crashing because the method "slotFilePrint" called "rootView()" that tried to return the first elements of "d->rootViews". The problem is that such list was empitya, as SetRootDocument was never called: that method is called in openDocument but

D18466: Fixed calligra crashing when opening remote document

boemann added a comment. Could you please describe what you have done and why REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

niccolove edited the test plan for this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

niccolove updated this revision to Diff 50098. niccolove added a comment. - Fixed typos REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18466?vs=50097&id=50098 BRANCH print-remote-files (branched from master) REVISION DETAIL https://phabricator.kde.org/

D18466: Fixed calligra crashing when opening remote document

niccolove created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. niccolove requested review of this revision. REVISION SUMMARY BUG:358581 REPOSITORY R8 Calligra BRANCH print-remote-files (branched from master) REVISION DETAIL https: