niccolove added a comment.

  What have I Done:
  
  - Added slots in KoApplication to manage pdf and print. Cancel is already 
KoMainWindow::slotLoadCanceled with an error popup, what should a 
KoApplication::slotLoadCanceled do?
  - Added connection for pdf print and moved it before document opening (local 
files works)
  - I added the KoMainView to the loadCompleted signal, as a new one might be 
created in KoMainWindow::slotLoadCompleted, and the slots needs the new one to 
call slotFilePrint or exportToPdf.
  - Filename is passed to slot using a lambda, like specified on the slots and 
signals qt documentation
  
  Things seem working. Should I do anything else?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18466

To: niccolove, danders
Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

Reply via email to