This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:d4744090e8c6: Annotation: Block adding comment to an
annotation shape (authored by danders).
REPOSITORY
R8 Calligra
C
anthonyfieroni added a comment.
Looks good to me +1
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D16127
To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
danders updated this revision to Diff 43724.
danders added a comment.
- If no textshape is editied, select the first found text shape
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16127?vs=43721&id=43724
BRANCH
danders_annotation_crash
REVISION DETAIL
danders abandoned this revision.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D16127
To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
danders added a comment.
Arghh, accidentally propt a new diff on top of this, howto undo this?
(arc is fine, but do not do anything wrong)
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D16127
To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, c
danders updated this revision to Diff 43721.
danders added a comment.
- DefaultTool: Do not considder parent flags when checking Move-/ResizeAllowd
- DefaultTool: MoveStrategy: Check if shape is movable
- DefaultTool: ResizeStrategy: Check if shape is resizeable
- DefaultTool: ShareStrate
danders marked an inline comment as done.
danders added a comment.
No, it should not be possible to activate a tool without a shape.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D16127
To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise,
anthonyfieroni added inline comments.
INLINE COMMENTS
> TextTool.cpp:2036
> +}
> +m_textShape = textShape;
> +}
If it has more than one shape that not satisfy above condition (2032)
m_textShape will point to last one, not to first as current behavior. So maybe
danders created this revision.
danders added reviewers: boemann, anthonyfieroni.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
danders requested review of this revision.
REVISION SUMMARY
To reproduce crash:
1. Add a text shape
2. Add an annotation
