On Wednesday, 17 June 2020 08:36:14 BST Dag wrote:
> tirsdag den 16. juni 2020 12.30.00 CEST skrev Dag:
> > The annotation shape seems only to be usable as a comment in words.
> > Adding it as a plain shape does not make sence as it will
> > behave as any shape with run-ar
tirsdag den 16. juni 2020 12.30.00 CEST skrev Dag:
The annotation shape seems only to be usable as a comment in words.
Adding it as a plain shape does not make sence as it will
behave as any shape with run-around text etc, but it will never
be printed: Goodby wysiwyg.
I can also add it as a
The annotation shape seems only to be usable as a comment in words.
Adding it as a plain shape does not make sence as it will behave as any
shape with run-around text etc, but it will never be printed: Goodby
wysiwyg.
I can also add it as a comment to a TextShape in stage or sheets, but a
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:d4744090e8c6: Annotation: Block adding comment to an
annotation shape (authored by danders).
REPOSITORY
R
anthonyfieroni added a comment.
Looks good to me +1
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D16127
To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
danders updated this revision to Diff 43724.
danders added a comment.
- If no textshape is editied, select the first found text shape
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16127?vs=43721&id=43724
BRANCH
danders_annotation_crash
REVISION DETAIL
danders abandoned this revision.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D16127
To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
danders added a comment.
Arghh, accidentally propt a new diff on top of this, howto undo this?
(arc is fine, but do not do anything wrong)
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D16127
To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, c
danders updated this revision to Diff 43721.
danders added a comment.
- DefaultTool: Do not considder parent flags when checking Move-/ResizeAllowd
- DefaultTool: MoveStrategy: Check if shape is movable
- DefaultTool: ResizeStrategy: Check if shape is resizeable
- DefaultTool: ShareStrate
danders marked an inline comment as done.
danders added a comment.
No, it should not be possible to activate a tool without a shape.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D16127
To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise,
anthonyfieroni added inline comments.
INLINE COMMENTS
> TextTool.cpp:2036
> +}
> +m_textShape = textShape;
> +}
If it has more than one shape that not satisfy above condition (2032)
m_textShape will point to last one, not to first as current behavior. So maybe
shape
3. Activate the annotation shape
4. Select the Shape Handling tool
5. Select both shapes; first annotation shape then the text shape
6. Select the text tool: The caret should now be in the annotation tool
7. Hit CTRL-SHIFT C to add a comment -> crash
TODO: Find out
12 matches
Mail list logo
