Re: Why I love(d) Krita to be part of Calligra (was: Re: After 2.9.7)

2015-08-30 Thread Sven Langkamp
On Sat, Aug 29, 2015 at 10:41 PM, Friedrich W. H. Kossebau wrote: > Am Donnerstag, 27. August 2015, 09:57:32 schrieb Boudewijn Rempt: > > For Krita, and I hate to say this, it probably makes sense to fork our > > shared libraries. The office-apps maintainers can then strip out all the > > krita-s

Re: Review Request 123338: Fix showing only an empty list of palettes in Karbon's palette bottom bar

2015-04-12 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123338/#review78853 --- Ship it! Ship It! - Sven Langkamp On April 11, 2015, 7:35

Re: Review Request 123165: Compile error fix for libmsooxml

2015-03-28 Thread Sven Langkamp
/ Testing --- Patch fixes shared pointer conversion for libmsooxml Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 123165: Compile error fix for libmsooxml

2015-03-28 Thread Sven Langkamp
Description --- Patch fixes shared pointer conversion for libmsooxml Diffs - filters/libmsooxml/MsooXmlDiagramReader_p.cpp 427e0c1 Diff: https://git.reviewboard.kde.org/r/123165/diff/ Testing --- Patch fixes shared pointer conversion for libmsooxml Thanks, Sven Langkamp

Re: Review Request 119224: Fix Krita speed sensor

2015-03-28 Thread Sven Langkamp
6e3d19a Diff: https://git.reviewboard.kde.org/r/119224/diff/ Testing --- Tested by painting in Krita and appears to work. Needs further testing to see if it gives the expected results. Thanks, Sven Langkamp ___ calligra-devel mailing list

Re: Review Request 122584: Use shared pointers for markers.

2015-02-21 Thread Sven Langkamp
https://git.reviewboard.kde.org/r/122584/diff/ Testing --- Tested with Krita. Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 122584: Use shared pointers for markers.

2015-02-16 Thread Sven Langkamp
unt would always be 1. - Sven --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122584/#review76108 --- On Feb. 16, 2015, 1:26 vorm., Sven Langkamp wrote: > > ---

Review Request 122584: Use shared pointers for markers.

2015-02-15 Thread Sven Langkamp
arker. Diffs - libs/flake/KoMarkerData.cpp 247e151 libs/flake/KoMarker.h fa2adfd libs/flake/KoMarkerCollection.h 1555363 libs/flake/KoMarkerCollection.cpp 98e80f8 Diff: https://git.reviewboard.kde.org/r/122584/diff/ Testing --- Tested with Krita. Thanks, Sven Lan

Re: Review Request 121598: Bug fix - 331483 : JJ Add "Flatten Layer" to the RightClick context menu

2014-12-23 Thread Sven Langkamp
ed as it would automatically flatten the parent layer. There are also many other mask type that are not covered by this. - Sven Langkamp On Dez. 23, 2014, 6:56 nachm., Rishabh Saxena wrote: > > --- > This is an automatically ge

Re: Review Request 121614: Krita - Fix for Bug 341781

2014-12-21 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121614/#review72357 --- Ship it! Ship It! - Sven Langkamp On Dez. 21, 2014, 1:12

Re: Review Request 121559: Krita - OverviewDockerDock and KisZoomManager fixes

2014-12-16 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121559/#review72130 --- Ship it! Ship It! - Sven Langkamp On Dez. 16, 2014, 4:26

Re: Review Request 121277: Avoid slightly to big toolbox after starting the application.

2014-11-27 Thread Sven Langkamp
work with setMaximumWidth, so a bit of a hack was needed. Diffs - libs/main/KoToolBox.cpp aa5525b libs/main/KoToolBoxDocker_p.h 983460b libs/main/KoToolBox_p.h aaf5c9d Diff: https://git.reviewboard.kde.org/r/121277/diff/ Testing --- Tested with Krita. Thanks, Sven Langkamp

Review Request 121277: Avoid slightly to big toolbox after starting the application.

2014-11-27 Thread Sven Langkamp
/KoToolBox.cpp aa5525b libs/main/KoToolBoxDocker_p.h 983460b libs/main/KoToolBox_p.h aaf5c9d Diff: https://git.reviewboard.kde.org/r/121277/diff/ Testing --- Tested with Krita. Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel

Re: Review Request 120706: Krita: better defaults when activating the crop tool

2014-10-22 Thread Sven Langkamp
> On Okt. 22, 2014, 7:21 nachm., Sven Langkamp wrote: > > We had this behavior previously and it got replaced because the users > > wanted to have the click+drag rectangle way to select the crop area. > > Scott Petrovic wrote: > did they give any reasoning on why th

Re: Review Request 120730: Hide lock button of docker if it becomes too small

2014-10-22 Thread Sven Langkamp
too small. Diffs - libs/widgets/KoDockWidgetTitleBar.cpp e5f4bc1 Diff: https://git.reviewboard.kde.org/r/120730/diff/ Testing --- Tested in Krita Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel@kde.org https

Review Request 120730: Hide lock button of docker if it becomes too small

2014-10-22 Thread Sven Langkamp
://git.reviewboard.kde.org/r/120730/diff/ Testing --- Tested in Krita Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120705: Krita: save settings for similar selection

2014-10-22 Thread Sven Langkamp
ed to create more review requests :) - Sven Langkamp On Okt. 22, 2014, 3:40 vorm., Scott Petrovic wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 120706: Krita: better defaults when activating the crop tool

2014-10-22 Thread Sven Langkamp
the users wanted to have the click+drag rectangle way to select the crop area. - Sven Langkamp On Okt. 22, 2014, 4:42 vorm., Scott Petrovic wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 120614: Krita: save settings for multi line line

2014-10-21 Thread Sven Langkamp
<https://git.reviewboard.kde.org/r/120614/#comment48156> m_ - Sven Langkamp On Okt. 17, 2014, 4:10 vorm., Scott Petrovic wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.rev

Re: Review Request 120638: Krita: save settings for fill tool

2014-10-21 Thread Sven Langkamp
<https://git.reviewboard.kde.org/r/120638/#comment48155> m_ here - Sven Langkamp On Okt. 18, 2014, 2:48 vorm., Scott Petrovic wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 120659: Krita: save settings for gradient tool

2014-10-21 Thread Sven Langkamp
tps://git.reviewboard.kde.org/r/120659/#comment48153> This should be m_ like the other members. krita/plugins/tools/defaulttools/kis_tool_gradient.cc <https://git.reviewboard.kde.org/r/120659/#comment48154> Use kDebug with debug area here. - Sven Langkamp On Okt. 19, 2014

Re: Review Request 120696: Remove unimplemented KoCanvasResourceManager::undoStack/setUndoStack methods

2014-10-21 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120696/#review68863 --- Ship it! Ship It! - Sven Langkamp On Okt. 21, 2014, 7:02

Re: Review Request 120612: Krita: save settings for ellipse tool

2014-10-21 Thread Sven Langkamp
tps://git.reviewboard.kde.org/r/120612/#comment48141> It could use toolId() here. That would work for all tools. - Sven Langkamp On Okt. 21, 2014, 3:51 vorm., Scott Petrovic wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 120612: Krita: save settings for ellipse tool

2014-10-19 Thread Sven Langkamp
no fill and no outline, it appears that the tool stopped working and you wonder what happened. Maybe add a notification when that happens in the shape tools. - Sven Langkamp On Okt. 17, 2014, 4:06 vorm., Scott Petrovic wrote

Re: Review Request 120612: Krita: save settings for ellipse tool

2014-10-19 Thread Sven Langkamp
same base class. Maybe this can be solved there instead of duplicating the code for each shape tool. - Sven Langkamp On Okt. 17, 2014, 4:06 vorm., Scott Petrovic wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 120611: Krita: save settings for line tool

2014-10-19 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120611/#review68728 --- Ship it! Ship It! - Sven Langkamp On Okt. 17, 2014, 4:03

Re: Review Request 120615: Krita: save settings for move tool

2014-10-19 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120615/#review68727 --- Ship it! Ship It! - Sven Langkamp On Okt. 17, 2014, 4:11

Re: Review Request 118746: Zoom and sync for resource item choosers

2014-10-15 Thread Sven Langkamp
/KoResourceItemChooserSync.cpp PRE-CREATION libs/widgets/KoResourceItemView.h 86234ba libs/widgets/KoResourceItemView.cpp c56ecc5 Diff: https://git.reviewboard.kde.org/r/118746/diff/ Testing --- Tested with preset and pattern chooser in Krita. Thanks, Sven Langkamp

Re: Review Request 120548: krita: save freehand brush tool settings

2014-10-11 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120548/#review68280 --- Slider values for the smoothing are not saved? - Sven

Re: Review Request 120546: krita: Save settings for crop tool

2014-10-11 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120546/#review68279 --- Ship it! Ship It! - Sven Langkamp On Okt. 10, 2014, 3:06

Re: Review Request 120547: krita: save text tool options

2014-10-11 Thread Sven Langkamp
> On Okt. 10, 2014, 9:28 nachm., Sven Langkamp wrote: > > krita/plugins/tools/tool_text/kis_tool_text.cc, line 156 > > <https://git.reviewboard.kde.org/r/120547/diff/1/?file=317597#file317597line156> > > > > This could be added to the destructor and it wou

Re: Review Request 120547: krita: save text tool options

2014-10-11 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120547/#review68278 --- Ship it! Ship It! - Sven Langkamp On Okt. 10, 2014, 3:09

Re: Review Request 120505: Adding a activation-toggle and preview to assistants.

2014-10-10 Thread Sven Langkamp
rita/ui/kis_painting_assistants_decoration.cpp <https://git.reviewboard.kde.org/r/120505/#comment47554> no empty braces here - Sven Langkamp On Okt. 10, 2014, 9:32 nachm., Wolthera van Hövell wrote: > > --- > This is an automatically ge

Re: Review Request 120547: krita: save text tool options

2014-10-10 Thread Sven Langkamp
tps://git.reviewboard.kde.org/r/120547/#comment47547> This could be added to the destructor and it would not need separate methods. - Sven Langkamp On Okt. 10, 2014, 3:09 vorm., Scott Petrovic wrote: > > --- > This is a

Re: Review Request 120505: Adding a activation-toggle and preview to assistants.

2014-10-10 Thread Sven Langkamp
which already has setVisible and toggleVisible. It's not needed to do the setAssistantVisible, I think. - Sven Langkamp On Okt. 10, 2014, 7:06 nachm., Wolthera van Hövell wrote: > > --- > This is an automatically generated e-

Re: What's Calligra Karbon status?

2014-10-09 Thread Sven Langkamp
On Wed, Oct 8, 2014 at 6:28 PM, ennio tr wrote: > Hello everyone. > > I work with Adobe Illustrator every day. I'm not an artist but I need to > generator some vector path for CNC machines. > However, the only alternative we have is Inkscape but I'm not a fan of it. > Since I use KDE as DE, I'd l

Re: calligra Spreadsheet

2014-09-21 Thread Sven Langkamp
On Sun, Sep 21, 2014 at 4:49 PM, Daniel Roma wrote: > hello. calligra Spreadsheet can be installed separately, or only in the > office suite calligra? thank you > Usually distributions split the packages, so it should be possible to installl it without the other applications. __

Re: Review Request 120191: Allow to have more than one zoom widget

2014-09-15 Thread Sven Langkamp
/KoZoomWidget.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120191/diff/ Testing --- Tested with an additional zoom widget in the Krita overview docker. Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel@kde.org https

Review Request 120191: Allow to have more than one zoom widget

2014-09-13 Thread Sven Langkamp
--- Tested with an additional zoom widget in the Krita overview docker. Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Splitting the calligra repository

2014-08-18 Thread Sven Langkamp
On Mon, Aug 18, 2014 at 9:56 AM, Boudewijn Rempt wrote: > Hi, > > I know we sort of decided to only do this after 2.9, but I just picked up > Jonathan Riddell's discussion on irc on how our current repository and > release makes life harder for packagers -- basically a split up repo would > be ea

Re: Review Request 119609: Animation support in Krita

2014-08-10 Thread Sven Langkamp
609/#comment44815> No need for a pointer here as the qlist is implicitly shared. - Sven Langkamp On Aug. 9, 2014, 10:06 vorm., Somsubhra Bairi wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 119677: Show the Cursor Pos and FG Color in statusbar

2014-08-08 Thread Sven Langkamp
ta/ui/kis_statusbar.cc <https://git.reviewboard.kde.org/r/119677/#comment44736> no prefix here. m_ is only used for member variables. krita/ui/kis_statusbar.cc <https://git.reviewboard.kde.org/r/119677/#comment44738> String might jump with different values. - Sven Langka

Review Request 119224: Fix Krita speed sensor

2014-07-10 Thread Sven Langkamp
painting in Krita and appears to work. Needs further testing to see if it gives the expected results. Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 119033: Replace KServiceTypeTrader with KoServiceLocator

2014-07-08 Thread Sven Langkamp
. No slower start time noticeable. - Sven Langkamp On Juli 8, 2014, 8:22 vorm., Boudewijn Rempt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 119139: Fix moving of shapes in groups in shape layers

2014-07-06 Thread Sven Langkamp
://git.reviewboard.kde.org/r/119139/diff/ Testing --- Tested with the file from bug 308942. Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 119139: Fix moving of shapes in groups in shape layers

2014-07-05 Thread Sven Langkamp
. Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 119122: Show layer name in canvas only mode as floating message

2014-07-04 Thread Sven Langkamp
bit as the four seconds feel really long. - Sven Langkamp On July 4, 2014, 10:05 p.m., Ivan Yossi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Review Request 118746: Zoom and sync for resource item choosers

2014-06-14 Thread Sven Langkamp
/KoResourceItemView.cpp c56ecc5 Diff: https://git.reviewboard.kde.org/r/118746/diff/ Testing --- Tested with preset and pattern chooser in Krita. Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 118541: Add generator plugin for Okular to support ODT, DOC, DOCX

2014-06-05 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118541/#review59326 --- Ship it! Ship It! - Sven Langkamp On June 4, 2014, 8:46

Re: Krita Sprint 2014, Saturday Meeting

2014-05-30 Thread Sven Langkamp
On Tue, May 20, 2014 at 2:39 PM, Boudewijn Rempt wrote: > We had a Krita Sprint in Deventer this weekend, and here's the notes from > the Saturday morning meeting. We discussed a bunch of things, some relevant > for Calligra as a whole, so I'm sending the notes to two mailing lists. > > * Krita F

Re: Review Request 118028: Separate desktop files for PPT and PPTX support by Okular ODP plugin, note runtime deps to packagers

2014-05-12 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118028/#review57824 --- Ship it! Ship It! - Sven Langkamp On May 6, 2014, 11:04

Re: Review Request 117666: Implement Polarize filter for Krita.

2014-04-23 Thread Sven Langkamp
unneeded includes. Nice work. krita/plugins/filters/posterize/posterize.cpp <https://git.reviewboard.kde.org/r/117666/#comment39178> Should use torgba16 here. - Sven Langkamp On April 20, 2014, 7:59 p.m., Manuel Riecke

Re: Review Request 109581: Smaller icons in the layer box

2014-03-15 Thread Sven Langkamp
/media/uploaded/files/2013/03/19/smallicons.png Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 109907: Use platform native file dialogs

2013-09-24 Thread Sven Langkamp
that we miss from KFileDialog? KIO maybe? - Sven Langkamp On Sept. 23, 2013, 3:01 a.m., Yue Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Review Request 112883: Workaround for flickering in OpenGL 2 canvas on AMD graphic cards

2013-09-22 Thread Sven Langkamp
gl_canvas2.h 5d701d6 krita/ui/opengl/kis_opengl_canvas2.cpp 2ddd503 Diff: http://git.reviewboard.kde.org/r/112883/diff/ Testing --- Tested on my ATI card. Flickering is gone. Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-dev

Re: Review Request 112827: Move the View Mode button from KisPaintOpPresetsChooserPopup to KoResourceItemChooser

2013-09-19 Thread Sven Langkamp
n are separate, but the patch looks ok. - Sven Langkamp On Sept. 19, 2013, 3:44 p.m., Arjen Hiemstra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 112080: Refactor tag widgets and tag logic out of KoResourceItemchooser into their own classes and widgets

2013-08-15 Thread Sven Langkamp
copyright stuff to the header if you move other peoples code to a new file. - Sven Langkamp On Aug. 15, 2013, 5:48 a.m., Sascha Suelzer wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 112080: Refactor tag widgets and tag logic out of KoResourceItemchooser into their own classes and widgets

2013-08-14 Thread Sven Langkamp
ter->setSizePolicy(QSizePolicy::MinimumExpanding, QSizePolicy::MinimumExpanding); - Sven Langkamp On Aug. 14, 2013, 3:53 p.m., Sascha Suelzer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.rev

Re: Calligra 3.0 for Qt 5.1?

2013-07-29 Thread Sven Langkamp
On Mon, Jul 29, 2013 at 12:11 PM, Boudewijn Rempt wrote: > I want to propose that we start porting Calligra to Qt 5.1 now that 2.7 is > released. Jolla is funding KO GmbH to work on porting the core, so this is > a good moment to get started. On the other hand, we're in the middle of > gsoc and u

Re: Review Request 111363: Make loading of colors in colorsets more tolerant to bogus values

2013-07-02 Thread Sven Langkamp
://bugs.kde.org/show_bug.cgi?id=318345 Diffs - libs/pigment/resources/KoColorSet.h eb28db0 libs/pigment/resources/KoColorSet.cpp 2367631 Diff: http://git.reviewboard.kde.org/r/111363/diff/ Testing --- Tested in Krita. Thanks, Sven Langkamp

Review Request 111363: Make loading of colors in colorsets more tolerant to bogus values

2013-07-02 Thread Sven Langkamp
eb28db0 libs/pigment/resources/KoColorSet.cpp 2367631 Diff: http://git.reviewboard.kde.org/r/111363/diff/ Testing --- Tested in Krita. Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 110596: Slightly improve KoResourceItemChooser UI strings (and add some context markers)

2013-05-22 Thread Sven Langkamp
ttp://git.reviewboard.kde.org/r/110596/#comment24423> Putting the ! inside the [] is wrong. - Sven Langkamp On May 22, 2013, 3:23 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Porting to Qt5

2013-04-08 Thread Sven Langkamp
On Mon, Apr 8, 2013 at 10:22 PM, Kevin Krammer wrote: > On Monday, 2013-04-08, Boudewijn Rempt wrote: > > > * replace kconfig with qsettings > > Doesn't that lose all support for OSV and admin default values, immutable > settings, build time generated config access instead of typo-prone string >

Re: Review Request 109581: Smaller icons in the layer box

2013-03-19 Thread Sven Langkamp
krita/plugins/extensions/dockers/defaultdockers/wdglayerbox.ui ecfd983 Diff: http://git.reviewboard.kde.org/r/109581/diff/ Testing --- File Attachments (updated) Screenshot http://git.reviewboard.kde.org/media/uploaded/files/2013/03/19/smallicons.png Thanks, Sven

Review Request 109581: Smaller icons in the layer box

2013-03-19 Thread Sven Langkamp
/defaultdockers/wdglayerbox.ui ecfd983 Diff: http://git.reviewboard.kde.org/r/109581/diff/ Testing --- Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 109349: Added the enable angle snap switch for path tool.

2013-03-09 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109349/#review28834 --- Ship it! Ship It! - Sven Langkamp On March 8, 2013, 10:49

Re: Check for Qt classes that should not be used

2013-02-22 Thread Sven Langkamp
On Wed, Feb 20, 2013 at 12:07 PM, Jean-Nicolas Artaud wrote: > > > > 2013/2/20 Sven Langkamp >> >> On Wed, Feb 20, 2013 at 9:35 AM, Inge Wallin wrote: >> > As you may have noticed, I have taken some interest in EBN, the KDE >> > static >> > cod

Re: Check for Qt classes that should not be used

2013-02-20 Thread Sven Langkamp
On Wed, Feb 20, 2013 at 9:35 AM, Inge Wallin wrote: > As you may have noticed, I have taken some interest in EBN, the KDE static > code checker[1]. One of the categories there is "Check for Qt classes that > should not be used" where it recommends to use e.g. KTabBar instead of QTabBar > and so on

Re: Review Request 108767: Added icon only mode for the modebox

2013-02-03 Thread Sven Langkamp
/ Testing --- File Attachments (updated) http://git.reviewboard.kde.org/media/uploaded/files/2013/02/03/wordsicononly.png Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman

Review Request 108767: Added icon only mode for the modebox

2013-02-03 Thread Sven Langkamp
to show only the icons in the modebox. This is an alternative to the bigger Text+Icon mode. Diffs - libs/main/KoModeBox.cpp 62575f1 libs/main/KoModeBox_p.h 3123530 Diff: http://git.reviewboard.kde.org/r/108767/diff/ Testing --- Thanks, Sven Langkamp

Re: Review Request 108587: Don't interpret selection by tablet as move

2013-02-03 Thread Sven Langkamp
this be commited? - Sven Langkamp On Jan. 25, 2013, 11:42 p.m., Sven Langkamp wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 108725: Fix for unsetting the canvas, new approach

2013-02-03 Thread Sven Langkamp
had already initialized the dockers, so it was buggy even before my change. - Sven --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108725/#review26568 ---

Re: Review Request 108725: Fix for unsetting the canvas, new approach

2013-02-02 Thread Sven Langkamp
he bug in Krita. Didn't see side effects on other applications. Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 108726: Fix width of Words statistics docker after opening a document

2013-02-02 Thread Sven Langkamp
. Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 108725: Fix for unsetting the canvas, new approach

2013-02-02 Thread Sven Langkamp
#x27;t see side effects on other applications. Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 108684: Move palettes to a Calligra-wide data folder

2013-01-31 Thread Sven Langkamp
9c6cfb0 libs/widgets/KoResourceServerProvider.cpp 2b95eaa Diff: http://git.reviewboard.kde.org/r/108684/diff/ Testing --- Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra

Review Request 108683: Delete old view before creating a new view

2013-01-31 Thread Sven Langkamp
the new one. This addresses bug 314029. http://bugs.kde.org/show_bug.cgi?id=314029 Diffs - libs/main/KoMainWindow.cpp 19f91f1 Diff: http://git.reviewboard.kde.org/r/108683/diff/ Testing --- Tested with Krita. Thanks, Sven Langkamp

Review Request 108651: Nicer appearance of image after cropping.

2013-01-28 Thread Sven Langkamp
://git.reviewboard.kde.org/r/108651/diff/ Testing --- Tested with normal and transformed images. Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 108587: Don't interpret selection by tablet as move

2013-01-26 Thread Sven Langkamp
- Sven --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108587/#review26192 --- On Jan. 25, 2013, 11:42 p.m., Sven Langk

Review Request 108587: Don't interpret selection by tablet as move

2013-01-25 Thread Sven Langkamp
flake/KoPointerEvent.cpp a6dd554 plugins/defaultTools/defaulttool/DefaultTool.cpp db7c489 Diff: http://git.reviewboard.kde.org/r/108587/diff/ Testing --- Needs someone with a tablet to check. Thanks, Sven Langkamp ___ calligra-devel mailing

Review Request 108562: Let calligraphy tool use foreground color and cross cursor

2013-01-22 Thread Sven Langkamp
gs.kde.org/show_bug.cgi?id=313634 http://bugs.kde.org/show_bug.cgi?id=313636 Diffs - karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyTool.cpp 6b93e3b Diff: http://git.reviewboard.kde.org/r/108562/diff/ Testing --- Thanks, Sve

Re: Review Request 108532: Fix crash in krita master on style combo

2013-01-21 Thread Sven Langkamp
save and load, but that is probably not related to this problem. - Sven Langkamp On Jan. 21, 2013, 7:41 p.m., Pierre Stirnweiss wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboa

Re: Review Request 108424: updated modebox for words,sheets,author

2013-01-16 Thread Sven Langkamp
don't need to switch between tool that often. Currently you have move over the tabs each time you want to change a setting. - Sven Langkamp On Jan. 15, 2013, 12:34 p.m., C. Boemann wrote: > > --- > This is an automatically g

Re: Bug in shape opacity save

2013-01-12 Thread Sven Langkamp
On Sat, Jan 12, 2013 at 5:30 PM, Jean-Nicolas Artaud wrote: > Hello, > > I've found a bug in calligra using stage. I'm on the master. > > Way to reproduce: > > o Add a shape on the slide. (hexagon tested) > o Change its opacity. (StrokeFillDocker tested) > o Save the document. > o Quit and relaunc

Review Request: Turn off table and other text features in Krita

2013-01-09 Thread Sven Langkamp
/flake/KoCanvasResourceManager.h 1976bc7 libs/flake/KoCanvasResourceManager.cpp 4c240a2 plugins/textshape/TextTool.cpp e0b6f99 Diff: http://git.reviewboard.kde.org/r/108298/diff/ Testing --- Tested with Krita. Thanks, Sven Langkamp

Re: Review Request: Implement line smoothing using sigetch's algorithm

2012-12-31 Thread Sven Langkamp
image/kis_distance_information.h <http://git.reviewboard.kde.org/r/108049/#comment18678> The should not be two instructions in the same line. Beside that it looks ok. - Sven Langkamp On Dec. 31, 2012, 3:10 p.m., Boudewijn

Review Request: Better integration of pencil tool into Krita

2012-12-28 Thread Sven Langkamp
/KoCurveFit.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/107996/diff/ Testing --- Tested, works. Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: a new library

2012-12-20 Thread Sven Langkamp
On Wed, Dec 19, 2012 at 1:55 AM, C. Boemann wrote: > Hi > > In an attempt to to rework the ui, we have run into a problem: > > KoCreatePathTool in libs/flake needs some widgets from libs/widgets > > however the dependency is in the opposite direction > > So unless we want to move the tools into li

Re: Workspace proposal

2012-11-20 Thread Sven Langkamp
On Tue, Nov 20, 2012 at 10:27 PM, C. Boemann wrote: > On Tuesday 20 November 2012 22:05:48 Sven Langkamp wrote: >> Hi, >> >> >> I have been discussing this on IRC with boemann and ingwa and to clear >> things up I did write it down. >> >> This a pro

Workspace proposal

2012-11-20 Thread Sven Langkamp
Hi, I have been discussing this on IRC with boemann and ingwa and to clear things up I did write it down. This a proposal for a new UI for our tool docker/box UI. Proposal can be found here: http://depot.tu-dortmund.de/get/r6n9u This is just a thing that I would like to see in Words/Stage. Migh

Review Request: CWOP: Icons in dockers are too small because of chrome around

2012-11-03 Thread Sven Langkamp
/textshape/dialogs/SimpleParagraphWidget.ui 6641ac6 plugins/textshape/dialogs/SimpleTableWidget.ui a541678 Diff: http://git.reviewboard.kde.org/r/107190/diff/ Testing --- Screenshots --- Screenshot http://git.reviewboard.kde.org/r/107190/s/810/ Thanks, Sven Langkamp

Re: Architecture Refactor Suggestion: Bigger reorganization

2012-10-22 Thread Sven Langkamp
On Mon, Oct 22, 2012 at 8:08 PM, Inge Wallin wrote: > On Monday, October 22, 2012 19:49:21 Sven Langkamp wrote: > > On Mon, Oct 22, 2012 at 9:30 AM, Inge Wallin > wrote: > > > On Sunday, October 21, 2012 18:11:18 Yue Liu wrote: > > > > 2012/10/21 Boudewijn Rempt

Re: Architecture Refactor Suggestion: Bigger reorganization

2012-10-22 Thread Sven Langkamp
On Mon, Oct 22, 2012 at 3:04 PM, Inge Wallin wrote: > On Monday, October 22, 2012 09:57:51 Jaroslaw Staniek wrote: > > ... > > > That's good approach, especially the separation of painting routines > > from the headless part. > > No, I don't advocate separation of painting from the headless part.

Re: Architecture Refactor Suggestion: Bigger reorganization

2012-10-22 Thread Sven Langkamp
On Mon, Oct 22, 2012 at 9:30 AM, Inge Wallin wrote: > On Sunday, October 21, 2012 18:11:18 Yue Liu wrote: > > 2012/10/21 Boudewijn Rempt : > > > On Sunday 21 October 2012 Oct, Yue Liu wrote: > > >> Hi, > > >> > > >> Currently filters are loaded based on application's native mime-type. > > >> And

Re: Week of polish

2012-10-08 Thread Sven Langkamp
On Mon, Oct 8, 2012 at 2:29 AM, Inge Wallin wrote: > At 13th of April Boemann suggested an informal sprint to take care of the > bugs > in the calligracommons module since they "normally fall outside the itches > each of us like to scratch". > > To make a long story short, this sprint happened be

Re: Calligra Article by LinuxUser

2012-09-14 Thread Sven Langkamp
On Fri, Sep 14, 2012 at 12:05 PM, Jaroslaw Staniek wrote: > Hi, > A new Calligra Article by LinuxUser (German): > > http://www.linux-community.de/Internal/Artikel/Print-Artikel/LinuxUser/2012/10/Calligra-KDE-Office-aus-einem-Guss Not very positive. Their conclusion (rough translation): Calligr

Re: Review Request: Fix wrong saving of unpacked XML form of ODF

2012-08-25 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106200/#review18007 --- Ship it! Ship It! - Sven Langkamp On Aug. 26, 2012

Re: Calligra Author's GUI

2012-08-15 Thread Sven Langkamp
On Wed, Aug 15, 2012 at 3:16 PM, Jaroslaw Staniek wrote: > On 15 August 2012 14:59, Boudewijn Rempt wrote: > > On Wednesday 15 August 2012 Aug, Jaroslaw Staniek wrote: > >> The first question that pops up for me is: will we try to depart from > >> the KDE4 UI style for Calligra Author to make it

Review Request: Limit size of preview image in resource item chooser

2012-08-04 Thread Sven Langkamp
- libs/widgets/KoResourceItemChooser.cpp 933652c Diff: http://git.reviewboard.kde.org/r/105865/diff/ Testing --- Tested with 2000x2000 pattern and no freeze anymore. Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel

Review Request: Fix for artifacts in the path point handles

2012-08-02 Thread Sven Langkamp
r/105834/s/662/ Thanks, Sven Langkamp ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

  1   2   >