----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119677/#review64095 -----------------------------------------------------------
krita/ui/kis_statusbar.cc <https://git.reviewboard.kde.org/r/119677/#comment44737> Why got this removed? krita/ui/kis_statusbar.cc <https://git.reviewboard.kde.org/r/119677/#comment44733> no prefix here too. Also this needs i18n() to be translated. krita/ui/kis_statusbar.cc <https://git.reviewboard.kde.org/r/119677/#comment44732> We don't use prefixes for type like qcol_. Also m_ is only used for members and not for local variables. krita/ui/kis_statusbar.cc <https://git.reviewboard.kde.org/r/119677/#comment44735> QColor is always RGB. Beside that could images also have 2 or 5 channels. krita/ui/kis_statusbar.cc <https://git.reviewboard.kde.org/r/119677/#comment44736> no prefix here. m_ is only used for member variables. krita/ui/kis_statusbar.cc <https://git.reviewboard.kde.org/r/119677/#comment44738> String might jump with different values. - Sven Langkamp On Aug. 8, 2014, 11:37 nachm., Latte OfCode wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119677/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2014, 11:37 nachm.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > ------- > > Two changes to statusbar: 1) Show cursor location, 2) Show foreground color > > > Diffs > ----- > > krita/ui/kis_statusbar.h 5b5c74e > krita/ui/kis_statusbar.cc 7f57007 > > Diff: https://git.reviewboard.kde.org/r/119677/diff/ > > > Testing > ------- > > Built Krita successfully after making changes. Tested added functionality. > > > Thanks, > > Latte OfCode > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
