Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-11-27 Thread Pierre Ducroquet
behaviour. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-11-27 Thread Pierre Ducroquet
background color to help speed up the development) now doesn't exhibit the wrong layout behaviour. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-11-26 Thread Pierre Ducroquet
d up the development) now doesn't exhibit the wrong layout behaviour. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-11-19 Thread Pierre Ducroquet
https://git.reviewboard.kde.org/r/120733/diff/ Testing --- A simple document with page styles (changing the background color to help speed up the development) now doesn't exhibit the wrong layout behaviour. Thanks, Pierre Ducroquet ___ call

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-11-08 Thread Pierre Ducroquet
behaviour. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-11-07 Thread Pierre Ducroquet
r.cpp ce039219c1a044b13ae81420832eb894346b88db Diff: https://git.reviewboard.kde.org/r/120733/diff/ Testing --- A simple document with page styles (changing the background color to help speed up the development) now doesn't exhibit the wrong layout behaviour. Thanks, Pierre

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-11-01 Thread Pierre Ducroquet
e I'll likely send the patch for further review… - Pierre --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120733/#review69557 --------

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-10-28 Thread Pierre Ducroquet
-- A simple document with page styles (changing the background color to help speed up the development) now doesn't exhibit the wrong layout behaviour. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.o

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-10-24 Thread Pierre Ducroquet
ding the > > need to release all after) if it mismatches the next available page in the > > current list of pages > > > > possibly this could be even smarter > > Pierre Ducroquet wrote: > I partially agree, I'll try that way nevertheless, but

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-10-23 Thread Pierre Ducroquet
have to go that way for your other issue so it won't be too much trouble. - Pierre ------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120733/#review68957 ---

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-10-23 Thread Pierre Ducroquet
nt) now doesn't exhibit the wrong layout behaviour. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 120733: Pass more data between layout and RootAreaProvider

2014-10-22 Thread Pierre Ducroquet
ument with page styles (changing the background color to help speed up the development) now doesn't exhibit the wrong layout behaviour. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailma

Re: Review Request 120645: Msword filter - Fix the page borders when there is a header/footer included in margin

2014-10-18 Thread Pierre Ducroquet
PDF exported by word than our previous result. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120645: Msword filter - Fix the page borders when there is a header/footer included in margin

2014-10-18 Thread Pierre Ducroquet
/ Testing --- Check with the file of bug report 337675 : no more crash. Check with cstester and ~50 .doc files : the changes are always closer to a PDF exported by word than our previous result. Thanks, Pierre Ducroquet ___ calligra-devel mailing

Re: Review Request 120645: Msword filter - Fix the page top border when there is a header

2014-10-18 Thread Pierre Ducroquet
closer to a PDF exported by word than our previous result. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 120645: Fix the page top border when there is a header

2014-10-18 Thread Pierre Ducroquet
://git.reviewboard.kde.org/r/120645/diff/ Testing --- Check with the file of bug report 337675 : no more crash. Check with cstester and ~50 .doc files : the changes are always closer to a PDF exported by word than our previous result. Thanks, Pierre Ducroquet

Re: Review Request 120468: Check cell size constraints before aborting layout

2014-10-03 Thread Pierre Ducroquet
out/KoTextLayoutTableArea.cpp 4fbec7b3b0a0e4b92a2bbbd925491b084e80748a Diff: https://git.reviewboard.kde.org/r/120468/diff/ Testing --- Document from bug report 293337 is now working, so both regular tables and weird too-small cells work. Thanks, Pierre Ducroq

Re: Review Request 120468: Check cell size constraints before aborting layout

2014-10-02 Thread Pierre Ducroquet
out/KoTextLayoutTableArea.cpp 4fbec7b3b0a0e4b92a2bbbd925491b084e80748a Diff: https://git.reviewboard.kde.org/r/120468/diff/ Testing --- Document from bug report 293337 is now working, so both regular tables and weird too-small cells work. Thanks, Pierre Ducroq

Re: Review Request 120468: Check cell size constraints before aborting layout

2014-10-02 Thread Pierre Ducroquet
ere. Diffs - libs/textlayout/KoTextLayoutTableArea.cpp 4fbec7b3b0a0e4b92a2bbbd925491b084e80748a Diff: https://git.reviewboard.kde.org/r/120468/diff/ Testing --- Document from bug report 293337 is now working, so both regular tables and weird too-small cells work. Thanks, Pie

Re: Review Request 120468: Workaround bug 293337

2014-10-02 Thread Pierre Ducroquet
ibs/textlayout/KoTextLayoutTableArea.cpp 4fbec7b3b0a0e4b92a2bbbd925491b084e80748a Diff: https://git.reviewboard.kde.org/r/120468/diff/ Testing --- Document from bug report 293337 is now working, so both regular tables and weird too-small cells work. Thanks, Pierre Ducroq

Re: Review Request 120468: Workaround bug 293337

2014-10-02 Thread Pierre Ducroquet
cpp 4fbec7b3b0a0e4b92a2bbbd925491b084e80748a Diff: https://git.reviewboard.kde.org/r/120468/diff/ Testing --- Document from bug report 293337 is now working, so both regular tables and weird too-small cells work. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calli

Review Request 120468: Workaround bug 293337

2014-10-02 Thread Pierre Ducroquet
bug report 293337 is now working, so both regular tables and weird too-small cells work. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120375: Don't look further than what we are currently layouting

2014-09-26 Thread Pierre Ducroquet
sting done on : - the two test cases for bug 332220 : no more crash, comment still visible. - a simple non-crashing file : no crash, comment still visible. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kd

Review Request 120375: Don't look further than what we are currently layouting

2014-09-25 Thread Pierre Ducroquet
imple non-crashing file : no crash, comment still visible. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

2014-09-18 Thread Pierre Ducroquet
306000 : layouting the document now works and does not end up in an infinite loop. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

2014-09-18 Thread Pierre Ducroquet
f fixes that, my bad. - Pierre --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120250/#review66862 --- On Sept. 18, 2014, 7

Re: Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

2014-09-18 Thread Pierre Ducroquet
eport 306000 : layouting the document now works and does not end up in an infinite loop. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

2014-09-18 Thread Pierre Ducroquet
report 306000 : layouting the document now works and does not end up in an infinite loop. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

2014-09-18 Thread Pierre Ducroquet
s (updated) - libs/textlayout/KoTextLayoutArea.cpp c74dbd4 Diff: https://git.reviewboard.kde.org/r/120250/diff/ Testing --- Checked with the document from bug report 306000 : layouting the document now works and does not end up in an infinite loop. Thanks, Pierre

Review Request 120250: Change blockLayout return to be more explicit

2014-09-17 Thread Pierre Ducroquet
. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Name change of KoShapeBorderModel to KoShapeStrokeModel to make the naming clearer.

2012-03-25 Thread Pierre Ducroquet
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104405/#review11845 --- Ship it! Ship It! - Pierre Ducroquet On March 25, 2012, 5

Re: Review Request: Final border refactoring : remove KoTableBorderStyle totally

2011-11-12 Thread Pierre Ducroquet
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102998/#review8132 --- Ship it! Ship It! - Pierre Ducroquet On Nov. 12, 2011, 10

Re: Review Request: Final border refactoring : remove KoTableBorderStyle totally

2011-11-12 Thread Pierre Ducroquet
/kotext/styles/tests/TestTableCellStyle.cpp 9da63aa libs/odf/KoBorder.h 7fb3f33 libs/odf/KoBorder.cpp 61d1dcf libs/textlayout/KoTextLayoutCellHelper.cpp f1eb7fa Diff: http://git.reviewboard.kde.org/r/102998/diff/diff Testing --- Thanks, Pierre Ducroquet

Re: Review Request: Final border refactoring : remove KoTableBorderStyle totally

2011-11-09 Thread Pierre Ducroquet
://git.reviewboard.kde.org/r/102998/diff/diff Testing --- Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Style inheritance

2011-11-07 Thread Pierre Ducroquet
found, I guess, what could possibly be found… I don't see major issues with these changes, I'm only really surprised that the saving code isn't more affected by this change. Did you try some round-tripping ? Anyway, it all seems good to me. - Pierre Ducroquet On Nov. 7, 2011, 5

Re: Review Request: Added support for text:continue-list

2011-11-01 Thread Pierre Ducroquet
cstester regression... - Pierre Ducroquet On Nov. 1, 2011, 6:48 p.m., Gopalakrishna Bhat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Final border refactoring : remove KoTableBorderStyle totally

2011-11-01 Thread Pierre Ducroquet
really use and understand that unit test, making testing of it unreliable. I'll try anyway. - Pierre --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102998/#review7793 -

Review Request: Final border refactoring : remove KoTableBorderStyle totally

2011-10-30 Thread Pierre Ducroquet
/kotext/styles/KoTableCellStyle.h f42c2a8 libs/kotext/styles/KoTableCellStyle.cpp eb96cf9 libs/kotext/styles/tests/TestTableCellStyle.cpp 9da63aa libs/textlayout/KoTextLayoutCellHelper.cpp f1eb7fa Diff: http://git.reviewboard.kde.org/r/102998/diff/diff Testing --- Thanks, Pierre

Re: KoGenStyle::rmProperty ?

2011-10-29 Thread Pierre Ducroquet
Quoting Uzak Matus : Hi, I would like to discuss addition of a KoGenStyle::rmProperty method. There's a reason (maybe a stupid one) that I could make use of it in libmsooxml at the moment without re-designing and rewriting a lot of code. We collect there a number of KoGenStyle variables st

Re: Review Request: New UI for words, some hopefully insignificat changes to other apps

2011-10-18 Thread Pierre Ducroquet
ssues with our current interface, but it's a good step forward, and I like it. Good work Boemann - Pierre Ducroquet On Oct. 15, 2011, 4:49 p.m., C. Boemann wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request: Continue refactoring of Kotext/styles/KoTableBorderStyle and KoBorder

2011-10-11 Thread Pierre Ducroquet
, running kotext unit tests. Thanks, Pierre Ducroquet ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: Continue refactoring of Kotext/styles/KoTableBorderStyle and KoBorder

2011-09-27 Thread Pierre Ducroquet
libs/textlayout/KoTextLayoutCellHelper.cpp 7d0dfd7 words/part/KWCanvasBase.cpp fb7fc2c Diff: http://git.reviewboard.kde.org/r/102724/diff/diff Testing --- Compiling, running kotext unit tests. Thanks, Pierre Ducroquet ___ calligra-devel

Re: Review Request: Add support for relative minimum line height

2011-08-12 Thread Pierre Ducroquet
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102268/ --- (Updated Aug. 12, 2011, 10:53 a.m.) Review request for Calligra and Sebast

Review Request: Add support for relative minimum line height

2011-08-09 Thread Pierre Ducroquet
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102268/ --- Review request for Calligra and Sebastian Sauer. Summary --- style:li

Re: Review Request: Support for style:shadow in kotext styles

2011-08-07 Thread Pierre Ducroquet
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102241/ --- (Updated Aug. 7, 2011, 9:52 a.m.) Review request for Calligra. Changes -

Review Request: Support for style:shadow in kotext styles

2011-08-07 Thread Pierre Ducroquet
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102241/ --- Review request for Calligra. Summary --- Add support for style:shadow

Re: Review Request: Refactor kotext/KoTableCellStyle

2011-08-03 Thread Pierre Ducroquet
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102200/ --- (Updated Aug. 3, 2011, 8:50 p.m.) Review request for Calligra. Changes -

Review Request: Refactor kotext/KoTableCellStyle

2011-08-03 Thread Pierre Ducroquet
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102200/ --- Review request for Calligra. Summary --- First refactoring of KoText

Re: Review Request: Kotext, cell styles, support for text properties

2011-05-04 Thread Pierre Ducroquet
> On May 3, 2011, 10:17 p.m., Pierre Ducroquet wrote: > > Hi > > > > Nice work, but I've got two questions : > > - where is that defined in the OpenDocument specification ? I can not find > > it, and it was never reported by the automated unit tests...

Re: Review Request: Kotext, cell styles, support for text properties

2011-05-03 Thread Pierre Ducroquet
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101281/#review3092 --- Hi Nice work, but I've got two questions : - where is that defi

Re: Text saving broken

2011-04-14 Thread Pierre Ducroquet
Ok, I'll do that (but tonight) Quoting "C. Boemann" : > Pinaraf, can you look at this one please > > > On Thursday 14 April 2011 10:20:23 Thorsten Zachmann wrote: >> Hello, >> >> when I wanted to test some stuff I found out that saving of text is >> currently broken. >> >> At the moment we save te