Re: Review Request: Move ElapsedTime class to a private header that wont be installed

2012-12-19 Thread Philip Hoof
h - Philip --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107717/#review23471 --- On Dec. 14, 2012, 1:39 p.m., Phili

Review Request: Move ElapsedTime class to a private header that wont be installed

2012-12-14 Thread Philip Hoof
r/107717/diff/ Testing --- Thanks, Philip Hoof ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Avoid compiler warning in Global.h for external projects using Sheets' components

2012-12-04 Thread Philip Hoof
atically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107580/#review22980 ------- On Dec. 4, 2012, 2:47 p.m., Philip Hoof wrote: > > --- > This is a

Review Request: Avoid compiler warning in Global.h for external projects using Sheets' components

2012-12-04 Thread Philip Hoof
--- This patch makes Global.h of sheets/ stop using old-style casts, avoiding a compiler warning for projects using Calligra's sheets component. Diffs - sheets/Global.h 1759095 Diff: http://git.reviewboard.kde.org/r/107580/diff/ Testing --- Thanks, Philip

Re: Review Request: Add a parent parameter to CanvasItem in sheets/part/

2012-11-29 Thread Philip Hoof
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107514/#review22796 --- Ship it! Ship It! - Philip Hoof On Nov. 29, 2012, 3:23 p.m

Re: Review Request: Add a parent parameter to CanvasItem in sheets/part/

2012-11-29 Thread Philip Hoof
sit: http://git.reviewboard.kde.org/r/107514/#review22776 --- On Nov. 29, 2012, 3:23 p.m., Philip Hoof wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request: Add a parent parameter to CanvasItem in sheets/part/

2012-11-29 Thread Philip Hoof
. Description --- Add a parent parameter with default = 0 to the constructor of CanvasItem Diffs - sheets/part/CanvasItem.h dfbefdc sheets/part/CanvasItem.cpp 8c54907 Diff: http://git.reviewboard.kde.org/r/107514/diff/ Testing --- Thanks, Philip Hoof

Re: Review Request: Add a parent parameter to CanvasItem in sheets/part/

2012-11-29 Thread Philip Hoof
. Description --- Add a parent parameter with default = 0 to the constructor of CanvasItem Diffs - sheets/part/CanvasItem.h dfbefdc sheets/part/CanvasItem.cpp 8c54907 Diff: http://git.reviewboard.kde.org/r/107514/diff/ Testing --- Thanks, Philip Hoof

Review Request: Add a parent parameter to CanvasItem in sheets/part/

2012-11-29 Thread Philip Hoof
with default = 0 to the constructor of CanvasItem Diffs - sheets/part/CanvasItem.h dfbefdc sheets/part/CanvasItem.cpp 8c54907 Diff: http://git.reviewboard.kde.org/r/107514/diff/ Testing --- Thanks, Philip Hoof ___ calligra-devel