dfaure accepted this revision as: dfaure.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D25664
To: ognarb, #calligra:_3.0, #kf6, dfaure
Cc: danders, dfaure, Calligra-Devel-list, davidllewellynjones, dcaliste,
ognarb, cochise, vandenoever
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R8 Calligra
BRANCH
arcpatch-D25664
REVISION DETAIL
https://phabricator.kde.org/D25664
To: ognarb, #calligra:_3.0, #kf6, dfaure
Cc: danders, dfaure, Calligra-Devel-list, davidllewellynjones, dcaliste
dfaure added a comment.
Then write your own, it's easy:
// this adds const to non-const objects (like std::as_const)
template Q_DECL_CONSTEXPR typename std::add_const::type
&koAsConst(T &t) noexcept { return t; }
// prevent rvalue arguments:
template void koAsConst(const T
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> KoDialog.cpp:161
>
> -QObject::connect(button, SIGNAL(clicked()),
> - &mButtonSignalMapper, SLOT(map()));
> +QObject::connect(but
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R8 Calligra
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D25481
To: ognarb, #calligra:_3.0, dfaure
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise,
vandenoever
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> icalendarexport.cpp:30
>
> +#if KCALCORE_VERSION >= QT_VERSION_CHECK(5, 12, 0)
> +#include
You can't test for the version number before including
kcal[end
dfaure added a reviewer: vkrause.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D23202
To: asturmlechner, #calligra:_3.0, dfaure, vkrause
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
till there.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125485/#review86285
---
On Oct. 3, 2015, 9:56 a.
On Monday 05 October 2015 12:59:11 Thorsten Zachmann wrote:
> On 2015-10-05 12:44, David Faure wrote:
> > On Monday 05 October 2015 10:30:04 Boudewijn Rempt wrote:
> >> Sorry, was waiting for Zagge.
> >
> > No problem. Please note that these are waiting for review to
marked as submitted.
Review request for Calligra and Thorsten Zachmann.
Changes
---
Submitted with commit f3dcd03afe4e17ca3c633db782bddf1f448b1337 by David Faure
to branch calligra/2.9.
Repository: calligra
Description
---
REVIEW: 125489
Diffs
-
stage/part/KPrView.h
marked as submitted.
Review request for Calligra, Boudewijn Rempt and Thorsten Zachmann.
Changes
---
Submitted with commit dab27ce5c2b4aa45adafb417a86029a0f3229f0c by David Faure
to branch calligra/2.9.
Repository: calligra
Description
---
Mistyping a filename in the file widget
marked as submitted.
Review request for Calligra and Thorsten Zachmann.
Changes
---
Submitted with commit a37876fe4172f2588b8045f9793529807c954f5b by David Faure
to branch calligra/2.9.
Repository: calligra
Description
---
Color set dialog: make combo non-editable, since typing a
marked as submitted.
Review request for Calligra.
Changes
---
Submitted with commit b5593f774dec16db15d9c5c18e170815e44df971 by David Faure
to branch calligra/2.9.
Repository: calligra
Description
---
The presentation window already handles Esc, but I had used Alt-Tab
during my
On Monday 05 October 2015 10:30:04 Boudewijn Rempt wrote:
> Sorry, was waiting for Zagge.
No problem. Please note that these are waiting for review too:
REVIEW: 125490
REVIEW: 125489
REVIEW: 125487
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Framework
marked as submitted.
Review request for Calligra and Thorsten Zachmann.
Changes
---
Submitted with commit 857fbbc5ba295c84770ab1f21aa92a9c96ce by David Faure
to branch calligra/2.9.
Repository: calligra
Description
---
I expected the "empty text" test to catch it, bu
marked as submitted.
Review request for Calligra and Thorsten Zachmann.
Changes
---
Submitted with commit fde87f3a5ebc1942046aaceb68fecf405d8c4173 by David Faure
to branch calligra/2.9.
Repository: calligra
Description
---
Add KPrShapeAnimations::dump() for debugging the animation
marked as submitted.
Review request for Calligra and Thorsten Zachmann.
Changes
---
Submitted with commit 9bb42272ea9a36b28c93890e7a56f21b28274684 by David Faure
to branch calligra/2.9.
Repository: calligra
Description
---
steps() returns m_shapeAnimations but a (shallow) copy of
marked as submitted.
Review request for Calligra and Thorsten Zachmann.
Changes
---
Submitted with commit f1bcb56e819c4a1c6219473ff1fdb075093469e6 by David Faure
to branch calligra/2.9.
Repository: calligra
Description
---
(i.e. F5, Alt+Tab, Alt+F4). Fix: exiting presentation mode
marked as submitted.
Review request for Calligra.
Changes
---
Submitted with commit cf9eebce3757ea4c0e9c551e3f2c016ce930a3e6 by David Faure
to branch calligra/2.9.
Repository: calligra
Description
---
I somehow ended up selecting the parent directory in some of my tests...
And with
marked as submitted.
Review request for Calligra and Thorsten Zachmann.
Changes
---
Submitted with commit b5c3aa0a80de6609a5d70312210c1782684bb3ed by David Faure
to branch calligra/2.9.
Repository: calligra
Description
---
This makes the calling code much less confusing to read
it's either the interaction - but your evidence suggests that is correct
>
> or the setup of the indentation - as you suggest that is the culprit'
If that is the case, where do you suggest to debug this further?
i.e. where is the code that translates "int level" to an act
))
the second time.
This looks correct, so does this mean the indentation position for level 1
and level 2 are the same ??
(please CC me)
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
calligra-devel mailing
Seems tricky to implement though
Thanks,
David Faure
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
-
Esc finally works ;)
I've been missing this since the flake redesign.
Thanks,
David Faure
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
ext-selection-bug.png
Thanks,
David Faure
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
s://git.reviewboard.kde.org/r/125485/#review86281
-------
On Oct. 2, 2015, 8:53 p.m., David Faure wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125485/
> -
marked as submitted.
Review request for Calligra.
Changes
---
Submitted with commit 3ac85ccdf70c5ef56c37548aa4a4dbfff7c2cbf1 by David Faure
to branch calligra/2.9.
Repository: calligra
Description
---
(gdb) p m_imageRect
$3 = {
xp = 139,
yp = 0,
w = 0,
h = 0
}
(gdb) p
432bc5e023f41a8927cbe9e854b2205962ae4e4b
Diff: https://git.reviewboard.kde.org/r/125489/diff/
Testing
---
No GUI changes seen, the start presentation actions still work
Thanks,
David Faure
___
calligra-devel mailing list
calligra-devel@kde.org
https
this.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125489/#review86274
---
On Oct. 2, 2015, 9:09 p.m., Da
432bc5e023f41a8927cbe9e854b2205962ae4e4b
Diff: https://git.reviewboard.kde.org/r/125489/diff/
Testing
---
No GUI changes seen, the start presentation actions still work
Thanks,
David Faure
___
calligra-devel mailing list
calligra-devel@kde.org
https
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125485/#review86277
---
don't forget this one :)
- David Faure
On Oct. 2, 20
marked as submitted.
Review request for Calligra and Thorsten Zachmann.
Changes
---
Submitted with commit a9a14b94eaea340bb78e29a351d490fcac8b0a8a by David Faure
to branch calligra/2.9.
Repository: calligra
Description
---
Fix crash when typing a bogus color-set name in the color
see the shapes shown by anim2.
Thanks,
David Faure
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
shape/PictureShapeConfigWidget.cpp
e8cf8ccff228aa7a50a6ec58a2a1df7ede1a2ee0
Diff: https://git.reviewboard.kde.org/r/125494/diff/
Testing
---
Thanks,
David Faure
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
commit.
Diffs
-
plugins/pictureshape/PictureShapeConfigWidget.h
14b59aaf749b335a3f69b075a8422732664f0ecb
plugins/pictureshape/PictureShapeConfigWidget.cpp
e8cf8ccff228aa7a50a6ec58a2a1df7ede1a2ee0
Diff: https://git.reviewboard.kde.org/r/125493/diff/
Testing
---
Thanks,
David
Diff: https://git.reviewboard.kde.org/r/125492/diff/
Testing
---
Thanks,
David Faure
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
,
David Faure
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
iew.h 1ca41cee7fc38cc2a3156fad1f2283eaf217e2ef
stage/part/KPrView.cpp 432bc5e023f41a8927cbe9e854b2205962ae4e4b
Diff: https://git.reviewboard.kde.org/r/125490/diff/
Testing
---
Thanks,
David Faure
___
calligra-devel mailing list
calligra-devel@kde.org
/diff/
Testing
---
No GUI changes seen, the start presentation actions still work
Thanks,
David Faure
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
ropWidget.cpp 7068c37923daa00c9b51349ae19dd73bb40d982f
Diff: https://git.reviewboard.kde.org/r/125488/diff/
Testing
---
Thanks,
David Faure
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
Description
---
Color set dialog: make combo non-editable, since typing a random name serves no
purpose there.
Diffs
-
libs/widgets/KoEditColorSet.ui c57d2d5478a84336c8a01e206d7a90ee4de6a721
Diff: https://git.reviewboard.kde.org/r/125487/diff/
Testing
---
Thanks,
David
Description
---
Fix crash when typing a bogus color-set name in the color set dialog.
Diffs
-
libs/widgets/KoColorSetWidget.cpp 5417c597f8e9486a46ec9461157252312da49726
Diff: https://git.reviewboard.kde.org/r/125486/diff/
Testing
---
Thanks,
David Faure
,
David Faure
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
ybe something in meta.xml or so.
* I miss "click on 4 text shapes and change the font for all of them". This
worked in KOffice :-)
(the Text editing tool only applies to one shape). Is there any way to make
this happen again
with the current d
when the text tool is deactivated
In addition: why did this commit to calligra/2.8 was never merged to
calligra/2.9?
http://osdir.com/ml/kde-commits/2014-09/msg00859.html
Was I supposed to forwardport my commits rather than relying on a regular git
merge?
PS: please CC me I'm not subscribed.
ists consider that these icons should
be themeable...
BTW did you look into the xdg icon spec?
I guess it's not there?
On the other hand it doesn't prevent doing it since it's not about sharing
icons; it's just harder
to convince Qt to look there :) (I think qiconengine and kic
> On Aug. 26, 2015, 7:12 a.m., Boudewijn Rempt wrote:
> > Sounds like the applix filter got broken then :-(
>
> David Faure wrote:
> Can you download this file and try opening it?
> http://www.davidfaure.fr/kde/plan1.aw
> Works for me with calligrawords fro
bau wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124927/
> ---
>
> (Updated Aug. 26, 2015, 12:03 a.m.)
>
>
> Revi
grep data'"' | grep -v '"data"'
And indeed there is very little value in being able to write
KStandardDirs::locate("stagedata", "templates/exportHTML/toc.html")
instead of
KStandardDirs::locate("data", "stage/te
of course: how wrong is that approach?
>
It's wrong because it's fixing the symptom (null d pointer) instead of fixing
the cause (using an action that was already deleted).
My recommendation: run the app in valgrind.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Workin
d just a typo.
>
> So would anyone strongly advise against simply applying a patch to all those
> license headers and change the "2" to "2.1"?
Being pragmatic, I would say yes. I really can't see a KDE contributor coming
back and saying "I wanted my
rl+End in stage. Didn't test the other apps, but they should be
unaffected.
Thanks,
David Faure
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
/TextTool.cpp 2bf8787816c100dbd7acde8ac730e91676a3ac41
Diff: https://git.reviewboard.kde.org/r/120010/diff/
Testing
---
Esc now works :)
Thanks,
David Faure
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman
/KoToolBase.cpp 963dfad2c714f24ad34ae7cd09e8b2e3d457f7ae
libs/flake/KoToolProxy.h 6723c9c7c6e5404448d969606d267c72c5b0b3e6
Diff: https://git.reviewboard.kde.org/r/120011/diff/
Testing
---
Ctrl+Home/Ctrl+End in stage. Didn't test the other apps, but they should be
unaffected.
/120010/diff/
Testing
---
Esc now works :)
Thanks,
David Faure
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
tree, no (I guess it was
there because it's a single file and we were lazy back then ;)
- David Faure
On Nov. 18, 2012, 1:36 p.m., Friedrich W. H. Kossebau wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
s
bug.
Alternatively, to avoid falling in this historical trap again, switch the
default around, rename this method to enableNameExpansion(), remove all calls
to disallowNameExpansion(), and the few necessary calls to
enableNameExpansion() in the old-native-format filters.
--
David Faure,
SVN commit 1282459 by dfaure:
Port to K_EXPORT_PLUGIN/K_PLUGIN_FACTORY, but this stuff uses KoTool.h which
doesn't seem to exist anymore.
CCMAIL: calligra-devel@kde.org
M +4 -4 %{APPNAME}Plugin.cpp
M +2 -2 %{APPNAME}Plugin.h
--- trunk/KDE/kdesdk/kapptemplate/templates/C++/fl
.kde.org/r/101271/
> ---
>
> (Updated May 2, 2011, 1:40 p.m.)
>
>
> Review request for Calligra and David Faure.
>
>
> Summary
> ---
>
> Lately, a lot of document has been cropping up that have names
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101271/
> ---
>
> (Updated May 2, 2011, 1:40 p.m.)
>
>
> Review request for Calligra and David Faure.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101271/#review3056
---
Such hardcoded lists of mimetypes and extensions make me cringe
. And if it was reused, then a second close() won't
hurt.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
diff --git a/libs/odf/KoXmlWriter.cpp b/libs/odf/KoXmlWriter.cpp
index b2ec8a4..bcb205e 100644
--- a/libs
seems that:
>
> [branch]
> branch.master.rebase = true
>
> would work, but since you have to do it individually for each branch, I am
> not sure it is worth it.
AFAIU, the whole point of autosetuprebase=always is that you won't have to
write branch.foo.rebase=true for *futu
On Thursday 13 January 2011, David Faure wrote:
> On Thursday 13 January 2011, Marijn Kruisselbrink wrote:
> > On Tuesday, January 11, 2011 03:50:51 pm David Faure wrote:
> > > Hello,
> > >
> > > I have a question for the applixspread import filter: if I hav
On Thursday 13 January 2011, Marijn Kruisselbrink wrote:
> On Tuesday, January 11, 2011 03:50:51 pm David Faure wrote:
> > Hello,
> >
> > I have a question for the applixspread import filter: if I have a formula
> > like =B1+C1 for A1,
> > and I want to reu
import filter? Thanks.
(This is because the applix file format can 'share' formulas, i.e. the input
file only has B1+C1 for A1, and other cells just point to the same relative
formula, so in the filter we need to transpose/adjust/offset/whatever-this-is-
called the formula)
--
David
t calligra app for any mimetype we support.
>
> So perhaps we need extra .desktop file, e.g. with:
> X-KDE-ServiceTypes=Calligra/Application
> MimeType=... (only default mimetypes here, unlike in the app.desktop
> files where all supported mimetypes are listed)
This is the same so
67 matches
Mail list logo
