----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125495/ -----------------------------------------------------------
(Updated Oct. 5, 2015, 10:24 a.m.) Status ------ This change has been marked as submitted. Review request for Calligra and Thorsten Zachmann. Changes ------- Submitted with commit 9bb42272ea9a36b28c93890e7a56f21b28274684 by David Faure to branch calligra/2.9. Repository: calligra Description ------- steps() returns m_shapeAnimations but a (shallow) copy of it. So steps().removeAll(step) really doesn't do anything. => replace steps() with m_shapeAnimations everywhere. Diffs ----- stage/part/KPrShapeAnimations.cpp a7e51724f1abec256842832bf961679cba4cc7b5 Diff: https://git.reviewboard.kde.org/r/125495/diff/ Testing ------- When you had 1. <ANIM1> 2. <ANIM2> in the list of shape animations and then removed ANIM1, the list model would correctly update to 1. <ANIM2> but then during the presentation, the first click would do nothing, and I would have to click again to see the shapes shown by anim2. Thanks, David Faure
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
