D29542: Refactor canvas event handling

danders added a comment. This seems to work fine, I also tested with only pageapp changes. Imho I would prefer to separate the pageapp and KoMainWindow changes into separate commits, The pageapp changes should go into 3.2 branch followed by a swift release. I don't think the KoMainWindow

D29542: Refactor MainWindow view

danders added a comment. In D29542#668076 , @anthonyfieroni wrote: > `d->rootPart->createView(doc, this);` Creates the view which parent is main window. Ahh, yes, but then... Why will it not crash if a new document is set so that d->

D29542: Refactor MainWindow view

danders added a comment. Hmmm, it seems to me you are creating a leak in your lines 544, 545? (Have not tested, I might be wrong) Afaics the problem is that a focus event is issued that accesses the view after death. Possibly a deleteLater() would do it, but I tried with setting paret

D28820: Chart: Fix Bug 240520 - No axes lines when creating new chart

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:240fb4f60810: Chart: Fix Bug 240520 - No axes lines when creating new chart (authored by danders). REPOSITORY R8 Calli

D28820: Chart: Fix Bug 240520 - No axes lines when creating new chart

danders created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Turns out KChart needs a explicitly set pen to draw ruler lines. KChart 2.7.0 will have the option to set a pen int

T12815: Create Calligra Framework by separating out applications and libraries

danders added a comment. I think where leinir has landed is more doable than a frameworks. Also if compiletime is a big hurdle, I see a couple of things that can be done: - Remove pigment, see T5738 . - Make more finegrained productsets. Pt the on

D7228: SpellCheck: Fix markup rebasing when simple edits are done (one char added)

danders abandoned this revision. danders added a comment. Herald added a subscriber: Calligra-Devel-list. Has been comitted REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D7228 To: danders, boemann Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochis

D11191: Remove Plan dependencies from CMakeLists.txt

danders closed this revision. Herald added a subscriber: Calligra-Devel-list. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D11191 To: kavindap, #calligra:_3.0, staniek Cc: Calligra-Devel-list, staniek, danders, davidllewellynjones, dcaliste, ognarb, cochise, vandenoeve

D15775: Make the item background color and page cache properties available from View component

danders added a comment. ping REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15775 To: dcaliste, leinir, danders, anthonyfieroni, #calligra:_3.0 Cc: boemann, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D25034: Fix decoding of strings with wingdings/symbol characters in excel TxO records.

danders added a comment. ping REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25034 To: denexter, pvuorela, mkruisselbrink Cc: danders, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D26050: Fix build with poppler 82

danders added a reviewer: danders. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26050 To: tcanabrava, #calligra:_3.0, danders Cc: danders, rjvbb, awilcox, dcaliste, leinir, asturmlechner, ognarb, anthonyfieroni, Calligra-Devel-list, davidllewellynjones, cochise, vande

D22545: Add missing include QDate

danders closed this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D22545 To: usta, #calligra:_3.0, Calligra-Devel-list, boemann Cc: dfaure, pino, boemann, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D25714: [WIP]: Port away from deprecated KHtml

danders added a comment. Still wip, or... REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25714 To: ognarb, #calligra:_3.0 Cc: danders, leinir, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D25008: Add XLSX spreadsheets import optimisations for small/readonly devices

danders added a comment. ping? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25008 To: davidllewellynjones, #calligra:_3.0, pvuorela, dcaliste Cc: danders, anthonyfieroni, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D24852: Remove list style from headings

danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. Most seems to be positive, so go for it. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24852 To: akomakhin, pvuorela, #calligra:_3.0, boemann, danders Cc: dande

D26050: Fix build with poppler 82

danders added a comment. @tcanabrava please abondone this. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26050 To: tcanabrava, #calligra:_3.0 Cc: danders, rjvbb, awilcox, dcaliste, leinir, asturmlechner, ognarb, anthonyfieroni, Calligra-Devel-list, davidllewellynjo

D2577: KoResourcePaths: Fix handling of wildcards in directories and files

danders abandoned this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D2577 To: danders, #calligra:_3.0, staniek, Calligra-Devel-list Cc: anthonyfieroni, staniek, davidllewellynjones, dcaliste, ognarb, barman, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. There are unit tests that fail without this, so if somebody doas not come up with code that shows this is wrong, please commit. REPOSITORY R8 Calligra REVISION DETAIL https://phabric

D26328: Calculate and display proper number for headings started with lower level for DOC, DOCX and ODT.

danders added a comment. Any comments, anyone? I have not tested and does not know if it is the right way to do it. If nobody have comments, I'm willing to trust the author and say go for it! REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26328 To: mphilippov, pv

D26328: Calculate and display proper number for headings started with lower level for DOC, DOCX and ODT.

danders added a reviewer: boemann. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26328 To: mphilippov, pvuorela, denexter, dcaliste, davidllewellynjones, boemann Cc: davidllewellynjones, dcaliste, denexter, pvuorela, Calligra-Devel-list, #calligra:_3.0, ognarb, cochise

D25423: Fill table cells with color for ODS and XLSX files

danders added a comment. ping? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25423 To: mphilippov, denexter, pvuorela, davidllewellynjones, dcaliste Cc: danders, dcaliste, davidllewellynjones, denexter, Calligra-Devel-list, #calligra:_3.0, ognarb, cochise, vandenoe

D25422: Handle custom-shapes to display text in ODP files

danders added a comment. ping? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25422 To: mphilippov, denexter, davidllewellynjones, pvuorela, dcaliste Cc: danders, denexter, pvuorela, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D26050: Fix build with poppler 82

danders added a comment. Ooops, seems I fixed this (+ 0.83) in separate commits, so this can be closed. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26050 To: tcanabrava, #calligra:_3.0 Cc: danders, rjvbb, awilcox, dcaliste, leinir, asturmlechner, ognarb, anthonyf

D26221: Use QQC2 Dialog

danders added a comment. ping? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26221 To: ognarb, #calligra:_3.0, leinir Cc: danders, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D25254: Remove flow, not needed since karbon can do it all

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:f8786b001b75: Remove flow, not needed since karbon can do it all (authored by danders). REPOSITORY R8 Calligra CHANGE

D27056: Stage: Add automatic slide transition

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:4f4141727401: Stage: Add automatic slide transition (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST

D27056: Stage: Add automatic slide transition

danders created this revision. danders added a reviewer: zachmann. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Introduces 2 modes for slide transitions: Manual: Slide transition and animation

D25664: [WIP]: Port away from deprecated QSignalMapper

danders added a comment. Afaik we still support qt5.3, I don't think qAsConst is availabel. Disregard if this has changed. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25664 To: ognarb, #calligra:_3.0, #kf6, dfaure Cc: danders, dfaure, Calligra-Devel-list, davidl

D25254: Remove flow, not needed since karbon can do it all

danders added a comment. In D25254#561131 , @boemann wrote: > To be honest I kind of liked the idea of a dedicated flow drawing tool and a dedicated vector drawing tool, but since they have so little between them, and no one seem to be maintaini

D25254: Remove flow, not needed since karbon can do it all

danders added a comment. Yeah, well. If flow had some special functionallity that made it much easier to crate flow charts, I would also be reluctant to just remove it. As it stands flow has nothing special, it is only a few line of code actually, and as I see it, the karbon ui is very si

D25254: Remove flow, not needed since karbon can do it all

danders created this revision. danders added a reviewer: anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Since karbon is multipage app and stencils docker can be used by all apps,

D25214: Karbon image filter: Add multipage support

This revision was automatically updated to reflect the committed changes. Closed by commit R8:0daf145a929a: Karbon image filter: Add multipage support (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25214?vs=69566&id=69567 REVISION DETAIL

D25214: Karbon image filter: Add multipage support

danders updated this revision to Diff 69566. danders added a comment. Remove unused include REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25214?vs=69438&id=69566 BRANCH multipage_image_danders REVISION DETAIL https://phabricator.kde.org/D25214 AFFECT

D25214: Karbon image filter: Add multipage support

danders created this revision. danders added a reviewer: anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Adds ability to select page in the options dialog TEST PLAN Export to png

D25171: PDF Import: Add multipage support

This revision was automatically updated to reflect the committed changes. Closed by commit R8:c81c23998e09: PDF Import: Add multipage support (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25171?vs=69423&id=69424 REVISION DETAIL https:

D25171: PDF Import: Add multipage support

danders updated this revision to Diff 69423. danders added a comment. Remove commented code REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25171?vs=69343&id=69423 BRANCH multipagepdf REVISION DETAIL https://phabricator.kde.org/D25171 AFFECTED FILES

D25171: PDF Import: Add multipage support

danders created this revision. danders added a reviewer: anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Imports multipage pdf files as svg using poppler to generate an svg file pr

D20400: Karbon: Enable multi page capability

This revision was automatically updated to reflect the committed changes. Closed by commit R8:5a9a18f484a4: Karbon: Enable multi page capability (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20400?vs=69263&id=69300 REVISION DETAIL htt

D20400: Karbon: Enable multi page capability

danders added a comment. In D20400#475477 , @anthonyfieroni wrote: > Now we have insert page, but we don't exports them :) If you think that's ok for now go for it. Just for the record: The pdf filter goes through the svg filter and as s

D20400: Karbon: Enable multi page capability

danders updated this revision to Diff 69263. danders added a comment. KarbonView: Add slot to handle replaceActivePage REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20400?vs=69262&id=69263 BRANCH karbon_multipage_danders REVISION DETAIL https://phabri

D20400: Karbon: Enable multi page capability

danders updated this revision to Diff 69262. danders added a comment. SvgImport: Add the new layer to the page REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20400?vs=69152&id=69262 BRANCH karbon_multipage_danders REVISION DETAIL https://phabricator.kd

D20400: Karbon: Enable multi page capability

danders updated this revision to Diff 69152. danders added a comment. Handle removing pages from a pageapp properly REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20400?vs=59256&id=69152 BRANCH karbon_multipage_danders REVISION DETAIL https://phabricat

D20400: Karbon: Enable multi page capability

danders added a comment. In D20400#475477 , @anthonyfieroni wrote: > Now we have insert page, but we don't exports them :) If you think that's ok for now go for it. If you mean export to svg here, afaics there are no page element in svg.

D20400: Karbon: Enable multi page capability

danders updated this revision to Diff 59256. danders added a comment. Add dependence on LIB_KOPAGEAPP REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20400?vs=55797&id=59256 BRANCH karbon_multipage_danders REVISION DETAIL https://phabricator.kde.org/D20

D20400: Karbon: Enable multi page capability

danders added a comment. I have been pondering why we disagreed so much on the background color, and I *think* I have an answer. My take is it's because we have not been talking about quite the same thing: I have looked at karbon as an *odg* editor, since it uses odg as its native file fo

D20400: Karbon: Enable multi page capability

danders added a comment. Ooops, this didn't work as expected. This should have been a revision of D19327 . There is only small changes: 1. Updated commit message. 2. In karbon/ui/KarbonFactory.cpp: Loading of the calligra/pageapp tools. 3. In karb

D20400: Karbon: Enable multi page capability

danders created this revision. danders added a reviewer: anthonyfieroni. danders added a project: Calligra: 3.0. danders requested review of this revision. REVISION SUMMARY Since odg spec supports multiple pages, I feel karbon also needs to support it. The main things that has changed:

T10760: Calligra website unwanted blog content

danders added a comment. It seems I have not the privileges to fix this. Can someone else have a look? TASK DETAIL https://phabricator.kde.org/T10760 To: danders Cc: danders, #sysadmin, Calligra-Devel-list, #calligra:_3.0, ongunkanat, sysadmin

D11971: Use same keyword separator for read and write

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:e52edfd1b50f: D11971: Use same keyword separator for read and write (authored by danders). CHANGED PRIOR TO COMMIT htt

D11971: Use same keyword separator for read and write

danders added a comment. Yes, looks sane, I'll deal with it. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D11971 To: michaelh, #calligra:_3.0, leinir, danders Cc: Calligra-Devel-list, anthonyfieroni, dcaliste, cochise, vandenoever

D19884: Avoid deprecated QAbstractItemModel::reset()

danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. I think this should be ok REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19884 To: pvuorela, danders Cc: danders, dcaliste, Calligra-Devel-list, cochise, vandeno

D19973: MsooXmlCommonRead: protect member for double free

danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19973 To: pvuorela, #calligra:_3.0, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19941: Avoid deprecated setSupportedDragActions

danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19941 To: pvuorela, #calligra:_3.0, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19938: Avoid deprecated QRegion::subtract()

danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19938 To: pvuorela, #calligra:_3.0, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19912: Implement logging category for rtf-qt

danders added a comment. In D19912#435067 , @pvuorela wrote: > In D19912#435058 , @danders wrote: > > > Strange indents, could you fix it? > > > That's what I commented on the summary. On some

D19912: Implement logging category for rtf-qt

danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. Strange indents, could you fix it? Otherwise ok. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19912 To: pvuorela, danders Cc: danders, Calligra-Devel-list, d

D19884: Avoid deprecated QAbstractItemModel::reset()

danders added inline comments. INLINE COMMENTS > dcaliste wrote in TextDocumentStructureModel.cpp:308 > I did the same changes in https://phabricator.kde.org/D15102 at another place > and I put the begin and end at the start and end of the routine, like you > did. But I remember that I got revi

D19885: Implement logging category for excel plugins

danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19885 To: pvuorela, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19759: Remove Qt::WA_InputMethodEnabled attribute from QGraphicsWidgets

danders added a reviewer: boemann. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19759 To: pvuorela, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19760: Support Qt <5.7 on KoShape flag usage

danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19760 To: pvuorela, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19761: Remove obsolete syncX() workaround

danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19761 To: pvuorela, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

danders added a comment. In D19216#421689 , @rjvbb wrote: > > That is actual a valid point, although in say Krita with transparent pixels a checkerboard is shown. > > Heh, I've had the opportunity to work closely with professional infograp

D19327: Karbon: Enable multi page capability

danders created this revision. danders added a reviewer: anthonyfieroni. danders added a project: Calligra: 3.0. danders requested review of this revision. REVISION SUMMARY Since odg spec supports multiple pages, I feel karbon also needs to support it. Ported to use pageapp classes. K

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders added a comment. Can we get a conclussion to this? @Camilla Have you come up with any more unit tests? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vand

D19216: Karbon: Enable multi page capability

danders marked an inline comment as done. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19216 To: danders, anthonyfieroni Cc: boemann, rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

danders added inline comments. INLINE COMMENTS > anthonyfieroni wrote in KarbonConfigInterfacePage.cpp:73-90 > We can remove "number of recent files" since other apps does not have it. but > for other 2 i don't see why we remove them, someone can found useful > (somehow). About me, i want them

D19216: Karbon: Enable multi page capability

danders added a comment. In D19216#417502 , @rjvbb wrote: > > Canvas color: > > I don't quite see what it is for. You can set a background color for the canvas but it is only for the views, it is not printed. > > A custom canvas colour feat

D19216: Karbon: Enable multi page capability

danders added inline comments. INLINE COMMENTS > anthonyfieroni wrote in KarbonConfigInterfacePage.cpp:73-90 > I want to discuss comments in the review, i don't want to have in. why we > remove this? Recent file & docker font: Why does karbon need these, none of the other apps have it. Personal

D19216: Karbon: Enable multi page capability

danders added a comment. In D19216#417288 , @rjvbb wrote: > This would indeed be great to have; even a page selector when importing a multi-page document would be an improvement (the Adobe Illustrator version I've use had that; IIRC it would jus

D19216: Karbon: Enable multi page capability

danders created this revision. danders added a reviewer: anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Since odg spec supports multiple pages, I feel karbon also needs to support

D19132: Update libs/widgets to c++11

danders added a comment. > Thanks for the review, I will work next on libs/{pigment,version,widgetutils}. Hmm, maybe wait with pigment, according to rempt, only krita actually used it. I haven't looked into it, but if that is the case probably we should dump it. REPOSITORY R8 Calligr

D19132: Update libs/widgets to c++11

danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. Ok, I can't say I have scrutinized every change, but... Could you give a heads up when you continue with other parts or else there may be merge problems. I'm working on karbon and page

D19132: Update libs/widgets to c++11

danders added a reviewer: leinir. danders added a comment. Hmmm. wasn't it somethng with ms windows and for loops, leinir? Also, I think there may be detachment issues with them, clazy can tell. There is a qAsConst() solution but that is not supported in the qt version we need to support.

D18466: Fixed calligra crashing when opening remote document

danders added a comment. Thanks, I'm checking it out now... Just a couple of things: Keywords needs to be on a separate line to have effect, see https://community.kde.org/Infrastructure/Git/Hooks Also FIXED-IN is nice to add. I've updated and closed the bug, so no problem. REPOSITO

D18843: Activate stencils docker in all apps

This revision was automatically updated to reflect the committed changes. Closed by commit R8:d11e63457aab: Activate stencils docker in all apps (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18843?vs=51158&id=51575 REVISION DETAIL htt

D18963: Improve KoModeBox display in horizontal Mode

danders added a comment. Please remove trailing whitespace. REPOSITORY R8 Calligra BRANCH calligra/3.1 REVISION DETAIL https://phabricator.kde.org/D18963 To: ognarb, #calligra:_3.0, #vdg, boemann Cc: danders, boemann, anthonyfieroni, abetts, ngraham, Calligra-Devel-list, dcaliste, co

D18466: Fixed calligra crashing when opening remote document

danders added a comment. In D18466#411248 , @boemann wrote: > Dan can you please reply - I'm fine with the account but I can't reply to Ben as I am not able to send email Yes, I have, and just answered again in case something went wrong f

D18866: Use check_symbol_exists instead of check_function_exists

danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra BRANCH master REVISION DETAIL https://phabricator.kde.org/D18866 To: heikobecker, danders Cc: pino, danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18866: Use check_symbol_exists instead of check_function_exists

danders added a comment. What about the other ​check_function_exists, should they also be changed? Also, do you know when ​check_symbol_exists was introduced? We still use cmake 2.8.12. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18866 To: heikobecker Cc: dand

D18843: Activate stencils docker in all apps

danders created this revision. danders added reviewers: boemann, anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY The docker now loads in separate thread and is hidden by default,

D18841: StencilBoxDocker: Make the docker collapsed by default

danders abandoned this revision. danders added a comment. mistake REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18841 To: danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18841: StencilBoxDocker: Make the docker collapsed by default

danders created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY WIP REPOSITORY R8 Calligra BRANCH activate_stencils_danders REVISION DETAIL https://phabricator.kde.org/D1884

D18466: Fixed calligra crashing when opening remote document

danders added a comment. Ok, it's accepted so please commit/push/land REPOSITORY R8 Calligra BRANCH print-remote-files (branched from master) REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove, danders Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise,

D18466: Fixed calligra crashing when opening remote document

danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. Yes, close. When export to pdf, the mainwindow is not shown and since we don't exit, the app will hang. You need to invert the check in KoApplication line 460 so the window is shown.

D18466: Fixed calligra crashing when opening remote document

danders added a comment. Yeah, well there are some half done designs in here :( The benchmark just does not work with remote files. Don't know if it should or if it should be blocked. Let's leave it for now. If you do not specify a pdf filename, it will use the same name as in the l

D18466: Fixed calligra crashing when opening remote document

danders added a comment. Regarding the completed slot, the doc says: --print Only print and exit --export-pdf Only export to PDF and exit To exit, you need to know when all jobs have finished, so if some failed you need to track that. Also, the

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders added a comment. Well, unit tests has been added that fails without this patch and passes with this patch. If there are more test cases needed, please add them so that we can get this patch committed soon... REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D1

D18466: Fixed calligra crashing when opening remote document

danders added a comment. In D18466#400507 , @niccolove wrote: > I'm not sure on how to do that, do you have any tip? > openDocumentInternal is called by openDocument, which is called in KoApplication just before checking the arguments. When i

D18466: Fixed calligra crashing when opening remote document

danders added a comment. I think the problem is that slotFilePrint() is called (in KoApplication::start()) before the document is actually loaded. Probably we need to start printing in a slot connected to KoMainWindow::loadCompleted() instead. And to be safe, we also need to handle loadCa

D18448: Replaced "distraction free" with "fullscreen" - BUG:378527

danders added a reviewer: boemann. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18448 To: niccolove, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders added a comment. Ran this patch against new unit tests and it fixes all the expected ones, namely those where all cells in first row is merged with cells in second row. Test results without patch: https://build.kde.org/job/Calligra/job/calligra/job/kf5-qt5%20SUSEQt5.10/lastCompleted

D18095: Add new table layout unit tests

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:666ae5b484cc: Add new table layout unit tests (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE

D18095: Add new table layout unit tests

danders added a comment. Even if they do not all pass, I think they should be commited if the tests/methods are ok and the reason for not passing are genuin bugs, no? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18095 To: danders, boemann, anthonyfieroni Cc: Calli

D18095: Add new table layout unit tests

danders updated this revision to Diff 49141. danders added a comment. Add a test that trigger a loop in the table layout REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18095?vs=48957&id=49141 BRANCH table_unittest_danders REVISION DETAIL https://phabri

D18095: Add new table layout unit tests

danders added a comment. No, all do not pass, generally when the first row is merged, layout fails. (I am trying to provoke problems similar to bug 381341 that we have tried to fix in D15428 .) REPOSITORY R8 Calligra REVISION DETAIL https://phabricat

D18095: Add new table layout unit tests

danders added a comment. Not trivial (for me) to get data out of layout so it is hard to create robust tests. I don't think I have been able to create a test to simulate the loop excactly. Also, uncertain wether the MockRootAreaProvider is sufficient. Any ideas/comments wellcome. REPOSI

D18095: Add new table layout unit tests

danders created this revision. danders added reviewers: boemann, anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Adds multiple areas capabilities and tests with merged cells REPOSI

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders added a comment. Fidled a little more with this, and found several problems when table with merged cells is split over pages, like unmerged cell painted on both pages (empty on first page), caret not shown in selected cell and sometimes shown in prev cell. Tried to recreate pro

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders added a comment. In D15428#378432 , @boemann wrote: > No you misunderstand. I wasn't talking about you diff - I want to know what it is we are trying to accomplish. in spoken words Ahhh. It's a guard against loop/crash in extreme

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders added a comment. In D15428#378422 , @boemann wrote: > Dan I like your diff better - I don't think it's completely there but it's a better starting point > > On a more conceptual level, what should happen if the design of table is suc

  1   2   3   >