T12815: Create Calligra Framework by separating out applications and libraries

anthonyfieroni added a comment. In T12815#238382 , @marcboocha wrote: > Just wondering, is there any use of karbon inside the suite? What kind of use? TASK DETAIL https://phabricator.kde.org/T12815 To: anthonyfieroni Cc: marcboocha, d

D15111: [KoUnit] Let's show pixel units

anthonyfieroni added a comment. In D15111#672155 , @boemann wrote: > Even for line thickness it doesn't make sense to enable it in general. the image will change if you zoom in and out. So it changes on any other type in same way, you kno

D15111: [KoUnit] Let's show pixel units

anthonyfieroni added a comment. I miss something here, the idea behind the patch is to have pixel metrics in thickness, geometry etc. @boemann i got your opinion as to have configurable pixel units, is that right? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15111

D15111: [KoUnit] Let's show pixel units

anthonyfieroni added inline comments. INLINE COMMENTS > ndavis wrote in KoUnit.h:59-60 > Was it already like that when I made the comment? When I export an SVG, it's > proportioned like the DPI was 72 if I open it in Gwenview or Inkscape. 48x48 > becomes 36x36. Are you using HiDPI resolution?

D15111: [KoUnit] Let's show pixel units

anthonyfieroni added inline comments. INLINE COMMENTS > KoUnit.h:59-60 > #define CC_TO_POINT(cc) qreal((cc)*12.840103) > +#define POINT_TO_PX(cc) qreal((cc)*96.0/72.0) > +#define PX_TO_POINT(px) qreal((px)*72.0/96.0) > /** @ndavis, DPI is 96, it's not configurable for now. REPOSITORY R8 Cal

D15111: [KoUnit] Let's show pixel units

anthonyfieroni updated this revision to Diff 82815. anthonyfieroni added reviewers: ndavis, VDG. anthonyfieroni added a comment. Rebase on master REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15111?vs=41190&id=82815 REVISION DETAIL https://phabricator.kd

D29542: Refactor canvas event handling

anthonyfieroni added a comment. Thank you, i should wait ship it, but just got Dag comment as it is. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D29542 To: anthonyfieroni, boemann, danders, #calligra:_3.0 Cc: leinir, Calligra-Devel-list, davidllewellynjones, dcalis

D29542: Refactor canvas event handling

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:2258d76ae064: Fix canvas event handling (authored by anthonyfieroni). CHANGED PRIOR TO COMMIT https://phabricator.kde.

D29542: Refactor canvas event handling

anthonyfieroni added a comment. Seems fine, i'll push pageapp/flake changes as part of this review in 3.2 branch and master, refactoring main window in separate commit master only. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D29542 To: anthonyfieroni, boemann, dan

D29542: Refactor canvas event handling

anthonyfieroni updated this revision to Diff 82646. anthonyfieroni added a comment. @danders i saw you patch on my email. `d->viewportWidget->canvas()->removeEventFilter(this);` fixes the issue but i still prefer all of refactoring code. Please test on all components does not have regression

D29542: Refactor canvas event handling

anthonyfieroni retitled this revision from "Refactor MainWindow view" to "Refactor canvas event handling". REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D29542 To: anthonyfieroni, boemann, danders, #calligra:_3.0 Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, o

D29542: Refactor MainWindow view

anthonyfieroni added a comment. We should call `removeEventFilter` or found exactly why signal is emitted in destructor. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D29542 To: anthonyfieroni, boemann, danders, #calligra:_3.0 Cc: Calligra-Devel-list, davidllewellyn

D29542: Refactor MainWindow view

anthonyfieroni added a comment. `d->rootPart->createView(doc, this);` Creates the view which parent is main window. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D29542 To: anthonyfieroni, boemann, danders, #calligra:_3.0 Cc: Calligra-Devel-list, davidllewellynjones

D29542: Refactor MainWindow view

anthonyfieroni updated this revision to Diff 82337. anthonyfieroni added a comment. Add more context REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29542?vs=82301&id=82337 REVISION DETAIL https://phabricator.kde.org/D29542 AFFECTED FILES libs/main/KoMa

D29542: Refactor MainWindow view

anthonyfieroni created this revision. anthonyfieroni added reviewers: boemann, danders, Calligra: 3.0. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. anthonyfieroni requested review of this revision. REVISION SUMMARY CCBUG: 421083 It looks like there

D29242: WIP: redesign sidebar

anthonyfieroni added inline comments. INLINE COMMENTS > calligrawords.rc:2 > > > Increase version. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D29242 To: ognarb, boemann Cc: anthonyfieroni, boemann, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb,

D25714: [WIP]: Port away from deprecated KHtml

anthonyfieroni added a comment. Is this still WIP, it looks good, can we proceed? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25714 To: ognarb, #calligra:_3.0 Cc: anthonyfieroni, danders, leinir, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise

D25714: [WIP]: Port away from deprecated KHtml

anthonyfieroni added a comment. Is this still WIP, it looks good, can we proceed? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25714 To: ognarb, #calligra:_3.0 Cc: anthonyfieroni, danders, leinir, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise

D29242: WIP: redesign sidebar

anthonyfieroni added a comment. > The idea is to remove some of the configuration possibility: for example only allowing the KoModeBoxDocker to be a left or right sidebar. (putting at the top and bottom was completely broken anyway so I don't think many people did it). I think it can be

D29242: WIP: redesign sidebar

anthonyfieroni added a comment. I don't know everyone wants tools to be above edit window. That's pretty old stile when resolution was 4:3 that's why they was arranged one above another. But i agree that it should be flexible to be horizontal or vertical as needed. INLINE COMMENTS > KoModeB

T12815: Create Calligra Framework by separating out applications and libraries

anthonyfieroni added a comment. @leinir correct me if i'm wrong, but this can be beneficial if some of Calligra Suite want to have different release circle, like Krita before. Or you want Krita to returns back to Calligra framework? TASK DETAIL https://phabricator.kde.org/T12815 To: antho

D25714: [WIP]: Port away from deprecated KHtml

anthonyfieroni added inline comments. INLINE COMMENTS > htmlimport.h:58-59 > KoFilter::ConversionStatus loadUrl(const QUrl &url); > -void parseNode(DOM::Node n); > -bool parseTag(DOM::Element e); > +void parseNode(QDomNode n); > +bool parseTag(QDomElement e); > bool crea

D15428: [textlayout] Don't enter infinite loop when table is misfit

This revision was automatically updated to reflect the committed changes. Closed by commit R8:76cfa3b654b2: [textlayout] Don't enter infinite loop when table is misfit (authored by anthonyfieroni). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15428?vs=41564&i

D26050: Fix build with poppler 82

anthonyfieroni added a comment. I'm pretty sure Krita devs think about when they split application out of Calligra repo and make its own copy of libs, flakes, etc. So beneficial of splitting libs in their own release plan will be for all applications. That will a huge work pretty underrated

D26050: Fix build with poppler 82

anthonyfieroni added a comment. Maybe we can drop 62, but not 72. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26050 To: tcanabrava, #calligra:_3.0 Cc: anthonyfieroni, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D25254: Remove flow, not needed since karbon can do it all

anthonyfieroni added a comment. I'm fine with your decision, just i don't want to be the only person accepted such a change. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25254 To: danders, anthonyfieroni, #calligra:_3.0 Cc: boemann, Calligra-Devel-list, davidllewe

D25254: Remove flow, not needed since karbon can do it all

anthonyfieroni added a reviewer: Calligra: 3.0. anthonyfieroni added a comment. Let's other members leave their opinion as well. I don't want to have surprised people by removing Flow. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25254 To: danders, anthonyfieroni,

D25254: Remove flow, not needed since karbon can do it all

anthonyfieroni added a comment. I'm unsure about that, if some people still prefer using Flow will make this change superfluous. I can't make decision about this changes, if you think it should be done - i'm fine. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25254

D24852: Remove list style from headings

anthonyfieroni added a comment. +1, i'm ok with that. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24852 To: akomakhin, pvuorela, #calligra:_3.0, boemann Cc: anthonyfieroni, boemann, Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever

D25214: Karbon image filter: Add multipage support

anthonyfieroni accepted this revision. anthonyfieroni added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ImageExport.cpp:49 > #include > +#include > Unneeded ? REPOSITORY R8 Calligra BRANCH multipage_image_danders REVISION DETAIL https://phabr

D25171: PDF Import: Add multipage support

anthonyfieroni accepted this revision. anthonyfieroni added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > Pdf2OdgImport.cpp:130 > +globalParams = 0; > +// m_chain->setOutputFile(QString()); > +return status; Remove that line REPOSITORY R8 Call

D24852: Remove list style from headings

anthonyfieroni added a comment. I think `add` should be conditional. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24852 To: akomakhin, pvuorela, #calligra:_3.0, boemann Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D25008: Add XLSX spreadsheets import optimisations for small/readonly devices

anthonyfieroni added inline comments. INLINE COMMENTS > CMakeLists.txt:124-129 > +if (MSOOXML_MAX_SPREADSHEET_COLS) > +add_definitions( > -DMSOOXML_MAX_SPREADSHEET_COLS=${MSOOXML_MAX_SPREADSHEET_COLS} ) > +endif() > +if (MSOOXML_MAX_SPREADSHEET_COLS) > +add_definitions( > -DMSOOXML_MAX_

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni added a comment. Let's commit this, it's fair small patch but it covers some unwanted crashes. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandeno

D23617: [gemini] Remove "template://" scheme from file name

This revision was automatically updated to reflect the committed changes. Closed by commit R8:f8717365d240: [gemini] Fix loading of templates and files creation (authored by anthonyfieroni). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23617?vs=65352&id=65559

D23327: [Gemini] Clarify deletion of document

This revision was automatically updated to reflect the committed changes. Closed by commit R8:7743486fd5b6: [gemini] Clarify touch <-> desktop view switch (authored by anthonyfieroni). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23327?vs=65066&id=65560#toc REPOSITORY R8 Calligra CH

D23617: [gemini] Remove "template://" scheme from file name

anthonyfieroni updated this revision to Diff 65352. anthonyfieroni added a comment. I can't test, but it should be fine. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23617?vs=65255&id=65352 REVISION DETAIL https://phabricator.kde.org/D23617 AFFECTED FI

D23617: [gemini] Remove "template://" scheme from file name

anthonyfieroni updated this revision to Diff 65255. anthonyfieroni added a comment. Test plan: 1. Open existing document -> works 2. Open template document -> works 3. Create new document -> works REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23617

D23617: [gemini] Remove "template://" scheme from file name

anthonyfieroni added a comment. That makes sense but none handle that schemes or should be responsible for that? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D23617 To: anthonyfieroni, #calligra:_3.0, leinir Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D23617: [gemini] Remove "template://" scheme from file name

anthonyfieroni created this revision. anthonyfieroni added reviewers: Calligra: 3.0, leinir. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. anthonyfieroni requested review of this revision. REVISION SUMMARY I don't know why they are added but it cannot be

D23327: [Gemini] Clarify deletion of document

anthonyfieroni updated this revision to Diff 65066. anthonyfieroni added a comment. Fix a bunch of crashes :) Test plan: 1. Open calligra gemini 2. Open word file 3.1. File menu -> Quit (if you make changes it ask you to save or not) 3.2. Click close button -> Quit (same beha

D23327: [Gemini] Clarify deletion of document

anthonyfieroni created this revision. anthonyfieroni added reviewers: Calligra: 3.0, boemann, danders. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. anthonyfieroni requested review of this revision. REVISION SUMMARY When you open Gemini in desktop and clo

D20400: Karbon: Enable multi page capability

anthonyfieroni accepted this revision. anthonyfieroni added a comment. This revision is now accepted and ready to land. I saw filters does not compile when it compile only Karbon, i should correct that, but i have much time now. REPOSITORY R8 Calligra BRANCH karbon_multipage_danders REV

D20400: Karbon: Enable multi page capability

anthonyfieroni added a comment. In D20400#475648 , @danders wrote: > In D20400#475477 , @anthonyfieroni wrote: > > > Now we have insert page, but we don't exports them :) If you think that's ok for

D20400: Karbon: Enable multi page capability

anthonyfieroni added a comment. Now we have insert page, but we don't exports them :) If you think that's ok for now go for it. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D20400 To: danders, anthonyfieroni Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vanden

D20400: Karbon: Enable multi page capability

anthonyfieroni added a comment. Apparently it has a problem, when we compile only Karbon, as i done now, KoPAView is in pageapp, which is not compile-able in Karbon, right? Full cmake command cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_INSTALL_LIBDIR=lib -DKDE_INSTALL_PLUGINDIR=/us

D20400: Karbon: Enable multi page capability

anthonyfieroni added a comment. Someone test it, code wise looks good, i plan to test it soon. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D20400 To: danders, anthonyfieroni Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19327: Karbon: Enable multi page capability

anthonyfieroni abandoned this revision. anthonyfieroni added a comment. In flavor of D20400 REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19327 To: anthonyfieroni, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

anthonyfieroni abandoned this revision. anthonyfieroni added a comment. In flavor of D20400 REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19216 To: anthonyfieroni, danders Cc: boemann, rjvbb, Calligra-Devel-list, dcaliste, cochis

D19327: Karbon: Enable multi page capability

anthonyfieroni commandeered this revision. anthonyfieroni edited reviewers, added: danders; removed: anthonyfieroni. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19327 To: anthonyfieroni, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

anthonyfieroni commandeered this revision. anthonyfieroni edited reviewers, added: danders; removed: anthonyfieroni. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19216 To: anthonyfieroni, danders Cc: boemann, rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D11971: Use same keyword separator for read and write

anthonyfieroni added a comment. Ping this looks sane, anyone ? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D11971 To: michaelh, #calligra:_3.0, leinir, danders Cc: Calligra-Devel-list, anthonyfieroni, dcaliste, cochise, vandenoever

D19327: Karbon: Enable multi page capability

anthonyfieroni added inline comments. INLINE COMMENTS > KarbonView.cpp:429-433 > +// TODO: It is not obvious how this is best implemented when importing > multipage docs > +// Append pages? > +// Append layers to existing pages? > +// Add shapes to active page? > +// etc? Ca

D19216: Karbon: Enable multi page capability

anthonyfieroni added inline comments. INLINE COMMENTS > KarbonDocument.h:100-109 > +// TODO: Start using or remove > /// Returns the documents data centers > QMap dataCenterMap() const; > > +// TODO: Start using or remove > /// Sets the data centers to be used by this doc

D19216: Karbon: Enable multi page capability

anthonyfieroni added inline comments. INLINE COMMENTS > KarbonConfigInterfacePage.cpp:73-90 > +// TODO or move or remove? > +// m_recentFiles = new QSpinBox(tmpQGroupBox); > +// m_recentFiles->setRange(1, 20); > +// m_recentFiles->setSingleStep(1); > +// m_recentFiles->setValue(m_

D18963: Improve KoModeBox display in horizontal Mode

anthonyfieroni added a comment. It's good to +1 REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18963 To: ognarb, #calligra:_3.0, #vdg Cc: anthonyfieroni, abetts, ngraham, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

anthonyfieroni added a comment. In D18466#402362 , @niccolove wrote: > This solution is Qt <5.12 friendly What you mean? INLINE COMMENTS > KoApplication.h:154 > friend class ResetStarting; > +QString pdfFileName; > }; It shou

D18466: Fixed calligra crashing when opening remote document

anthonyfieroni added a comment. So just don't call slotFilePrint connect loadCompleted to slotFilePrint. When openDocumentInternal downloads the document it fires signal of finish, just connect to slot of opened it. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18

D18466: Fixed calligra crashing when opening remote document

anthonyfieroni added a comment. In D18466#399471 , @danders wrote: > Probably we need to start printing in a slot connected to KoMainWindow::loadCompleted() instead. > And to be safe, we also need to handle loadCanceled(). I agree with

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni added a comment. In facts that's 2 crashes, first one in ascent, second one misfit. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni added a comment. @danders you can commandeer this revision to update diff. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni added a comment. Yep, it's look like same approach to mine, did you try mine or it's not correct in all cases? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste,

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni added a comment. @danders that was one of my previous approach. Let @boemann tolds us which is correct one. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, co

D16784: Remove whitespace created by D16721

anthonyfieroni abandoned this revision. anthonyfieroni added a comment. Ok, let not make whitespace commit. @ognarb just be more precise next time. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16784 To: anthonyfieroni, ognarb Cc: Calligra-Devel-list, dcaliste, coch

D16784: Remove whitespace created by D16721

anthonyfieroni commandeered this revision. anthonyfieroni edited reviewers, added: ognarb; removed: anthonyfieroni. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16784 To: anthonyfieroni, ognarb Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni added a comment. Ping REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

anthonyfieroni added a comment. In D16721#356863 , @bcooksley wrote: > Force pushes are generally reserved for pretty serious issues, couldn't the whitespace be corrected with a follow up commit to remove it? I really prefer to not have

D16784: Remove whitespace created by D16721

anthonyfieroni added a comment. But it's not only that https://phabricator.kde.org/R8:a7ee6f871af225fd5edc9458ee183604fabadc8a Notice ~SectionLayout() and many others, you should use settings that trim whitespaces on file save. In Kate -> settings -> open/save -> Remove trailing spaces ->

D16721: Use Krita toolbar in Karbon

anthonyfieroni added a subscriber: bcooksley. anthonyfieroni added a comment. Please contact @bcooksley to remote all white space changes from you commit. Please be more precise when you commit, you introduce even more white spaces rather than to remove them. > That do you recommend as a

D16721: Use Krita toolbar in Karbon

anthonyfieroni accepted this revision. anthonyfieroni added a comment. This revision is now accepted and ready to land. Please, remove all white space changes before commit. It will be better if you test the patch some time without crash or other downsides. If you notice something wrong write

D16721: Use Krita toolbar in Karbon

anthonyfieroni added a comment. Can you add screenshots of horizontal and vertical version, add it to test, just to have how it looks. I see some gestures that i cannot test, did you can, touchscreen, tablet or something that this code works :) INLINE COMMENTS > ognarb wrote in KoToolBoxDoc

D16721: Use Krita toolbar in Karbon

anthonyfieroni added inline comments. INLINE COMMENTS > KoToolBoxLayout_p.h:310 > +private: > +int doLayout(const QRect &rect, bool notDryRun) const > { Also rename rect to size and QRect to QSize. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ogna

D16721: Use Krita toolbar in Karbon

anthonyfieroni added a comment. Can you test my suggestions, it's looks good to me. INLINE COMMENTS > ognarb wrote in KoToolBoxDocker.cpp:39 > I found out that this QLabel is, it's the small draggable zone at the top of > the docker. Actual it's still a bit buggy in krita and karbon F6397172

D16721: Use Krita toolbar in Karbon

anthonyfieroni added a comment. Config, if it's not set explicitly, + "rc" https://api.kde.org/frameworks/kconfig/html/kconfig_8cpp_source.html#l00607 REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #krita, #calligra:_3.0 Cc: anthonyfieroni, Callig

D16721: Use Krita toolbar in Karbon

anthonyfieroni added inline comments. INLINE COMMENTS > KoKineticScroller.cpp:28 > +{ > +KConfigGroup config = KSharedConfig::openConfig()->group(""); > +int sensitivity = config.readEntry("KineticScrollingSensitivity", 75); Let's have some name, KoKineticScroller or something. I also no

D16721: Use Krita toolbar in Karbon

anthonyfieroni added a comment. Return QObjects, if you have problems copy linker output here. INLINE COMMENTS > KoToolBox.cpp:138 > button->setIconSize(QSize(iconSize, iconSize)); > -foreach (Section *section, d->sections) { > +foreach (Section *section, d->sections.values())

D16721: Use Krita toolbar in Karbon

anthonyfieroni added a comment. > I'm adding Krita as reviewer, because Karbon is unmaintained and I hope someone at Krita as some experience with the toolbox I'm the maintainer of Karbon, for now. Please revert foreach -> Q_FOREACH changes, it should be done in separate patch. Clea

D16367: EnhancedPathShape: Shape is moved/resized on save/load

anthonyfieroni added a comment. When i investigate to find out why it's saved square not rectangle i suspect that code, but i'm still not absolutely sure that it's wrong. Maybe @boemann knows better. If so can we remove m_viewBound as well? REPOSITORY R8 Calligra REVISION DETAIL https:/

D16289: Karbon: Add Anthony as maintainer and remove unmaintained

anthonyfieroni accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra BRANCH karbon_danders REVISION DETAIL https://phabricator.kde.org/D16289 To: danders, anthonyfieroni Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16127: Annotation: Block adding comment to an annotation shape

anthonyfieroni added a comment. Looks good to me +1 REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16127 To: danders, boemann, anthonyfieroni Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni added a comment. Let's make some fix about that. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16127: Annotation: Block adding comment to an annotation shape

anthonyfieroni added inline comments. INLINE COMMENTS > TextTool.cpp:2036 > +} > +m_textShape = textShape; > +} If it has more than one shape that not satisfy above condition (2032) m_textShape will point to last one, not to first as current behavior. So maybe

D15053: Consistently use qreal in libs/pigment

anthonyfieroni added a subscriber: boemann. anthonyfieroni added a comment. I'm OK with it +1, @danders or @boemann should accept it. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15053 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: boemann, anthonyfieroni, Calli

D15775: Make the item background color and page cache properties available from View component

anthonyfieroni added a comment. Also can you add parentheses over single line code and if you know better way to get impl() without duplicate calls will be great :) INLINE COMMENTS > View.cpp:160 > canvas->setGeometry(0, 0, q->width(), q->height()); > + > static_cast(docume

D15617: Move away from kdebug and kdelibs4 in filter/sheets

anthonyfieroni added a comment. This is old practice, please make a logging category -> https://doc.qt.io/qt-5/qloggingcategory.html REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15617 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: anthonyfieroni, Calligra-Devel

D15412: [filters] Extend table lifetime

This revision was automatically updated to reflect the committed changes. Closed by commit R8:cb7ff65d2e7c: Extend table lifetime (authored by anthonyfieroni). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15412?vs=41552&id=41841 REVISION DETAIL https://pha

D15403: {Style] Default sheets to white background

This revision was automatically updated to reflect the committed changes. Closed by commit R8:e5fc394f4a54: [Style] Default sheets to white background (authored by anthonyfieroni). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15403?vs=41338&id=41840 REVISION

D12839: Get Calligra to compile with Qt 5.11

anthonyfieroni closed this revision. anthonyfieroni added a comment. It was merged. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D12839 To: nerdopolist, Calligra-Devel-list, #calligra:_3.0, staniek Cc: anthonyfieroni, #calligra:_3.0, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni added a comment. Any other ideas for special handling of headerRows == 0? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni updated this revision to Diff 41564. anthonyfieroni added a comment. Another try: Don't mark table as misfit when it does not have header rows REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15428?vs=41418&id=41564 REVISION DETAIL https://

D15412: [filters] Extend table lifetime

anthonyfieroni updated this revision to Diff 41552. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15412?vs=41377&id=41552 REVISION DETAIL https://phabricator.kde.org/D15412 AFFECTED FILES filters/libmsooxml/MsooXmlDrawingReaderTableImpl.h filters/libmso

D15412: [filters] Extend table lifetime

anthonyfieroni added a comment. It can be allocated only in read_tbl but as you can see in bug report, use-after-free is very common to happen. INLINE COMMENTS > staniek wrote in MsooXmlDrawingReaderTableMethods.h:40 > This is declaration-only header, so better no, otherwise allocation of a

D15412: [filters] Extend table lifetime

anthonyfieroni added a comment. Ping on this, did you try it? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15412 To: anthonyfieroni, danders, boemann, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni added a comment. Something as if (d->headerRows) { cursor->row = 0; } REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni added a comment. It does not work, as you can see it overriding here https://phabricator.kde.org/source/calligra/browse/master/libs/textlayout/KoTextLayoutArea.cpp$571 so that's why i want to set it true before loop. REPOSITORY R8 Calligra REVISION DETAIL https://phabrica

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni added a comment. In D15428#324451 , @boemann wrote: > One reason why this might fail is if virginpage becomes false when we add the table headerrow (if we can fix this and that doesn't have other ill effect then I would prefer suc

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni added inline comments. INLINE COMMENTS > boemann wrote in KoTextLayoutTableArea.cpp:464 > nah this is too aggressive. > There are definitely cases where setting to 0 is the correct thing to do. > There might be some times we enter an infinite loop yes, but we need to catch > this

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni updated this revision to Diff 41418. anthonyfieroni added a comment. Initialize labelYOffset even layout line is not valid REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15428?vs=41409&id=41418 REVISION DETAIL https://phabricator.kde.org/D1

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni edited the summary of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni retitled this revision from "[textlayout] Don't enter infinite loop when table are misfit" to "[textlayout] Don't enter infinite loop when table is misfit". REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders,

  1   2   >