D25035: Fix incorrect conditional styling of spreadsheet cells.

denexter created this revision. denexter added a reviewer: pvuorela. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. denexter requested review of this revision. REVISION SUMMARY Include the conditions default style when comparing equality and calculating t

D25034: Fix decoding of strings with wingdings/symbol characters in excel TxO records.

denexter created this revision. denexter added a reviewer: pvuorela. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. denexter requested review of this revision. REVISION SUMMARY These will have the high bit set which will make them appear to be non-printab

D25033: Extract images from excel files which omit the FtCF entry.

denexter created this revision. denexter added a reviewer: pvuorela. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. denexter requested review of this revision. REVISION SUMMARY The specification says it and the flags entry must exist if the object type is

D25032: Read xlsx drawing dimensions from the xdr:ext element if available.

denexter created this revision. denexter added a reviewer: pvuorela. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. denexter requested review of this revision. REVISION SUMMARY Read the size of a single cell anchored drawing from the xdr:ext element. The

D25031: Don't allow an unrecognized child element to block loading of a shape plugin.

denexter created this revision. denexter added a reviewer: pvuorela. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. denexter requested review of this revision. REVISION SUMMARY If an object element has child elements but no shape plugin can be resolved fo

D24943: Better charset, unicode and image support for RTF files

denexter added inline comments. INLINE COMMENTS > pvuorela wrote in PictDestination.cpp:54 > Was Andrew's part, but I think file itself should contain the geometry and > goals are handled here as optional, i.e. if not set will be read from the > file. I think picw and pich are source sizes an

D25008: Add XLSX spreadsheets import optimisations for small/readonly devices

dcaliste added a comment. @davidllewellynjones, I hadn't time yet to test the patch, but the idea and implementation is already looking great in my opinion. Maybe, just one remark after looking at the proposed additions: not saving the formale, but the values should not be named read-only. I

D24943: Better charset, unicode and image support for RTF files

pvuorela updated this revision to Diff 6. pvuorela added a comment. Whitespace adjustments REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24943?vs=68746&id=6 BRANCH unicode REVISION DETAIL https://phabricator.kde.org/D24943 AFFECTED FILES fi

D25008: Add XLSX spreadsheets import optimisations for small/readonly devices

davidllewellynjones created this revision. davidllewellynjones added reviewers: Calligra: 3.0, pvuorela, dcaliste. davidllewellynjones added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. davidllewellynjones requested review of this revision. REVISION SUMMARY Loading l

D24943: Better charset, unicode and image support for RTF files

pvuorela added inline comments. INLINE COMMENTS > davidllewellynjones wrote in DocumentDestination.cpp:125 > A minor issue, but the spacing around the brackets here doesn't match the > surrounding code. Sure. > davidllewellynjones wrote in PictDestination.cpp:46 > The spec mentions `\wbitmap`

D24943: Better charset, unicode and image support for RTF files

davidllewellynjones accepted this revision. davidllewellynjones added a comment. This revision is now accepted and ready to land. I've made some suggestions and have a couple of queries, but they're all very minor. INLINE COMMENTS > DocumentDestination.cpp:125 > + m_charactersToSkip

D24831: Migrate csv plugins from kdebug to qdebug

This revision was automatically updated to reflect the committed changes. Closed by commit R8:b17f993c3b20: Migrate csv plugins from kdebug to qdebug (authored by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24831?vs=68438&id=68884 REVISION DETAIL

D24831: Migrate csv plugins from kdebug to qdebug

dcaliste accepted this revision. dcaliste added a comment. This revision is now accepted and ready to land. The patch looks fine, thank you. REPOSITORY R8 Calligra BRANCH csv_qdebug (branched from master) REVISION DETAIL https://phabricator.kde.org/D24831 To: pvuorela, dcaliste, leini

D24761: Asign correct column width when importing XLS file

dcaliste added a comment. Well, after reading the difference between the logical and physical DPI values: https://stackoverflow.com/questions/16561879/what-is-the-difference-between-logicaldpix-and-physicaldpix-in-qt (see the first answer), using the logical value is consistent with the hard

D24761: Asign correct column width when importing XLS file

pvuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24761 To: davidllewellynjones, #calligra:_3.0, pvuorela Cc: davidllewellynjones, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19759: Remove unsupported attributes from QGraphicsWidgets

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:0e9d73d8ce1e: Remove unsupported attributes from QGraphicsWidgets (authored by pvuorela). REPOSITORY R8 Calligra CHAN