D19912: Implement logging category for rtf-qt

2019-03-20 Thread Dag Andersen
danders added a comment. In D19912#435067 , @pvuorela wrote: > In D19912#435058 , @danders wrote: > > > Strange indents, could you fix it? > > > That's what I commented on the summary. On some

D19912: Implement logging category for rtf-qt

2019-03-20 Thread Pekka Vuorela
pvuorela added a comment. In D19912#435058 , @danders wrote: > Strange indents, could you fix it? That's what I commented on the summary. On some parts rtf-qt uses plain spaces for indentation and those parts look good. Then in the same f

D19912: Implement logging category for rtf-qt

2019-03-20 Thread Dag Andersen
danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. Strange indents, could you fix it? Otherwise ok. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19912 To: pvuorela, danders Cc: danders, Calligra-Devel-list, d

D19912: Implement logging category for rtf-qt

2019-03-20 Thread Pekka Vuorela
pvuorela created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. pvuorela requested review of this revision. REVISION SUMMARY To be noted that indentation looks a bit off, rtf-qt has a mixed bag of hard tabs and spaces, used only spaces here

D19884: Avoid deprecated QAbstractItemModel::reset()

2019-03-20 Thread Dag Andersen
danders added inline comments. INLINE COMMENTS > dcaliste wrote in TextDocumentStructureModel.cpp:308 > I did the same changes in https://phabricator.kde.org/D15102 at another place > and I put the begin and end at the start and end of the routine, like you > did. But I remember that I got revi

D19885: Implement logging category for excel plugins

2019-03-20 Thread Dag Andersen
danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19885 To: pvuorela, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19884: Avoid deprecated QAbstractItemModel::reset()

2019-03-20 Thread Pekka Vuorela
pvuorela added inline comments. INLINE COMMENTS > dcaliste wrote in TextDocumentStructureModel.cpp:308 > I did the same changes in https://phabricator.kde.org/D15102 at another place > and I put the begin and end at the start and end of the routine, like you > did. But I remember that I got rev