D18466: Fixed calligra crashing when opening remote document

niccolove updated this revision to Diff 50557. niccolove added a comment. - Removed connection between job and exiting; added todo REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18466?vs=50552&id=50557 BRANCH print-remote-files (branched from master) REV

D18466: Fixed calligra crashing when opening remote document

danders added a comment. Yeah, well there are some half done designs in here :( The benchmark just does not work with remote files. Don't know if it should or if it should be blocked. Let's leave it for now. If you do not specify a pdf filename, it will use the same name as in the l

D18466: Fixed calligra crashing when opening remote document

niccolove marked an inline comment as done. niccolove added a comment. I have some doubts: - Anything related to "and exiting" does not seem to work. mainWindow->slotFileQuit() does not seem working. - --benchmark-loading-show-window should also exit using mainWindow->slotFileQuit(),

D18466: Fixed calligra crashing when opening remote document

niccolove updated this revision to Diff 50552. niccolove added a comment. - Moved QString pdfFileName to KoApplicationPrivate REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18466?vs=50551&id=50552 BRANCH print-remote-files (branched from master) REVISION

D18466: Fixed calligra crashing when opening remote document

danders added a comment. Regarding the completed slot, the doc says: --print Only print and exit --export-pdf Only export to PDF and exit To exit, you need to know when all jobs have finished, so if some failed you need to track that. Also, the

D18466: Fixed calligra crashing when opening remote document

niccolove added a comment. My previous commit used a "still alive argument" as boemann called it that was only introduced in Qt 5.12. Now it should work even with older versions. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove, danders Cc: anthony

D18466: Fixed calligra crashing when opening remote document

anthonyfieroni added a comment. In D18466#402362 , @niccolove wrote: > This solution is Qt <5.12 friendly What you mean? INLINE COMMENTS > KoApplication.h:154 > friend class ResetStarting; > +QString pdfFileName; > }; It shou

D18466: Fixed calligra crashing when opening remote document

niccolove added a comment. This solution is Qt <5.12 friendly REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove, danders Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

niccolove updated this revision to Diff 50551. niccolove added a comment. - Adding pdf filename as propriety of KoApplication REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18466?vs=50542&id=50551 BRANCH print-remote-files (branched from master) REVISION

D18466: Fixed calligra crashing when opening remote document

boemann added a comment. regarding the lambda connection - nice to see that you use the version with a "still alive" argument - but I fear this requires a qt version higher than what we currently support - could you please check REPOSITORY R8 Calligra REVISION DETAIL https://phabricat

D18466: Fixed calligra crashing when opening remote document

niccolove added a comment. What have I Done: - Added slots in KoApplication to manage pdf and print. Cancel is already KoMainWindow::slotLoadCanceled with an error popup, what should a KoApplication::slotLoadCanceled do? - Added connection for pdf print and moved it before document ope

D18466: Fixed calligra crashing when opening remote document

niccolove updated this revision to Diff 50542. niccolove added a comment. - Added slots in KoApplication to handle pdf and print. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18466?vs=50520&id=50542 BRANCH print-remote-files (branched from master) REVI