D16127: Annotation: Block adding comment to an annotation shape

2018-10-11 Thread Dag Andersen
danders marked an inline comment as done. danders added a comment. No, it should not be possible to activate a tool without a shape. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16127 To: danders, boemann, anthonyfieroni Cc: Calligra-Devel-list, dcaliste, cochise,

D16127: Annotation: Block adding comment to an annotation shape

2018-10-11 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > TextTool.cpp:2036 > +} > +m_textShape = textShape; > +} If it has more than one shape that not satisfy above condition (2032) m_textShape will point to last one, not to first as current behavior. So maybe

D16127: Annotation: Block adding comment to an annotation shape

2018-10-11 Thread Dag Andersen
danders created this revision. danders added reviewers: boemann, anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY To reproduce crash: 1. Add a text shape 2. Add an annotation