vandenoever closed this revision.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D6844
To: vandenoever, #calligra:_3.0, Calligra-Devel-list, boemann
Cc: boemann, vandenoever
vandenoever abandoned this revision.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D6843
To: vandenoever, #calligra:_3.0, Calligra-Devel-list
Cc: vandenoever
boemann accepted this revision.
boemann added a comment.
This revision is now accepted and ready to land.
No need to review these very simple changes - just make sure you test before
pushing
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D6844
To: vandenoever, #calli
vandenoever created this revision.
vandenoever added a project: Calligra: 3.0.
REVISION SUMMARY
- QByteArray pass was not used
- data() on a temporary detaches it, constData does not
- Q_OBJECT in StoreDropTest is not needed, but silences clazy
TEST PLAN
storedroptest still works and the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130196/#review103464
---
Ship it!
Ship It!
- Camilla Boemann
On July 22, 2017,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130196/
---
(Updated jul 22, 2017, 7:50 p.m.)
Status
--
This change has been dis
vandenoever created this revision.
vandenoever added a project: Calligra: 3.0.
REVISION SUMMARY
Without the seed parameter, the default qHash for QPair is used.
The seed argument in qHash was introduced in Qt 5.0. The qHash for
KoXmlStringPair did not have it and hence it was an unused funct
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130196/
---
Review request for Calligra.
Repository: calligra
Description
---
