Re: What's new in KReport & KProperty & Predicate

2015-05-13 Thread Jaroslaw Staniek
On 13 May 2015 at 22:33, Adam Pigg wrote: > items plugged in http://imgur.com/Dt4FIV3 > Power is ours!!!11 -- regards, Jaroslaw Staniek KDE: : A world-wide network of software engineers, artists, writers, translators : and facilitators committed to Free Software development - http://kde.org C

Re: Review Request 123670: Less complicated look up of template locations, fix referencing templates in Author & Krita Sketch/Gemini

2015-05-13 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123670/ --- (Updated May 13, 2015, 8:45 p.m.) Status -- This change has been mar

Re: What's new in KReport & KProperty & Predicate

2015-05-13 Thread Adam Pigg
items plugged in http://imgur.com/Dt4FIV3 On Wed, May 13, 2015 at 8:33 PM, Jaroslaw Staniek wrote: > On 13 May 2015 at 21:21, Adam Pigg wrote: > > so, could you be mixing up 2 qt5 versions? > > I don't think: > - I am not building qt5, and have only one packaged version installed. > - I am buil

Re: What's new in KReport & KProperty & Predicate

2015-05-13 Thread Jaroslaw Staniek
On 13 May 2015 at 21:21, Adam Pigg wrote: > so, could you be mixing up 2 qt5 versions? I don't think: - I am not building qt5, and have only one packaged version installed. - I am building kf5, and have no other version installed. I'll be trying to disable plugin that crashes, as a quick fix. >

Re: What's new in KReport & KProperty & Predicate

2015-05-13 Thread Adam Pigg
so, could you be mixing up 2 qt5 versions? On Wed, May 13, 2015 at 6:53 PM, Jaroslaw Staniek wrote: > On 13 May 2015 at 00:25, Jaroslaw Staniek wrote: > > Ok, > > @Adam please check the 'integration' branch: > > > > ASSERT failure in QList::operator[]: "index out of range", file > > /usr/includ

Re: Review Request 123670: Less complicated look up of template locations, fix referencing templates in Author & Krita Sketch/Gemini

2015-05-13 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123670/#review80316 --- Ship it! Yes, it makes a lot of sense. - Boudewijn Rempt O

Re: What's new in KReport & KProperty & Predicate

2015-05-13 Thread Jaroslaw Staniek
On 13 May 2015 at 00:25, Jaroslaw Staniek wrote: > Ok, > @Adam please check the 'integration' branch: > > ASSERT failure in QList::operator[]: "index out of range", file > /usr/include/qt5/QtCore/qlist.h, line 486 > Aborted > > Compared to that, 93356498ab6eb works OK. Details look like https://

Re: Review Request 123764: Fix conflict between context menu and toggle action on icons in layers widget

2015-05-13 Thread Victor Wåhlström
> On May 13, 2015, 7:51 a.m., Boudewijn Rempt wrote: > > Thanks! As you said, we're sloppy checking for what particular mouse events > > mean, but I wonder though whether checking for QEvent::ContextMenu in bool > > KisDocumentSectionView::viewportEvent(QEvent *e) wouldn't help? If that could

Re: Review Request 123764: Fix conflict between context menu and toggle action on icons in layers widget

2015-05-13 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123764/#review80279 --- Thanks! As you said, we're sloppy checking for what particular