----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123764/#review80279 -----------------------------------------------------------
Thanks! As you said, we're sloppy checking for what particular mouse events mean, but I wonder though whether checking for QEvent::ContextMenu in bool KisDocumentSectionView::viewportEvent(QEvent *e) wouldn't help? - Boudewijn Rempt On May 13, 2015, 3:18 a.m., Victor Wåhlström wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123764/ > ----------------------------------------------------------- > > (Updated May 13, 2015, 3:18 a.m.) > > > Review request for Calligra and Boudewijn Rempt. > > > Bugs: 347541 > http://bugs.kde.org/show_bug.cgi?id=347541 > > > Repository: calligra > > > Description > ------- > > This patch limits mouse click interaction with icons to left mouse button. > > Note: This fix assumes that context menu events are triggered via right mouse > button. This is in theory OS specific, but it looks like other code is > already making this assumption. > > > Diffs > ----- > > krita/ui/KisDocumentSectionDelegate.cpp 2efde33 > > Diff: https://git.reviewboard.kde.org/r/123764/diff/ > > > Testing > ------- > > I haven't done extensive testing outside of the layers widget. Worst case > it'll disable middle mouse button and right mouse button as alternatives for > clicking on icons, which should be fine. > > Context menu events are handled elsewhere and still works as expected. > > > Thanks, > > Victor Wåhlström > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
