Review Request 123392: Better do not use "appdata" with KStandardDirs in plugins/parts

2015-04-16 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123392/ --- Review request for Calligra, Tomas Mecir and Boudewijn Rempt. Repository:

Re: Review Request 123391: Remove broken and not-build-for-1-1/2-years googledocs plugin

2015-04-16 Thread Boudewijn Rempt
It also didn't work before 2013, I'm afraid -- google changed their api and the plugin broke. At least, that's what I recall. On Thu, 16 Apr 2015, Camilla Boemann wrote: This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123391/ Ship it! has my ble

Re: Review Request 123391: Remove broken and not-build-for-1-1/2-years googledocs plugin

2015-04-16 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123391/#review79084 --- Ship it! has my blessing unless someone offers to fix the plu

Calligra Active interests you? Adopt it for the Qt5/KF5 port now!

2015-04-16 Thread Friedrich W. H. Kossebau
Hi, as you might know, Calligra now also started porting to Qt5/KF5. We are currently reaching the end of stage 1, where everything is readded to the build ("links? done!"), with next stage then to fix anything that broke or regressed. And it seems noone in the current set of active Calligra d

Re: What's new in KReport & KProperty & Predicate

2015-04-16 Thread Jaroslaw Staniek
Hi! Update: - I am keeping new changes to kreport in http://quickgit.kde.org/?p=clones%2Fkreport%2Fstaniek%2Fwork.git @Adam, could you please review? These big boring patches do not fit to reviewboard too much. - I am finalizing the plugin manager work for kreport to make it as recommended in htt

Re: Review Request 123287: frameworks: fixes krita raw plugin build

2015-04-16 Thread Karol Herbst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123287/ --- (Updated April 16, 2015, 8:42 p.m.) Status -- This change has been m

Review Request 123391: Remove broken and not-build-for-1-1/2-years googledocs plugin

2015-04-16 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123391/ --- Review request for Calligra and Mani Chandrasekar. Repository: calligra

Re: Review Request 123383: Saving-as Kexi object should close window of object that will be overwritten

2015-04-16 Thread Jarosław Staniek
> On April 16, 2015, 7:14 p.m., Jarosław Staniek wrote: > > Works! But... wouldn't it be simple to just use > > KexiProject::item(KexiPart::Info *i, const QString &name) in > > getNewObjectInfo() where name is originalName? I was also wondering if the same applies to my code in KexiNameDialog

Re: Review Request 123383: Saving-as Kexi object should close window of object that will be overwritten

2015-04-16 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123383/#review79065 --- Works! But... wouldn't it be simple to just use KexiProject::

Re: Review Request 123352: Fix DockerStylesComboModel

2015-04-16 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123352/ --- (Updated April 16, 2015, 4:48 p.m.) Status -- This change has been m

Re: Review Request 122867: Replace deprecated strstream classes with sstreams in Quattro Pro filter

2015-04-16 Thread Robert Mathias Marmorstein
> On March 10, 2015, 4:35 a.m., Thorsten Zachmann wrote: > > The patch looks good to me. > > Robert Mathias Marmorstein wrote: > I downloaded the tests from calligratests, but haven't been able to get > the QPro plugin to work well enough to test this at all. I'm really hesitant > to comm

Re: Review Request 122867: Replace deprecated strstream classes with sstreams in Quattro Pro filter

2015-04-16 Thread Robert Mathias Marmorstein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122867/ --- (Updated April 16, 2015, 2:44 p.m.) Status -- This change has been m

Review Request 123383: Saving-as Kexi object should close window of object that will be overwritten

2015-04-16 Thread Roman Shtemberko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123383/ --- Review request for Calligra, Adam Pigg, Jarosław Staniek, Radosław Wicik, a

Re: Review Request 123179: workaround Vc cmake issue

2015-04-16 Thread Boudewijn Rempt
> On April 11, 2015, 7:03 a.m., Dmitry Kazakov wrote: > > Hi, Yue! > > > > Do we need the same fix for krita/image/CMakeLists.txt? It also uses > > build_per_arch macro, so it might also be affected I think we'd best fork vc's cmake macros and fix it in there... Maybe also ask Vir on ##vc for

Re: Review Request 115110: Modify vc-based macros to allow passing flags.

2015-04-16 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115110/ --- (Updated April 16, 2015, 11:50 a.m.) Status -- This change has been

Re: Review Request 123287: frameworks: fixes krita raw plugin build

2015-04-16 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123287/#review79047 --- Ship it! Interesting, those changes in kdcraw... Can you push

Re: Review Request 123195: fix various bugs related to footnotes

2015-04-16 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123195/ --- (Updated April 16, 2015, 8:01 a.m.) Status -- This change has been m

Re: Review Request 122867: Replace deprecated strstream classes with sstreams in Quattro Pro filter

2015-04-16 Thread Camilla Boemann
> On March 10, 2015, 4:35 a.m., Thorsten Zachmann wrote: > > The patch looks good to me. > > Robert Mathias Marmorstein wrote: > I downloaded the tests from calligratests, but haven't been able to get > the QPro plugin to work well enough to test this at all. I'm really hesitant > to comm