Re: Review Request 123340: Remove unneeded resource type setting for s_componentData->componentName() + "data"

2015-04-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123340/#review78841 --- Ship it! Yep, you're not using that. git grep locate | grep

Review Request 123340: Remove unneeded resource type setting for s_componentData->componentName() + "data"

2015-04-11 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123340/ --- Review request for Calligra, David Faure and Boudewijn Rempt. Repository:

Re: Review Request 123324: Make kreport compile some more

2015-04-11 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123324/ --- (Updated April 11, 2015, 8:12 p.m.) Status -- This change has been m

Re: Review Request 123324: Make kreport compile some more

2015-04-11 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123324/#review78828 --- Reviewed in every details (I think) and I will integrate it my

Review Request 123338: Fix showing only an empty list of palettes in Karbon's palette bottom bar

2015-04-11 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123338/ --- Review request for Calligra, Sven Langkamp and Yue Liu. Repository: calli

Re: Review Request 123327: Bump version to calligra 3.0 Pre-Alpha

2015-04-11 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123327/ --- (Updated April 11, 2015, 7:35 p.m.) Status -- This change has been m

Re: Review Request 123327: Bump version to calligra 3.0 Pre-Alpha

2015-04-11 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123327/ --- (Updated April 11, 2015, 7:36 p.m.) Review request for Calligra, Andrius

Re: Review Request 123327: Bump version to calligra 3.0 Pre-Alpha

2015-04-11 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123327/#review78815 --- CMakeLists.txt (line 46)

Re: Review Request 123327: Bump version to calligra 3.0 Pre-Alpha

2015-04-11 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123327/ --- (Updated April 11, 2015, 5:18 p.m.) Review request for Calligra, Andrius

Review Request 123331: Cleanup dirs where Krita searches for ICC profiles

2015-04-11 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123331/ --- Review request for Calligra, Cyrille Berger Skott, Boudewijn Rempt, and Sr

Re: Review Request 123327: Bump version to calligra 3.0 Pre-Alpha

2015-04-11 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123327/#review78796 --- Given we are coming closer to code that people actually might

Re: Review Request 123315: Merge filter desktop files for some Karbon import/export filters

2015-04-11 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123315/ --- (Updated April 11, 2015, 9:09 a.m.) Status -- This change has been m

Re: Review Request 123179: workaround Vc cmake issue

2015-04-11 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123179/#review78783 --- Hi, Yue! Do we need the same fix for krita/image/CMakeLists.t