----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123327/#review78796 -----------------------------------------------------------
Given we are coming closer to code that people actually might try, it's time to have a proper version, I agree. No objection from my side. CMakeLists.txt (line 39) <https://git.reviewboard.kde.org/r/123327/#comment53909> Hm, this makes the logic harder to understand. Could the aspect of the calculation of the lib version number be moved out here and into the section below? Even if the code becomes longer. It might stay easier to grasp, because aspects are twisted, but nicely separated. This code is not looked at often, so let's keep it easy to read, as memory will not assist. I propose to instead add this after the first `math()` line: ``` # bump version of unstable some more if(NOT DEFINED CALLIGRA_STABLE) math(EXPR GENERIC_CALLIGRA_LIB_VERSION_MAJOR "${GENERIC_CALLIGRA_LIB_VERSION_MAJOR} + 1") endif() ``` - Friedrich W. H. Kossebau On April 10, 2015, 10:56 nachm., Jarosław Staniek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123327/ > ----------------------------------------------------------- > > (Updated April 10, 2015, 10:56 nachm.) > > > Review request for Calligra, Andrius da Costa Ribas, Kamil Łysik, Friedrich > W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech > Kosowicz. > > > Repository: calligra > > > Description > ------- > > Bump version to calligra 3.0 Pre-Alpha > > > Diffs > ----- > > CMakeLists.txt 7d45871a8a48cebc69a324f97e5379de2965a141 > > Diff: https://git.reviewboard.kde.org/r/123327/diff/ > > > Testing > ------- > > Configures properly to SO version 15 > > > Thanks, > > Jarosław Staniek > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
