Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port

2015-02-24 Thread Jaroslaw Staniek
On 25 February 2015 at 01:01, Friedrich W. H. Kossebau wrote: > Am Dienstag, 24. Februar 2015, 09:47:41 schrieb Boudewijn Rempt: >> As a sidenote, I also want to take the opportunity to do a clean-up step, >> but I'm not sure what the right moment or place is. It might even >> something to do in t

Re: Review Request 122353: Krita: Make KisTextBrushChooser load and display values from the current brush.

2015-02-24 Thread Aleksander Demko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122353/ --- (Updated Feb. 25, 2015, 12:57 a.m.) Status -- This change has been m

Re: Review Request 122354: Krita: Fixed bug Bug 330185 - Text Brush: Letters are upside down when Rotation is set to Drawing Angle

2015-02-24 Thread Aleksander Demko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122354/ --- (Updated Feb. 25, 2015, 12:56 a.m.) Status -- This change has been m

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-24 Thread Friedrich W. H. Kossebau
Started to document all the things written on https://community.kde.org/Calligra/Schedules/3.0/Porting_Plan Please review, update & comment also there :) Cheers Friedrich ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.or

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-24 Thread Friedrich W. H. Kossebau
Am Dienstag, 24. Februar 2015, 09:47:41 schrieb Boudewijn Rempt: > As a sidenote, I also want to take the opportunity to do a clean-up step, > but I'm not sure what the right moment or place is. It might even > something to do in the 2.9 branch after tagging... > > * replace all header guards with

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-24 Thread Friedrich W. H. Kossebau
Am Dienstag, 24. Februar 2015, 08:51:56 schrieb Jaroslaw Staniek: > On 24 February 2015 at 03:55, Friedrich W. H. Kossebau wrote: > > 4. Remove these subdirs: > >3rdparty/kdchart/ > >3rdparty/kdchartpatches/ > >3rdparty/kdgantt/ > >3rdparty/kdganttpatches/ > >libs/koproperty/

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-24 Thread Friedrich W. H. Kossebau
Am Dienstag, 24. Februar 2015, 12:18:29 schrieb Jaroslaw Staniek: > On 24 February 2015 at 11:24, Mario Fux wrote: > > Am Dienstag, 24. Februar 2015, 08.51:56 schrieb Jaroslaw Staniek: > >> On 24 February 2015 at 03:55, Friedrich W. H. Kossebau > >> > To not have people step on each other toes an

Re: Review Request 122681: Change the default iccs for rgb and cmyk spaces.

2015-02-24 Thread Wolthera van Hövell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122681/ --- (Updated Feb. 24, 2015, 10:10 p.m.) Status -- This change has been m

Re: Review Request 121968: Krita: Refactoring of how KisActions are enabled and disabled

2015-02-24 Thread Scott Petrovic
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121968/ --- (Updated Feb. 24, 2015, 9:49 p.m.) Status -- This change has been di

Re: Review Request 122681: Change the default iccs for rgb and cmyk spaces.

2015-02-24 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122681/#review76571 --- Ship it! Ship It! - Boudewijn Rempt On Feb. 22, 2015, 10:5

Re: Review Request 120940: Added parsing of hashtag comments inside imported csv in kexi

2015-02-24 Thread Kamil Łysik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120940/#review76563 --- kexi/plugins/importexport/csv/kexicsvimportdialog.cpp

Re: Review Request 122546: Core changes to implement outliner for Author

2015-02-24 Thread Denis Kuplyakov
> On Фев. 24, 2015, 7:40 п.п., Inge Wallin wrote: > > words/part/CMakeLists.txt, line 94 > > > > > > The outliner is the first real piece of code that is not interesting > > for both Author and Words (although I

Re: Review Request 122546: Core changes to implement outliner for Author

2015-02-24 Thread Denis Kuplyakov
> On Фев. 24, 2015, 7:40 п.п., Inge Wallin wrote: > > libs/kotext/KoTextInlineRdf.cpp, line 126 > > > > > > Why is this a normal pointer when all the other similar pointers are > > QWeakPOinter? Is there someth

Re: Review Request 122546: Core changes to implement outliner for Author

2015-02-24 Thread Inge Wallin
> On Feb. 24, 2015, 8:40 p.m., Inge Wallin wrote: > > libs/rdf/KoDocumentRdf.cpp, line 57 > > > > > > Probably so that the #define can be commented out quickly when you want > > to use debugging. > > Denis Kuply

Re: Review Request 122546: Core changes to implement outliner for Author

2015-02-24 Thread Denis Kuplyakov
> On Фев. 24, 2015, 7:40 п.п., Inge Wallin wrote: > > libs/rdf/KoDocumentRdf.cpp, line 57 > > > > > > Probably so that the #define can be commented out quickly when you want > > to use debugging. It looks like t

Re: Review Request 122546: Core changes to implement outliner for Author

2015-02-24 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122546/#review76559 --- Ship it! The code itself is very clean. I didn't understand a

[calligra/calligra/2.9] /: Fix some unittests

2015-02-24 Thread Boudewijn Rempt
Git commit 6a89e5345da2217575fabaa78bcc321d35726403 by Boudewijn Rempt. Committed on 24/02/2015 at 15:23. Pushed by rempt into branch 'calligra/2.9'. Fix some unittests CCMAIL:calligra-devel@kde.org CCMAIL:kimages...@kde.org See below for the breakdown. Most of the remaining failures are caused

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-24 Thread Mario Fux
Am Dienstag, 24. Februar 2015, 08.51:56 schrieb Jaroslaw Staniek: > On 24 February 2015 at 03:55, Friedrich W. H. Kossebau wrote: Morning [snip] > > Reasoning: > > -- > > Calligra has over 4 M lines (claims openhub.net, not counted myself), so > > expecting one person to do all the ini

Re: Review Request 122707: Fix bad "undo changes" icon scaling in Kexi Property Editor

2015-02-24 Thread Roman Shtemberko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122707/ --- (Updated Feb. 24, 2015, 11:03 a.m.) Status -- This change has been m

Re: Review Request 122707: Fix bad "undo changes" icon scaling in Kexi Property Editor

2015-02-24 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122707/#review76532 --- Ship it! Great! - Jarosław Staniek On Feb. 24, 2015, 11:35

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-24 Thread Boudewijn Rempt
On Tue, 24 Feb 2015, Tomas Mecir wrote: 2015-02-24 3:55 GMT+01:00 Friedrich W. H. Kossebau : PS: Tomas, you had done some initial buildsystem porting experients, right? Would you be willing to be the person to do the initial porting steps? Hmm, do we have more Tomases? Because I d

Re: Review Request 122678: [WIP] KoResource and Krita bundles MD5 generation fix

2015-02-24 Thread Stefano Bonicatti
> On Feb. 24, 2015, 8:57 a.m., Boudewijn Rempt wrote: > > If my patch to make reloading resources from a bundle conflicts, feel free > > to change it away -- it's just that for presets (and I think only for > > presets), we should be able to restore to pristine state at runtime. Maybe > > we s

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-24 Thread Boudewijn Rempt
On Tue, 24 Feb 2015, Jaroslaw Staniek wrote: On 24 February 2015 at 09:47, Boudewijn Rempt wrote: Sorry, I have to interline in Jaroslaw's answer -- apparently I lost my copies of the original mail, or they never arrived :-( As a sidenote, I also want to take the opportunity to do a clean-up s

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-24 Thread Jaroslaw Staniek
On 24 February 2015 at 09:47, Boudewijn Rempt wrote: > Sorry, I have to interline in Jaroslaw's answer -- apparently I lost my > copies of the original mail, or they never arrived :-( > > As a sidenote, I also want to take the opportunity to do a clean-up step, > but I'm not sure what the right mo

Re: Review Request 122678: [WIP] KoResource and Krita bundles MD5 generation fix

2015-02-24 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122678/#review76521 --- If my patch to make reloading resources from a bundle conflict

Re: Review Request 122353: Krita: Make KisTextBrushChooser load and display values from the current brush.

2015-02-24 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122353/#review76520 --- Ship it! Ship It! - Boudewijn Rempt On Feb. 1, 2015, 2:53

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-24 Thread Boudewijn Rempt
Sorry, I have to interline in Jaroslaw's answer -- apparently I lost my copies of the original mail, or they never arrived :-( As a sidenote, I also want to take the opportunity to do a clean-up step, but I'm not sure what the right moment or place is. It might even something to do in the 2.9