----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122681/#review76571 -----------------------------------------------------------
Ship it! Ship It! - Boudewijn Rempt On Feb. 22, 2015, 10:56 p.m., Wolthera van Hövell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122681/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2015, 10:56 p.m.) > > > Review request for Calligra and Boudewijn Rempt. > > > Repository: calligra > > > Description > ------- > > sRGB built-in and scRGB are a bit unpredictable as far as colour profiles > go(scRGB in particular is a strange profile). > > Elle Stone's icc profiles are a lot more stress-tested, hence I suggest we > change to these as defaults for our rgb colour spaces. So I picked the sRGB > and sRGB linear profiles to replace sRGB built-in and scRGB. > v2 was chosen over v4, because v2 enjoys a little more compatibility, and the > v4 advantages are largely meant for cameras. > > Now there's one deeply controversial change I made that doubtlessly will keep > people up at night: > I set the profile for 16bit integer to be linear, as 16bit is enough to enjoy > all the advantages of a linear profile.(Amongst which just better colour > maths) > > I also set our cmyk profiles to default to Chemical Proof, as that's the only > one we ship. > > > Diffs > ----- > > plugins/colorengines/lcms2/colorspaces/cmyk_f32/CmykF32ColorSpace.h e5cc2b8 > plugins/colorengines/lcms2/colorspaces/cmyk_u16/CmykU16ColorSpace.h 059e3e0 > plugins/colorengines/lcms2/colorspaces/cmyk_u8/CmykU8ColorSpace.h c828d27 > plugins/colorengines/lcms2/colorspaces/rgb_f16/RgbF16ColorSpace.h 82bfe7f > plugins/colorengines/lcms2/colorspaces/rgb_f32/RgbF32ColorSpace.h 5ea1a47 > plugins/colorengines/lcms2/colorspaces/rgb_u16/RgbU16ColorSpace.h 0c85fb0 > plugins/colorengines/lcms2/colorspaces/rgb_u8/RgbU8ColorSpace.h b37cb6d > > Diff: https://git.reviewboard.kde.org/r/122681/diff/ > > > Testing > ------- > > It compiles and works, boud requested I put this aside for when we're not > pushing our noses against a release. > > > Thanks, > > Wolthera van Hövell > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
