Re: Review Request 122284: fixed Bug 342168 - JJ: A way to disable the "on hover" layer thumbnail popup.

2015-01-27 Thread Aleksander Demko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122284/ --- (Updated Jan. 28, 2015, 7:02 a.m.) Status -- This change has been ma

Re: Review Request 122284: fixed Bug 342168 - JJ: A way to disable the "on hover" layer thumbnail popup.

2015-01-27 Thread Aleksander Demko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122284/ --- (Updated Jan. 28, 2015, 6:32 a.m.) Review request for Calligra. Changes

Re: Review Request 122284: fixed Bug 342168 - JJ: A way to disable the "on hover" layer thumbnail popup.

2015-01-27 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122284/#review74883 --- Hi, Aleksander! I tested the patch. It works nicely. I have o

Review Request 122284: fixed Bug 342168 - JJ: A way to disable the "on hover" layer thumbnail popup.

2015-01-27 Thread Aleksander Demko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122284/ --- Review request for Calligra. Bugs: 342168 http://bugs.kde.org/show_bu

Re: Review Request 122240: Improve Kexi data-aware cell editing API

2015-01-27 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122240/ --- (Updated Jan. 27, 2015, 10:23 p.m.) Status -- This change has been m

Re: Review Request 122240: Improve Kexi data-aware cell editing API

2015-01-27 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122240/#review74870 --- Ship it! Ship It! - Adam Pigg On Jan. 26, 2015, 12:27 a.m.

Re: Review Request 122278: Additional changes in section handling

2015-01-27 Thread Denis Kuplyakov
> On Янв. 27, 2015, 7:34 п.п., Camilla Boemann wrote: > > libs/kotext/KoSectionManager.cpp, line 120 > > > > > > why no long const ? > > Denis Kuplyakov wrote: > I don't know why, but QHash::find() isn't con

Re: Review Request 122278: Additional changes in section handling

2015-01-27 Thread Denis Kuplyakov
> On Янв. 27, 2015, 7:34 п.п., Camilla Boemann wrote: > > libs/kotext/KoSectionManager.cpp, line 120 > > > > > > why no long const ? I don't know why, but QHash::find() isn't const. Thats why I can't make this

Re: Review Request 122278: Additional changes in section handling

2015-01-27 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122278/#review74840 --- lots of spaces that needs to be fixed libs/kotext/KoSectionM

Review Request 122278: Additional changes in section handling

2015-01-27 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122278/ --- Review request for Calligra, Camilla Boemann and Inge Wallin. Repository:

Re: Review Request 122266: split KWRootAreaProvider into 3 classes for better overview and solving text flwing between textboxes

2015-01-27 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122266/#review74821 --- Ship it! Ok, all of my questions have been answered so I'm sa

Proposal: Add the Support button to the main Calligra page

2015-01-27 Thread Jaroslaw Staniek
Hi Cyrille, I'd like to propose to put the Support button to the main Calligra page in a prominent place (not just in the menu). (I am writing to you as you have the access rights) The button could lead to a small Support page; the content could be like this section: https://www.calligra.org/new

Re: Review Request 122266: split KWRootAreaProvider into 3 classes for better overview and solving text flwing between textboxes

2015-01-27 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122266/ --- (Updated Jan. 27, 2015, 9:48 a.m.) Review request for Calligra. Changes

Re: Review Request 122266: split KWRootAreaProvider into 3 classes for better overview and solving text flwing between textboxes

2015-01-27 Thread Camilla Boemann
> On Jan. 26, 2015, 11:38 p.m., Inge Wallin wrote: > > words/part/KWRootAreaProviderBase.cpp, line 64 > > > > > > This needs to be handled by a method in KoBorder. But this is not > > enough, is it? I see you t

Re: Review Request 122266: split KWRootAreaProvider into 3 classes for better overview and solving text flwing between textboxes

2015-01-27 Thread Camilla Boemann
> On Jan. 26, 2015, 11:38 p.m., Inge Wallin wrote: > > words/part/KWRootAreaProviderBase.cpp, line 157 > > > > > > I think instead that all layout should be in shape coordinates, i.e. > > from (0, 0) to (sizeX,

Re: Review Request 122266: split KWRootAreaProvider into 3 classes for better overview and solving text flwing between textboxes

2015-01-27 Thread Camilla Boemann
> On Jan. 27, 2015, 3:31 a.m., Thorsten Zachmann wrote: > > words/part/KWRootAreaProviderBase.h, line 24 > > > > > > There is also a root area provider outside of words. And I guess this > > handles words specifi