----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122240/#review74870 -----------------------------------------------------------
Ship it! Ship It! - Adam Pigg On Jan. 26, 2015, 12:27 a.m., Jarosław Staniek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122240/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2015, 12:27 a.m.) > > > Review request for Calligra, Andrius da Costa Ribas, Adam Pigg, Roman > Shtemberko, Radosław Wicik, and Wojciech Kosowicz. > > > Repository: calligra > > > Description > ------- > > Improve Kexi data-aware cell editing API > > Plus #1: table view's methods for [editor creation/column width change] now > use specified column/row number instead of current ones. > Plus #2: in addNewRecordRequested() we're avoiding closing editor before > cursor position gets changed (programatically) and avoiding ensuring cell > visibility prior to creating the editor. This can enable implementing > animations in the future. > > > Diffs > ----- > > kexi/plugins/forms/kexiformscrollview.h 898490f > kexi/plugins/forms/kexiformscrollview.cpp 7771ba7 > kexi/widget/dataviewcommon/kexidataawareobjectiface.h c3f66cc > kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp 5c47c10 > kexi/widget/tableview/KexiTableScrollArea.h 836f5cc > kexi/widget/tableview/KexiTableScrollArea.cpp 0a06fc9 > > Diff: https://git.reviewboard.kde.org/r/122240/diff/ > > > Testing > ------- > > functionality of table views remain unchanged > > > Thanks, > > Jarosław Staniek > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
