Re: Review Request 122240: Improve Kexi data-aware cell editing API

2015-01-25 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122240/ --- (Updated Jan. 26, 2015, 1:27 a.m.) Review request for Calligra, Andrius d

Re: Review Request 122254: Remove inline objects from manager in DeleteCommand

2015-01-25 Thread Elvis Stansvik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122254/ --- (Updated Jan. 25, 2015, 11:07 p.m.) Status -- This change has been m

Re: Review Request 122254: Remove inline objects from manager in DeleteCommand

2015-01-25 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122254/#review74728 --- Ship it! Ship It! - Camilla Boemann On Jan. 25, 2015, 10:5

Re: Review Request 122254: Remove inline objects from manager in DeleteCommand

2015-01-25 Thread Elvis Stansvik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122254/ --- (Updated jan 25, 2015, 10:55 e.m.) Review request for Calligra, Camilla B

Review Request 122254: Remove inline objects from manager in DeleteCommand

2015-01-25 Thread Elvis Stansvik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122254/ --- Review request for Calligra, Camilla Boemann and Inge Wallin. Bugs: 30349

Re: Introduction

2015-01-25 Thread Jaroslaw Staniek
Thanks for that. First thing, I noticed you used RelWithDebInfo so it looks like you stopped applying options at the very beginning of instructions. I am looking at a way to improve them; RelWithDebInfo isn't too useful for debugging. On 25 January 2015 at 19:15, Kamalpreet Grewal wrote: > On Sun

Re: Introduction

2015-01-25 Thread Kamalpreet Grewal
On Sun, Jan 25, 2015 at 11:44 PM, Kamalpreet Grewal wrote: > Is something > more to be inspected to get to get the necessary details? -- Kamalpreet Kaur Grewal Blog: http://kamalpreetgrewal.com/ ___ calligra-devel mailing list calligra-devel@kde.org h

Re: Introduction

2015-01-25 Thread Kamalpreet Grewal
On Sun, Jan 25, 2015 at 11:17 PM, Jaroslaw Staniek wrote: > Could you please help us help and give answers to my questions? Others > would benefit too. > Instructions can be improved only this way. This is a team sport :) Yes. And it is done. -- Kamalpreet Kaur Grewal Blog: http://kamalpreetgre

Re: Introduction

2015-01-25 Thread Kamalpreet Grewal
On Sun, Jan 25, 2015 at 12:58 AM, Jaroslaw Staniek wrote: > Hmm, a couple of questions. What's your OS? Please provide all details you > can. > The logs shows that's a non-windows, a non-X11 platform. > Are these entire logs? I have Linux Mint 17 on my HP laptop. I showed the CMakeError.log file

Re: Merge window before the port starts

2015-01-25 Thread Jaroslaw Staniek
On 25 January 2015 at 19:00, Inge Wallin wrote: > On Sunday, January 25, 2015 18:51:50 Jaroslaw Staniek wrote: >> Some future code depends on these fixes: >> https://git.reviewboard.kde.org/r/122240/ >> >> And I expect fixes for further 2.9 releases. > > Fixes for 2.9 is not what we are talking ab

Re: Merge window before the port starts

2015-01-25 Thread Inge Wallin
On Sunday, January 25, 2015 18:51:50 Jaroslaw Staniek wrote: > Some future code depends on these fixes: > https://git.reviewboard.kde.org/r/122240/ > > And I expect fixes for further 2.9 releases. Fixes for 2.9 is not what we are talking about here. This thread is about new features that are re

Re: Re: Merge window before the port starts

2015-01-25 Thread Jaroslaw Staniek
Some future code depends on these fixes: https://git.reviewboard.kde.org/r/122240/ And I expect fixes for further 2.9 releases. On 25 January 2015 at 17:42, C. Boemann wrote: > On Sunday 25 January 2015 14:26:01 Inge Wallin wrote: >> So let's have a short window before the porting starts then. >

Re: Introduction

2015-01-25 Thread Jaroslaw Staniek
On 25 January 2015 at 11:40, Kamalpreet Grewal wrote: > On Sun, Jan 25, 2015 at 3:10 AM, Boudewijn Rempt wrote: >> This is about the most basic of issues: you haven't installed the >> development packages for Qt. That means you have not followed the build >> instructions I linked to. > > I went t

Re: Re: Merge window before the port starts

2015-01-25 Thread Boudewijn Rempt
Me neither. On Sun, 25 Jan 2015, C. Boemann wrote: On Sunday 25 January 2015 14:26:01 Inge Wallin wrote: So let's have a short window before the porting starts then. Could people please reply with what stuff they would like in at that point. For my own part I have nothing. _

Re: Re: Merge window before the port starts

2015-01-25 Thread C. Boemann
On Sunday 25 January 2015 14:26:01 Inge Wallin wrote: > So let's have a short window before the porting starts then. > Could people please reply with what stuff they would like in at that point. For my own part I have nothing. ___ calligra-devel mailing

Re: Merge window before the port starts

2015-01-25 Thread Inge Wallin
On Sunday, January 25, 2015 13:59:57 Boudewijn Rempt wrote: > On Sun, 25 Jan 2015, Inge Wallin wrote: > > I, myself, see no reason why we cannot open master for patches of this > > type > > already now, but I will let you decide whether opening master now or wait > > for a merge window is the best

Re: Merge window before the port starts

2015-01-25 Thread Boudewijn Rempt
On Sun, 25 Jan 2015, Inge Wallin wrote: Hi, As you have probably seen I have two patches that I deem mature on the review board right now. These are branches that have been Ok'ed and are ready to merge. And I know that there are others with similar branches laying around. It would be a pity to

Re: Merge window before the port starts

2015-01-25 Thread C. Boemann
On Sunday 25 January 2015 11:59:39 Inge Wallin wrote: > Hi, > > As you have probably seen I have two patches that I deem mature on the > review board right now. These are branches that have been Ok'ed and are > ready to merge. And I know that there are others with similar branches > laying around.

Merge window before the port starts

2015-01-25 Thread Inge Wallin
Hi, As you have probably seen I have two patches that I deem mature on the review board right now. These are branches that have been Ok'ed and are ready to merge. And I know that there are others with similar branches laying around. It would be a pity to let them bitrot more than necessary. I

Re: Review Request 122238: KoStyleManager independence from kotext

2015-01-25 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122238/ --- (Updated Jan. 25, 2015, 10:58 a.m.) Status -- This change has been m

Re: Review Request 122238: KoStyleManager independence from kotext

2015-01-25 Thread Camilla Boemann
> On Jan. 25, 2015, 10:41 a.m., Inge Wallin wrote: > > libs/kotext/OdfTextTrackStyles.cpp, line 30 > > > > > > Hmm, do we have more than one KoStyleManager? I thought the one handled > > all styles. well some ap

Re: Review Request 122238: KoStyleManager independence from kotext

2015-01-25 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122238/#review74689 --- Ship it! Much much clearer! I do have some comments below

Re: Introduction

2015-01-25 Thread Kamalpreet Grewal
On Sun, Jan 25, 2015 at 3:10 AM, Boudewijn Rempt wrote: > This is about the most basic of issues: you haven't installed the > development packages for Qt. That means you have not followed the build > instructions I linked to. I went through all the instructions. Something was wrong with libphonon