Re: KoPathShape saveOdf and loadOdf oddities

2015-01-17 Thread Thorsten Zachmann
Hello Stefano, > Hello, we have a problem in Krita with drawing a polygon or a bezier curve > (or basicly anything that uses KoPathShape) in a vector layer, then > transform it so that the lines increase their thickness, then save the file > in .kra format and then reload it: the thickness is not

Re: Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-01-17 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122045/ --- (Updated Jan. 18, 2015, 4:26 a.m.) Review request for Calligra, Lassi Nie

Re: Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-01-17 Thread Inge Wallin
> On Jan. 18, 2015, 3:21 a.m., Friedrich W. H. Kossebau wrote: > > filters/libodf2/CMakeLists.txt, line 4 > > > > > > Including libmso files for libodf2 seems wrong as well, similar as > > Charting.h is non-odf st

Re: Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-01-17 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122045/#review74220 --- filters/libmso/MsoUtils.cpp

Re: Review Request 122115: [OS X] source code adaptations to OS X

2015-01-17 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122115/#review74221 --- Ship it! Looks safe enough for me. I added a few comments in

Re: Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-01-17 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122045/#review74212 --- Hm... nothing wrong seen. But one thing seems questionable to

Re: Review Request 122035: Calligra filters: Enhance the odf reader library significantly

2015-01-17 Thread Inge Wallin
> On Jan. 17, 2015, 10:42 p.m., René J.V. Bertin wrote: > > Applies without issues on OS X; any suggestions how to check/test the new > > functionality? > > Inge Wallin wrote: > This are two parts to the patch: > 1. Less code using smart macros to do the same as before. > 2. More

Re: Review Request 122035: Calligra filters: Enhance the odf reader library significantly

2015-01-17 Thread Inge Wallin
> On Jan. 17, 2015, 10:42 p.m., René J.V. Bertin wrote: > > Applies without issues on OS X; any suggestions how to check/test the new > > functionality? This are two parts to the patch: 1. Less code using smart macros to do the same as before. 2. More functionality in the library that is not

Re: Review Request 122114: [OS X] adaptations of the build system (CMake files) to MacPorts

2015-01-17 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122114/#review74205 --- Great to see all those apps now building for you/in the MacPor

Review Request 122115: [OS X] source code adaptations to OS X

2015-01-17 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122115/ --- Review request for Calligra and KDE Software on Mac OS X. Repository: cal

Review Request 122114: [OS X] adaptations of the build system (CMake files) to MacPorts

2015-01-17 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122114/ --- Review request for Calligra and KDE Software on Mac OS X. Repository: cal

Re: Review Request 122035: Calligra filters: Enhance the odf reader library significantly

2015-01-17 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122035/#review74201 --- Applies without issues on OS X; any suggestions how to check/t

Re: KoPathShape saveOdf and loadOdf oddities

2015-01-17 Thread C. Boemann
On Saturday 17 January 2015 09:58:28 Stefano Bonicatti wrote: > Hello, we have a problem in Krita with drawing a polygon or a bezier curve > (or basicly anything that uses KoPathShape) in a vector layer, then > transform it so that the lines increase their thickness, then save the file > in .kra fo

Re: KoPathShape saveOdf and loadOdf oddities

2015-01-17 Thread Boudewijn Rempt
Well, afaict, the vector shape is what loads svg in krita, and that uses Qt's svg support. But if we save attributes into the odf with the koxmlns::svg namespace, that means we're actually mixing in svg properties in the odf, and we should load those properties when present. On Saturday 17 Janu

Re: Introduction

2015-01-17 Thread Boudewijn Rempt
Hi Kamalpreet, The first step is to build calligra: http://community.kde.org/Calligra/Building/Building_Calligra Then, play with the applications to get a good feel for them, then choose a subject to work on! On Saturday 17 January 2015 Jan 12:22:52 Kamalpreet Grewal wrote: > Hi > > My name i

Re: KoPathShape saveOdf and loadOdf oddities

2015-01-17 Thread Stefano Bonicatti
2015-01-17 10:07 GMT+01:00 Boudewijn Rempt : > One possibility that springs to mind is that the work on using svg inside > flake actually never got properly finished. Jan started on it, did a ton of > work, but then real life caught up and he had to stop working on the > project. But if we save it

Re: KoPathShape saveOdf and loadOdf oddities

2015-01-17 Thread Boudewijn Rempt
On Saturday 17 January 2015 Jan 09:58:28 Stefano Bonicatti wrote: > Hello, we have a problem in Krita with drawing a polygon or a bezier curve > (or basicly anything that uses KoPathShape) in a vector layer, then > transform it so that the lines increase their thickness, then save the file > in .kr

KoPathShape saveOdf and loadOdf oddities

2015-01-17 Thread Stefano Bonicatti
Hello, we have a problem in Krita with drawing a polygon or a bezier curve (or basicly anything that uses KoPathShape) in a vector layer, then transform it so that the lines increase their thickness, then save the file in .kra format and then reload it: the thickness is not kept. I've found that th